clk: visconti: Fix uninitialized variable in printk
Subsystems (3)
PATCH 1/1 clk: visconti: Fix uninitialized variable in printk
The "pll_clck" variable is uninitialized. The "ret" error code was supposed to be printed instead.
Fixes b4cbe606dc36 ("clk: visconti: Add support common clock driver and reset driver")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/clk/visconti/pll.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/visconti/pll.c +1 -2
@@ -246,7 +246,6 @@ static struct clk_hw *visconti_register_pll(struct visconti_pll_provider *ctx, {struct clk_init_data init;struct visconti_pll *pll; -struct clk *pll_clk;struct clk_hw *pll_hw_clk;size_t len;int ret;
@@ -277,7 +276,7 @@ static struct clk_hw *visconti_register_pll(struct visconti_pll_provider *ctx, pll_hw_clk = &pll->hw; ret =clk_hw_register (NULL , &pll->hw);if (ret) { -pr_err ("failed to register pll clock %s : %ld\n" , name,PTR_ERR (pll_clk)); +pr_err ("failed to register pll clock %s : %d\n" , name, ret);kfree (pll); pll_hw_clk =ERR_PTR (ret); }
Signature · 1 line
2.20.1
Quoting Dan Carpenter (2022-01-10 23:25:29)
Quoted 6 lines
The "
pll_clck" variable is uninitialized. The "ret" error code was supposed to be printed instead.Fixes b4cbe606dc36 ("clk: visconti: Add support common clock driver and reset driver")Signed-off-by Dan Carpenter <[email protected]>---
Applied to clk-next