Skip to contentSkip to conversation

ARM: dts: at91: sama5d2: Fix PMERRLOC resource size

PATCH In review Tudor Ambarus 3 participants 3 messages Jan 11, 2022 – Feb 24, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: dts: at91: sama5d2: Fix PMERRLOC resource size

PMERRLOC resource size was set to 0x100, which resulted in HSMC_ERRLOCx register being truncated to offset x = 21, causing error correction to fail if more than 22 bit errors and if 24 or 32 bit error correction was supported.

Fixes d9c41bf30cf8 ("ARM: dts: at91: Declare EBI/NAND controllers")
Cc <[email protected]> # 4.13.x

---
v2:
- update commit description
- Cc [email protected]

 arch/arm/boot/dts/sama5d2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/sama5d2.dtsi +1 -1
index 09c741e8ecb8..c700c3b19e4c 100644
@@ -415,7 +415,7 @@ hsmc: hsmc@f8014000 {
 				pmecc: ecc-engine@f8014070 {
 					compatible = "atmel,sama5d2-pmecc";
 					reg = <0xf8014070 0x490>,
-					      <0xf8014500 0x100>;
+					      <0xf8014500 0x200>;
 				};
 			};
 
Signature · 1 line
2.25.1
Acked-by on v2 1/1
#1 lore raw

Hei hei,

Am Dienstag, 11. Januar 2022, 14:23:01 CET schrieb Tudor Ambarus:

Quoted 8 lines

PMERRLOC resource size was set to 0x100, which resulted in HSMC_ERRLOCx register being truncated to offset x = 21, causing error correction to fail if more than 22 bit errors and if 24 or 32 bit error correction was supported.

Fixes d9c41bf30cf8 ("ARM: dts: at91: Declare EBI/NAND controllers")
Cc <[email protected]> # 4.13.x

Greets
Alex

Quoted 20 lines

---
v2:
- update commit description
- Cc [email protected]

 arch/arm/boot/dts/sama5d2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/sama5d2.dtsi +1 -1
index 09c741e8ecb8..c700c3b19e4c 100644
@@ -415,7 +415,7 @@ hsmc: hsmc@f8014000 {
 				pmecc: ecc-engine@f8014070 {
 					compatible = "atmel,sama5d2-pmecc";
 					reg = <0xf8014070 0x490>,
-					      <0xf8014500 0x100>;
+					      <0xf8014500 0x200>;
 				};
 			};
Acked-by on v2 1/1
#2 lore raw
In reply to Tudor Ambarus
Quoted 8 lines · Tudor Ambarus

PMERRLOC resource size was set to 0x100, which resulted in HSMC_ERRLOCx register being truncated to offset x = 21, causing error correction to fail if more than 22 bit errors and if 24 or 32 bit error correction was supported.

Fixes d9c41bf30cf8 ("ARM: dts: at91: Declare EBI/NAND controllers")
Cc <[email protected]> # 4.13.x

Even if it's a fix, as we have this bug for a long time and that we are already at rc5 of the stabilization phase, I take it in at91-dt branch for 5.18 and not in another "fixes" batch.

Best regards,
Nicolas

Quoted 21 lines

---
v2:
- update commit description
- Cc [email protected]

  arch/arm/boot/dts/sama5d2.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/sama5d2.dtsi +1 -1
index 09c741e8ecb8..c700c3b19e4c 100644
@@ -415,7 +415,7 @@ hsmc: hsmc@f8014000 {
  				pmecc: ecc-engine@f8014070 {
  					compatible = "atmel,sama5d2-pmecc";
  					reg = <0xf8014070 0x490>,
-					      <0xf8014500 0x100>;
+					      <0xf8014500 0x200>;
  				};
  			};
 
Signature · 1 line
Nicolas Ferre