genboardscfg: limit to 240 jobs
PATCH 1/1 genboardscfg: limit to 240 jobs
When genboardscfg.py is run on machines with 255 or more cores, the process will consume more than 1024 file descriptors, which is a common standard ulimit for user processes. As a consequence it will fail with a lenghty Python trace, with the almost hidden message:
OSError: [Errno 24] Too many open files
It's somewhat questionable whether that level of parallelity is actually useful for genboardscfg, so we limit the *default* number of jobs to the safe number of 240, to avoid the problem.
If a user persists, she can still force a higher number via the -j parameter - hopefully having raised the ulimit accordingly beforehand.
--- tools/genboardscfg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/genboardscfg.py +1 -1
@@ -430,7 +430,7 @@ def main(): # Add options here parser.add_option('-f', '--force', action="store_true", default=False, help='regenerate the output even if it is new') - parser.add_option('-j', '--jobs', type='int', default=cpu_count, + parser.add_option('-j', '--jobs', type='int', default=min(cpu_count, 240), help='the number of jobs to run simultaneously') parser.add_option('-o', '--output', default=OUTPUT_FILE, help='output file [default=%s]' % OUTPUT_FILE)
Signature · 1 line
2.25.1
Quoted 10 lines · Andre Przywara
When
genboardscfg.pyis run on machines with 255 or more cores, the process will consume more than 1024 file descriptors, which is a common standard ulimit for user processes. As a consequence it will fail with a lenghty Python trace, with the almost hidden message:
OSError: [Errno 24] Too many open filesIt's somewhat questionable whether that level of parallelity is actually useful for genboardscfg, so we limit the *default* number of jobs to the safe number of 240, to avoid the problem.
If a user persists, she can still force a higher number via the -j
Nits:
%s/persists/insists/
%s/she/they/ if you don't specifically mean a female user.
Otherwise
Quoted 20 lines
parameter - hopefully having raised the ulimit accordingly beforehand.
Signed-off-by Andre Przywara <[email protected]>--- tools/genboardscfg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/genboardscfg.py +1
-1@@ -430,7 +430,7 @@ def main(): # Add options here parser.add_option('-f', '--force', action="store_true", default=False, help='regenerate the output even if it is new') - parser.add_option('-j', '--jobs', type='int', default=cpu_count, + parser.add_option('-j', '--jobs', type='int', default=min(cpu_count, 240), help='the number of jobs to run simultaneously') parser.add_option('-o', '--output', default=OUTPUT_FILE, help='output file [default=%s]' % OUTPUT_FILE)
Quoted 13 lines · Andre Przywara
When
genboardscfg.pyis run on machines with 255 or more cores, the process will consume more than 1024 file descriptors, which is a common standard ulimit for user processes. As a consequence it will fail with a lenghty Python trace, with the almost hidden message:
OSError: [Errno 24] Too many open filesIt's somewhat questionable whether that level of parallelity is actually useful for genboardscfg, so we limit the *default* number of jobs to the safe number of 240, to avoid the problem.
If a user persists, she can still force a higher number via the -j parameter - hopefully having raised the ulimit accordingly beforehand.
Quoted 4 lines
Signed-off-by Andre Przywara <[email protected]>--- tools/genboardscfg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Please send such machine. Thank you.
Simon Glass
Reviewed-byQuoted 13 lines · Andre Przywara
When
genboardscfg.pyis run on machines with 255 or more cores, the process will consume more than 1024 file descriptors, which is a common standard ulimit for user processes. As a consequence it will fail with a lenghty Python trace, with the almost hidden message:
OSError: [Errno 24] Too many open filesIt's somewhat questionable whether that level of parallelity is actually useful for genboardscfg, so we limit the *default* number of jobs to the safe number of 240, to avoid the problem.
If a user persists, she can still force a higher number via the -j parameter - hopefully having raised the ulimit accordingly beforehand.
Quoted 4 lines
Signed-off-by Andre Przywara <[email protected]>--- tools/genboardscfg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Please send such machine. Thank you.
Applied to u-boot-dm, thanks!