Skip to contentSkip to conversation

nbd/server.c: Remove unused field

PATCH In review Nir Soffer 3 participants 3 messages Jan 11, 2022 – Jan 12, 2022

lore
Share & tools
lore

Nir Soffer

author
#0 lore raw

PATCH 1/1 nbd/server.c: Remove unused field

NBDRequestData struct has unused QSIMPLEQ_ENTRY filed. It seems that this field exists since the first git commit and was never used.

---
 nbd/server.c | 1 -
 1 file changed, 1 deletion(-)
nbd/server.c +0 -1
index 3927f7789d..ce5b2a1d02 100644
@@ -70,21 +70,20 @@ static int system_errno_to_nbd_errno(int err)
     default:
         return NBD_EINVAL;
     }
 }
 
 /* Definitions for opaque data types */
 
 typedef struct NBDRequestData NBDRequestData;
 
 struct NBDRequestData {
-    QSIMPLEQ_ENTRY(NBDRequestData) entry;
     NBDClient *client;
     uint8_t *data;
     bool complete;
 };
 
 struct NBDExport {
     BlockExport common;
 
     char *name;
     char *description;
Signature · 1 line
2.34.1
#2 lore raw
Quoted 2 lines · Philippe Mathieu-Daudé
Quoted 1 line · Nir Soffer

NBDRequestData struct has unused QSIMPLEQ_ENTRY filed. It seems that

s/filed/field/

Quoted 1 line
Quoted 1 line

this field exists since the first git commit and was never used.

If my git sleuthing is right, that's commit d9a73806, from 2011.

Quoted 7 lines
Quoted 5 lines
---
 nbd/server.c | 1 -
 1 file changed, 1 deletion(-)

Thanks, I'll add that to my NBD queue.

Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org