Skip to contentSkip to conversation

drm/amdkfd: Fix indentation on switch statement

PATCH In review Graham Sider 2 participants 2 messages Jan 11, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdkfd: Fix indentation on switch statement

Cases should be same indentation as switch. Also fix string spanning across multiple lines.

---
 drivers/gpu/drm/amd/amdkfd/kfd_device.c | 55 ++++++++++++-------------
 1 file changed, 27 insertions(+), 28 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_device.c +27 -28
index 2b65d0acae2c..5a47f437b455 100644
@@ -64,34 +64,33 @@ static void kfd_device_info_set_sdma_queue_num(struct kfd_dev *kfd)
 	uint32_t sdma_version = kfd->adev->ip_versions[SDMA0_HWIP][0];
 
 	switch (sdma_version) {
-		case IP_VERSION(4, 0, 0):/* VEGA10 */
-		case IP_VERSION(4, 0, 1):/* VEGA12 */
-		case IP_VERSION(4, 1, 0):/* RAVEN */
-		case IP_VERSION(4, 1, 1):/* RAVEN */
-		case IP_VERSION(4, 1, 2):/* RENOIR */
-		case IP_VERSION(5, 2, 1):/* VANGOGH */
-		case IP_VERSION(5, 2, 3):/* YELLOW_CARP */
-			kfd->device_info.num_sdma_queues_per_engine = 2;
-			break;
-		case IP_VERSION(4, 2, 0):/* VEGA20 */
-		case IP_VERSION(4, 2, 2):/* ARCTURUS */
-		case IP_VERSION(4, 4, 0):/* ALDEBARAN */
-		case IP_VERSION(5, 0, 0):/* NAVI10 */
-		case IP_VERSION(5, 0, 1):/* CYAN_SKILLFISH */
-		case IP_VERSION(5, 0, 2):/* NAVI14 */
-		case IP_VERSION(5, 0, 5):/* NAVI12 */
-		case IP_VERSION(5, 2, 0):/* SIENNA_CICHLID */
-		case IP_VERSION(5, 2, 2):/* NAVY_FLOUNDER */
-		case IP_VERSION(5, 2, 4):/* DIMGREY_CAVEFISH */
-		case IP_VERSION(5, 2, 5):/* BEIGE_GOBY */
-			kfd->device_info.num_sdma_queues_per_engine = 8;
-			break;
-		default:
-			dev_warn(kfd_device,
-				"Default sdma queue per engine(8) is set due to "
-				"mismatch of sdma ip block(SDMA_HWIP:0x%x).\n",
-                                sdma_version);
-			kfd->device_info.num_sdma_queues_per_engine = 8;
+	case IP_VERSION(4, 0, 0):/* VEGA10 */
+	case IP_VERSION(4, 0, 1):/* VEGA12 */
+	case IP_VERSION(4, 1, 0):/* RAVEN */
+	case IP_VERSION(4, 1, 1):/* RAVEN */
+	case IP_VERSION(4, 1, 2):/* RENOIR */
+	case IP_VERSION(5, 2, 1):/* VANGOGH */
+	case IP_VERSION(5, 2, 3):/* YELLOW_CARP */
+		kfd->device_info.num_sdma_queues_per_engine = 2;
+		break;
+	case IP_VERSION(4, 2, 0):/* VEGA20 */
+	case IP_VERSION(4, 2, 2):/* ARCTURUS */
+	case IP_VERSION(4, 4, 0):/* ALDEBARAN */
+	case IP_VERSION(5, 0, 0):/* NAVI10 */
+	case IP_VERSION(5, 0, 1):/* CYAN_SKILLFISH */
+	case IP_VERSION(5, 0, 2):/* NAVI14 */
+	case IP_VERSION(5, 0, 5):/* NAVI12 */
+	case IP_VERSION(5, 2, 0):/* SIENNA_CICHLID */
+	case IP_VERSION(5, 2, 2):/* NAVY_FLOUNDER */
+	case IP_VERSION(5, 2, 4):/* DIMGREY_CAVEFISH */
+	case IP_VERSION(5, 2, 5):/* BEIGE_GOBY */
+		kfd->device_info.num_sdma_queues_per_engine = 8;
+		break;
+	default:
+		dev_warn(kfd_device,
+			"Default sdma queue per engine(8) is set due to mismatch of sdma ip block(SDMA_HWIP:0x%x).\n",
+			sdma_version);
+		kfd->device_info.num_sdma_queues_per_engine = 8;
 	}
 }
 
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only]

________________________________
From: amd-gfx <[email protected]> on behalf of Graham Sider <[email protected]>
Sent: Tuesday, January 11, 2022 3:19 PM
To: [email protected] <[email protected]>
Cc: Sider, Graham <[email protected]>
Subject: [PATCH] drm/amdkfd: Fix indentation on switch statement

Cases should be same indentation as switch. Also fix string spanning across multiple lines.

---
 drivers/gpu/drm/amd/amdkfd/kfd_device.c | 55 ++++++++++++-------------
 1 file changed, 27 insertions(+), 28 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_device.c +27 -28
index 2b65d0acae2c..5a47f437b455 100644
@@ -64,34 +64,33 @@ static void kfd_device_info_set_sdma_queue_num(struct kfd_dev *kfd)
         uint32_t sdma_version = kfd->adev->ip_versions[SDMA0_HWIP][0];
 
         switch (sdma_version) {
-               case IP_VERSION(4, 0, 0):/* VEGA10 */
-               case IP_VERSION(4, 0, 1):/* VEGA12 */
-               case IP_VERSION(4, 1, 0):/* RAVEN */
-               case IP_VERSION(4, 1, 1):/* RAVEN */
-               case IP_VERSION(4, 1, 2):/* RENOIR */
-               case IP_VERSION(5, 2, 1):/* VANGOGH */
-               case IP_VERSION(5, 2, 3):/* YELLOW_CARP */
-                       kfd->device_info.num_sdma_queues_per_engine = 2;
-                       break;
-               case IP_VERSION(4, 2, 0):/* VEGA20 */
-               case IP_VERSION(4, 2, 2):/* ARCTURUS */
-               case IP_VERSION(4, 4, 0):/* ALDEBARAN */
-               case IP_VERSION(5, 0, 0):/* NAVI10 */
-               case IP_VERSION(5, 0, 1):/* CYAN_SKILLFISH */
-               case IP_VERSION(5, 0, 2):/* NAVI14 */
-               case IP_VERSION(5, 0, 5):/* NAVI12 */
-               case IP_VERSION(5, 2, 0):/* SIENNA_CICHLID */
-               case IP_VERSION(5, 2, 2):/* NAVY_FLOUNDER */
-               case IP_VERSION(5, 2, 4):/* DIMGREY_CAVEFISH */
-               case IP_VERSION(5, 2, 5):/* BEIGE_GOBY */
-                       kfd->device_info.num_sdma_queues_per_engine = 8;
-                       break;
-               default:
-                       dev_warn(kfd_device,
-                               "Default sdma queue per engine(8) is set due to "
-                               "mismatch of sdma ip block(SDMA_HWIP:0x%x).\n",
-                                sdma_version);
-                       kfd->device_info.num_sdma_queues_per_engine = 8;
+       case IP_VERSION(4, 0, 0):/* VEGA10 */
+       case IP_VERSION(4, 0, 1):/* VEGA12 */
+       case IP_VERSION(4, 1, 0):/* RAVEN */
+       case IP_VERSION(4, 1, 1):/* RAVEN */
+       case IP_VERSION(4, 1, 2):/* RENOIR */
+       case IP_VERSION(5, 2, 1):/* VANGOGH */
+       case IP_VERSION(5, 2, 3):/* YELLOW_CARP */
+               kfd->device_info.num_sdma_queues_per_engine = 2;
+               break;
+       case IP_VERSION(4, 2, 0):/* VEGA20 */
+       case IP_VERSION(4, 2, 2):/* ARCTURUS */
+       case IP_VERSION(4, 4, 0):/* ALDEBARAN */
+       case IP_VERSION(5, 0, 0):/* NAVI10 */
+       case IP_VERSION(5, 0, 1):/* CYAN_SKILLFISH */
+       case IP_VERSION(5, 0, 2):/* NAVI14 */
+       case IP_VERSION(5, 0, 5):/* NAVI12 */
+       case IP_VERSION(5, 2, 0):/* SIENNA_CICHLID */
+       case IP_VERSION(5, 2, 2):/* NAVY_FLOUNDER */
+       case IP_VERSION(5, 2, 4):/* DIMGREY_CAVEFISH */
+       case IP_VERSION(5, 2, 5):/* BEIGE_GOBY */
+               kfd->device_info.num_sdma_queues_per_engine = 8;
+               break;
+       default:
+               dev_warn(kfd_device,
+                       "Default sdma queue per engine(8) is set due to mismatch of sdma ip block(SDMA_HWIP:0x%x).\n",
+                       sdma_version);
+               kfd->device_info.num_sdma_queues_per_engine = 8;
         }
 }
 

--
2.25.1