media: docs: v4l2grab.c.rst: change unintended assignment
PATCH v2 1/1 media: docs: v4l2grab.c.rst: change unintended assignment
Example should be comparing errno to EINTR instead of doing assignment.
Signed-off-by Daniel Lundberg Pedersen <[email protected]>
--- Documentation/userspace-api/media/v4l/v4l2grab.c.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/userspace-api/media/v4l/v4l2grab.c.rst +1 -1
@@ -134,7 +134,7 @@ file: media/v4l/v4l2grab.c tv.tv_usec = 0; r = select(fd + 1, &fds, NULL, NULL, &tv); - } while ((r == -1 && (errno = EINTR))); + } while ((r == -1 && (errno == EINTR))); if (r == -1) { perror("select"); return errno;
Signature · 1 line
2.33.1
Hi Daniel,
Thanks for fixing up and sending a v2.
Quoting Daniel Lundberg Pedersen (2022-01-12 12:28:09)
Quoted 3 lines
Example should be comparing errno to EINTR instead of doing assignment.
Signed-off-by Daniel Lundberg Pedersen <[email protected]>
I think my tag from the previous patch still holds here for the change itself.
Reviewed-by Kieran Bingham <[email protected]>
Quoted 20 lines
--- Documentation/userspace-api/media/v4l/v4l2grab.c.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/userspace-api/media/v4l/v4l2grab.c.rst +1
-1@@ -134,7 +134,7 @@ file: media/v4l/v4l2grab.c tv.tv_usec = 0; r = select(fd + 1, &fds, NULL, NULL, &tv); - } while ((r == -1 && (errno = EINTR))); + } while ((r == -1 && (errno == EINTR))); if (r == -1) { perror("select"); return errno;Signature · 1 line
2.33.1