Skip to contentSkip to conversation

drm/i915: Recalculate CDCLK if plane scaling ratio changes

PATCH In review Stanislav Lisovskiy 4 participants 10 messages Jan 11, 2022 – Jan 13, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Recalculate CDCLK if plane scaling ratio changes

Currently we only recalculate CDCLK if active plane mask changes or if we do a full modeset, however according to BSpec required Dbuf bandwidth calculations also depend on pipe/plane scaling ratio, which means that CDCLK must be recalculated everytime plane scaling ratio changes, because it affects display buffer bandwidth requirements.

---
 drivers/gpu/drm/i915/display/intel_display.c | 63 +++++++++++++++++++-
 1 file changed, 60 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +60 -3
index bf7ce684dd8e..2c616348e993 100644
@@ -7499,13 +7499,65 @@ static int intel_bigjoiner_add_affected_planes(struct intel_atomic_state *state)
 	return 0;
 }
 
+static bool scaling_affects_cdclk(struct intel_plane_state *old_plane_state,
+				  struct intel_plane_state *new_plane_state)
+{
+	int old_src_w = drm_rect_width(&old_plane_state->uapi.src) >> 16;
+	int old_src_h = drm_rect_height(&old_plane_state->uapi.src) >> 16;
+	int old_dst_w = drm_rect_width(&old_plane_state->uapi.dst);
+	int old_dst_h = drm_rect_height(&old_plane_state->uapi.dst);
+	int new_src_w = drm_rect_width(&new_plane_state->uapi.src) >> 16;
+	int new_src_h = drm_rect_height(&new_plane_state->uapi.src) >> 16;
+	int new_dst_w = drm_rect_width(&new_plane_state->uapi.dst);
+	int new_dst_h = drm_rect_height(&new_plane_state->uapi.dst);
+	int old_hscale_ratio, new_hscale_ratio;
+	int old_vscale_ratio, new_vscale_ratio;
+
+	if (needs_scaling(old_plane_state) != needs_scaling(new_plane_state))
+		return true;
+
+	if (!old_dst_w || !old_dst_h)
+		return true;
+
+	DRM_DEBUG_KMS("old_dst_w %d old_dst_h %d\n", old_dst_w, old_dst_h);
+
+	old_hscale_ratio = DIV_ROUND_UP(old_src_w, old_dst_w);
+	old_vscale_ratio = DIV_ROUND_UP(old_src_h, old_dst_h);
+
+	if (!new_dst_w || !new_dst_h)
+		return true;
+
+	DRM_DEBUG_KMS("new_dst_w %d new_dst_h %d\n", new_dst_w, new_dst_h);
+
+	new_hscale_ratio = DIV_ROUND_UP(new_src_w, new_dst_w);
+	new_vscale_ratio = DIV_ROUND_UP(new_src_h, new_dst_h);
+
+	DRM_DEBUG_KMS("new_hscale_ratio %d new_vscale_ratio %d "
+		      "old_hscale_ratio %d old_vscale_ratio %d\n",
+		      new_hscale_ratio, new_vscale_ratio,
+		      old_hscale_ratio, old_vscale_ratio);
+
+	if ((old_hscale_ratio != new_hscale_ratio) ||
+	    (old_vscale_ratio != new_vscale_ratio)) {
+		DRM_DEBUG_KMS("Scaling ratios changed from %dx%d"
+			      " to %dx%d - need cdclk recalc\n",
+			      old_hscale_ratio, old_vscale_ratio,
+			      new_hscale_ratio, new_vscale_ratio);
+		return true;
+	}
+
+	return false;
+}
+
 static int intel_atomic_check_planes(struct intel_atomic_state *state)
 {
 	struct drm_i915_private *dev_priv = to_i915(state->base.dev);
 	struct intel_crtc_state *old_crtc_state, *new_crtc_state;
 	struct intel_plane_state *plane_state;
+	struct intel_plane_state *old_plane_state;
 	struct intel_plane *plane;
 	struct intel_crtc *crtc;
+	bool need_cdclk_calc = false;
 	int i, ret;
 
 	ret = icl_add_linked_planes(state);
@@ -7516,7 +7568,7 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 	if (ret)
 		return ret;
 
-	for_each_new_intel_plane_in_state(state, plane, plane_state, i) {
+	for_each_oldnew_intel_plane_in_state(state, plane, old_plane_state, plane_state, i) {
 		ret = intel_plane_atomic_check(state, plane);
 		if (ret) {
 			drm_dbg_atomic(&dev_priv->drm,
@@ -7524,6 +7576,9 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 				       plane->base.base.id, plane->base.name);
 			return ret;
 		}
+
+		if (scaling_affects_cdclk(old_plane_state, plane_state))
+			need_cdclk_calc = true;
 	}
 
 	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
@@ -7539,18 +7594,20 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 		 * the planes' minimum cdclk calculation. Add such planes
 		 * to the state before we compute the minimum cdclk.
 		 */
-		if (!active_planes_affects_min_cdclk(dev_priv))
+		if (!active_planes_affects_min_cdclk(dev_priv) && !need_cdclk_calc)
 			continue;
 
 		old_active_planes = old_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
 		new_active_planes = new_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
 
-		if (hweight8(old_active_planes) == hweight8(new_active_planes))
+		if ((hweight8(old_active_planes) == hweight8(new_active_planes)) && !need_cdclk_calc)
 			continue;
 
 		ret = intel_crtc_add_planes_to_state(state, crtc, new_active_planes);
 		if (ret)
 			return ret;
+
+
 	}
 
 	return 0;
Signature · 1 line
2.24.1.485.gad05a3d8e5
maintainer
#1 lore raw
Quoted 47 lines · Stanislav Lisovskiy

Currently we only recalculate CDCLK if active plane mask changes or if we do a full modeset, however according to BSpec required Dbuf bandwidth calculations also depend on pipe/plane scaling ratio, which means that CDCLK must be recalculated everytime plane scaling ratio changes, because it affects display buffer bandwidth requirements.

---
 drivers/gpu/drm/i915/display/intel_display.c | 63 +++++++++++++++++++-
 1 file changed, 60 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +27 -0
index bf7ce684dd8e..2c616348e993 100644
@@ -7499,13 +7499,65 @@ static int intel_bigjoiner_add_affected_planes(struct intel_atomic_state *state)
 	return 0;
 }
 
+static bool scaling_affects_cdclk(struct intel_plane_state *old_plane_state,
+				  struct intel_plane_state *new_plane_state)
+{
+	int old_src_w = drm_rect_width(&old_plane_state->uapi.src) >> 16;
+	int old_src_h = drm_rect_height(&old_plane_state->uapi.src) >> 16;
+	int old_dst_w = drm_rect_width(&old_plane_state->uapi.dst);
+	int old_dst_h = drm_rect_height(&old_plane_state->uapi.dst);
+	int new_src_w = drm_rect_width(&new_plane_state->uapi.src) >> 16;
+	int new_src_h = drm_rect_height(&new_plane_state->uapi.src) >> 16;
+	int new_dst_w = drm_rect_width(&new_plane_state->uapi.dst);
+	int new_dst_h = drm_rect_height(&new_plane_state->uapi.dst);
+	int old_hscale_ratio, new_hscale_ratio;
+	int old_vscale_ratio, new_vscale_ratio;
+
+	if (needs_scaling(old_plane_state) != needs_scaling(new_plane_state))
+		return true;
+
+	if (!old_dst_w || !old_dst_h)
+		return true;
+
+	DRM_DEBUG_KMS("old_dst_w %d old_dst_h %d\n", old_dst_w, old_dst_h);
+
+	old_hscale_ratio = DIV_ROUND_UP(old_src_w, old_dst_w);
+	old_vscale_ratio = DIV_ROUND_UP(old_src_h, old_dst_h);
+
+	if (!new_dst_w || !new_dst_h)
+		return true;

drivers/gpu/drm/i915/display/intel_display.c static int intel_bigjoiner_add_affected_planes(struct intel_atomic_state *state) · line 7538

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display.c +10 -0
+
+	DRM_DEBUG_KMS("new_dst_w %d new_dst_h %d\n", new_dst_w, new_dst_h);
+
+	new_hscale_ratio = DIV_ROUND_UP(new_src_w, new_dst_w);
+	new_vscale_ratio = DIV_ROUND_UP(new_src_h, new_dst_h);
+
+	DRM_DEBUG_KMS("new_hscale_ratio %d new_vscale_ratio %d "
+		      "old_hscale_ratio %d old_vscale_ratio %d\n",
+		      new_hscale_ratio, new_vscale_ratio,
+		      old_hscale_ratio, old_vscale_ratio);

All of the debug logging seem excessive? Also, please use drm_dbg_atomic or drm_dbg_kms instead of DRM_DEBUG_KMS for the ones that need to stay.

BR,
Jani.

Quoted 67 lines
drivers/gpu/drm/i915/display/intel_display.c +23 -3
+
+	if ((old_hscale_ratio != new_hscale_ratio) ||
+	    (old_vscale_ratio != new_vscale_ratio)) {
+		DRM_DEBUG_KMS("Scaling ratios changed from %dx%d"
+			      " to %dx%d - need cdclk recalc\n",
+			      old_hscale_ratio, old_vscale_ratio,
+			      new_hscale_ratio, new_vscale_ratio);
+		return true;
+	}
+
+	return false;
+}
+
 static int intel_atomic_check_planes(struct intel_atomic_state *state)
 {
 	struct drm_i915_private *dev_priv = to_i915(state->base.dev);
 	struct intel_crtc_state *old_crtc_state, *new_crtc_state;
 	struct intel_plane_state *plane_state;
+	struct intel_plane_state *old_plane_state;
 	struct intel_plane *plane;
 	struct intel_crtc *crtc;
+	bool need_cdclk_calc = false;
 	int i, ret;
 
 	ret = icl_add_linked_planes(state);
@@ -7516,7 +7568,7 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 	if (ret)
 		return ret;
 
-	for_each_new_intel_plane_in_state(state, plane, plane_state, i) {
+	for_each_oldnew_intel_plane_in_state(state, plane, old_plane_state, plane_state, i) {
 		ret = intel_plane_atomic_check(state, plane);
 		if (ret) {
 			drm_dbg_atomic(&dev_priv->drm,
@@ -7524,6 +7576,9 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 				       plane->base.base.id, plane->base.name);
 			return ret;
 		}
+
+		if (scaling_affects_cdclk(old_plane_state, plane_state))
+			need_cdclk_calc = true;
 	}
 
 	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
@@ -7539,18 +7594,20 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 		 * the planes' minimum cdclk calculation. Add such planes
 		 * to the state before we compute the minimum cdclk.
 		 */
-		if (!active_planes_affects_min_cdclk(dev_priv))
+		if (!active_planes_affects_min_cdclk(dev_priv) && !need_cdclk_calc)
 			continue;
 
 		old_active_planes = old_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
 		new_active_planes = new_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
 
-		if (hweight8(old_active_planes) == hweight8(new_active_planes))
+		if ((hweight8(old_active_planes) == hweight8(new_active_planes)) && !need_cdclk_calc)
 			continue;
 
 		ret = intel_crtc_add_planes_to_state(state, crtc, new_active_planes);
 		if (ret)
 			return ret;
+
+
 	}
 
 	return 0;
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#2 lore raw
Quoted 53 lines · Jani Nikula
Quoted 52 lines · Stanislav Lisovskiy

Currently we only recalculate CDCLK if active plane mask changes or if we do a full modeset, however according to BSpec required Dbuf bandwidth calculations also depend on pipe/plane scaling ratio, which means that CDCLK must be recalculated everytime plane scaling ratio changes, because it affects display buffer bandwidth requirements.

---
 drivers/gpu/drm/i915/display/intel_display.c | 63 +++++++++++++++++++-
 1 file changed, 60 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +32 -0
index bf7ce684dd8e..2c616348e993 100644
@@ -7499,13 +7499,65 @@ static int intel_bigjoiner_add_affected_planes(struct intel_atomic_state *state)
 	return 0;
 }
 
+static bool scaling_affects_cdclk(struct intel_plane_state *old_plane_state,
+				  struct intel_plane_state *new_plane_state)
+{
+	int old_src_w = drm_rect_width(&old_plane_state->uapi.src) >> 16;
+	int old_src_h = drm_rect_height(&old_plane_state->uapi.src) >> 16;
+	int old_dst_w = drm_rect_width(&old_plane_state->uapi.dst);
+	int old_dst_h = drm_rect_height(&old_plane_state->uapi.dst);
+	int new_src_w = drm_rect_width(&new_plane_state->uapi.src) >> 16;
+	int new_src_h = drm_rect_height(&new_plane_state->uapi.src) >> 16;
+	int new_dst_w = drm_rect_width(&new_plane_state->uapi.dst);
+	int new_dst_h = drm_rect_height(&new_plane_state->uapi.dst);
+	int old_hscale_ratio, new_hscale_ratio;
+	int old_vscale_ratio, new_vscale_ratio;
+
+	if (needs_scaling(old_plane_state) != needs_scaling(new_plane_state))
+		return true;
+
+	if (!old_dst_w || !old_dst_h)
+		return true;
+
+	DRM_DEBUG_KMS("old_dst_w %d old_dst_h %d\n", old_dst_w, old_dst_h);
+
+	old_hscale_ratio = DIV_ROUND_UP(old_src_w, old_dst_w);
+	old_vscale_ratio = DIV_ROUND_UP(old_src_h, old_dst_h);
+
+	if (!new_dst_w || !new_dst_h)
+		return true;
+
+	DRM_DEBUG_KMS("new_dst_w %d new_dst_h %d\n", new_dst_w, new_dst_h);
+
+	new_hscale_ratio = DIV_ROUND_UP(new_src_w, new_dst_w);
+	new_vscale_ratio = DIV_ROUND_UP(new_src_h, new_dst_h);
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_display.c static int intel_bigjoiner_add_affected_planes(struct intel_atomic_state *state) · line 7538

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display.c +5 -0
+
+	DRM_DEBUG_KMS("new_hscale_ratio %d new_vscale_ratio %d "
+		      "old_hscale_ratio %d old_vscale_ratio %d\n",
+		      new_hscale_ratio, new_vscale_ratio,
+		      old_hscale_ratio, old_vscale_ratio);

All of the debug logging seem excessive? Also, please use drm_dbg_atomic or drm_dbg_kms instead of DRM_DEBUG_KMS for the ones that need to stay.

Yes, I should probably leave only message repoting that cdclk has to be recalculated. Otherwise indeed seems excessive - was just using it for debugging.

Stan

Quoted 74 lines

BR,
Jani.

Quoted 67 lines
drivers/gpu/drm/i915/display/intel_display.c +23 -3
+
+	if ((old_hscale_ratio != new_hscale_ratio) ||
+	    (old_vscale_ratio != new_vscale_ratio)) {
+		DRM_DEBUG_KMS("Scaling ratios changed from %dx%d"
+			      " to %dx%d - need cdclk recalc\n",
+			      old_hscale_ratio, old_vscale_ratio,
+			      new_hscale_ratio, new_vscale_ratio);
+		return true;
+	}
+
+	return false;
+}
+
 static int intel_atomic_check_planes(struct intel_atomic_state *state)
 {
 	struct drm_i915_private *dev_priv = to_i915(state->base.dev);
 	struct intel_crtc_state *old_crtc_state, *new_crtc_state;
 	struct intel_plane_state *plane_state;
+	struct intel_plane_state *old_plane_state;
 	struct intel_plane *plane;
 	struct intel_crtc *crtc;
+	bool need_cdclk_calc = false;
 	int i, ret;
 
 	ret = icl_add_linked_planes(state);
@@ -7516,7 +7568,7 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 	if (ret)
 		return ret;
 
-	for_each_new_intel_plane_in_state(state, plane, plane_state, i) {
+	for_each_oldnew_intel_plane_in_state(state, plane, old_plane_state, plane_state, i) {
 		ret = intel_plane_atomic_check(state, plane);
 		if (ret) {
 			drm_dbg_atomic(&dev_priv->drm,
@@ -7524,6 +7576,9 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 				       plane->base.base.id, plane->base.name);
 			return ret;
 		}
+
+		if (scaling_affects_cdclk(old_plane_state, plane_state))
+			need_cdclk_calc = true;
 	}
 
 	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
@@ -7539,18 +7594,20 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 		 * the planes' minimum cdclk calculation. Add such planes
 		 * to the state before we compute the minimum cdclk.
 		 */
-		if (!active_planes_affects_min_cdclk(dev_priv))
+		if (!active_planes_affects_min_cdclk(dev_priv) && !need_cdclk_calc)
 			continue;
 
 		old_active_planes = old_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
 		new_active_planes = new_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
 
-		if (hweight8(old_active_planes) == hweight8(new_active_planes))
+		if ((hweight8(old_active_planes) == hweight8(new_active_planes)) && !need_cdclk_calc)
 			continue;
 
 		ret = intel_crtc_add_planes_to_state(state, crtc, new_active_planes);
 		if (ret)
 			return ret;
+
+
 	}
 
 	return 0;
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#3 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Recalculate CDCLK if plane scaling ratio changes

In reply to Stanislav Lisovskiy
== Series Details ==

== Series Details ==

Series: drm/i915: Recalculate CDCLK if plane scaling ratio changes
URL : https://patchwork.freedesktop.org/series/98750/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
fe1ac4423d86 drm/i915: Recalculate CDCLK if plane scaling ratio changes
-:61: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'old_hscale_ratio != new_hscale_ratio'
#61: FILE: drivers/gpu/drm/i915/display/intel_display.c:7540:
+	if ((old_hscale_ratio != new_hscale_ratio) ||
+	    (old_vscale_ratio != new_vscale_ratio)) {

-:61: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'old_vscale_ratio != new_vscale_ratio' #61: FILE: drivers/gpu/drm/i915/display/intel_display.c:7540:
+ if ((old_hscale_ratio != new_hscale_ratio) ||
+ (old_vscale_ratio != new_vscale_ratio)) {

-:116: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #116: FILE: drivers/gpu/drm/i915/display/intel_display.c:7603:
+ if ((hweight8(old_active_planes) == hweight8(new_active_planes)) && !need_cdclk_calc)

-:123: CHECK:LINE_SPACING: Please don't use multiple blank lines #123: FILE: drivers/gpu/drm/i915/display/intel_display.c:7610:
+
+

total: 0 errors, 1 warnings, 3 checks, 104 lines checked

#4 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Recalculate CDCLK if plane scaling ratio changes

In reply to Stanislav Lisovskiy
== Series Details ==

== Series Details ==

Series: drm/i915: Recalculate CDCLK if plane scaling ratio changes
URL : https://patchwork.freedesktop.org/series/98750/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11066 -> Patchwork_21969
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/index.html

Participating hosts (43 -> 42)
------------------------------

Additional (3): fi-icl-u2 bat-adlp-4 fi-pnv-d510
Missing (4): fi-bdw-samus fi-tgl-1115g4 fi-bsw-cyan bat-jsl-1

Known issues
------------

Here are the changes found in Patchwork_21969 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-icl-u2: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/fi-icl-u2/igt@amdgpu/[email protected]

* igt@gem_exec_suspend@basic-s3@smem:
- fi-skl-6600u: NOTRUN -> [INCOMPLETE][2] ([i915#4547])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/fi-skl-6600u/igt@gem_exec_suspend@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/fi-icl-u2/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- bat-adlp-4: NOTRUN -> [SKIP][4] ([i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/bat-adlp-4/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/fi-icl-u2/igt@[email protected]

* igt@gem_tiled_pread_basic:
- bat-adlp-4: NOTRUN -> [SKIP][6] ([i915#3282])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/bat-adlp-4/igt@gem_tiled_pread_basic.html

* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][7] -> [INCOMPLETE][8] ([i915#3921])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/fi-snb-2600/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/fi-snb-2600/igt@i915_selftest@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][9] ([fdo#111827]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/bat-adlp-4/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][10] ([fdo#111827]) +8 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/fi-icl-u2/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: NOTRUN -> [SKIP][11] ([fdo#109278]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/fi-icl-u2/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][12] ([i915#4103]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/bat-adlp-4/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][13] ([fdo#109285])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/fi-icl-u2/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][14] ([fdo#109285])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/bat-adlp-4/igt@[email protected]

* igt@prime_vgem@basic-fence-read:
- bat-adlp-4: NOTRUN -> [SKIP][15] ([i915#3291] / [i915#3708]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/bat-adlp-4/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][16] ([fdo#109271]) +57 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/fi-pnv-d510/igt@[email protected]
- fi-icl-u2: NOTRUN -> [SKIP][17] ([i915#3301])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/fi-icl-u2/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][18] ([i915#3301] / [i915#3708])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/bat-adlp-4/igt@[email protected]

#### Possible fixes ####

* igt@kms_flip@basic-flip-vs-wf_vblank@a-vga1:
- fi-bwr-2160: [FAIL][19] ([i915#2122]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/fi-bwr-2160/igt@kms_flip@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/fi-bwr-2160/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [DMESG-WARN][21] ([i915#4269]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/fi-cml-u2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/fi-cml-u2/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613

Build changes
-------------

* Linux: CI_DRM_11066 -> Patchwork_21969

CI-20190529: 20190529
CI_DRM_11066: fc076e8fc52ed40fee33f416a4475a57219011a5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6326: ec75f64fcbcf4aac58fbf1bf629e8f59b19db4ce @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21969: fe1ac4423d86b9ed8469294f4dade7722571cb7c @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

fe1ac4423d86 drm/i915: Recalculate CDCLK if plane scaling ratio changes

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/index.html

#5 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Recalculate CDCLK if plane scaling ratio changes

In reply to Stanislav Lisovskiy
== Series Details ==

== Series Details ==

Series: drm/i915: Recalculate CDCLK if plane scaling ratio changes
URL : https://patchwork.freedesktop.org/series/98750/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11066_full -> Patchwork_21969_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_21969_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_21969_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_21969_full:

### IGT changes ###

#### Possible regressions ####

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-skl: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl2/igt@[email protected]

* igt@kms_cursor_legacy@all-pipes-forked-bo:
- shard-iclb: [PASS][2] -> [INCOMPLETE][3] +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb8/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-iclb2/igt@[email protected]

* igt@kms_cursor_legacy@all-pipes-forked-move:
- shard-tglb: [PASS][4] -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-tglb7/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb6/igt@[email protected]

* igt@kms_cursor_legacy@pipe-b-forked-move:
- shard-kbl: [PASS][6] -> [INCOMPLETE][7] +5 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-kbl4/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-kbl3/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_21969_full that come from known issues:

### CI changes ###

#### Possible fixes ####

* boot:
- shard-glk: ([PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [FAIL][29], [PASS][30], [PASS][31], [PASS][32]) ([i915#4392]) -> ([PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk1/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk1/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk1/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk2/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk2/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk2/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk3/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk3/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk3/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk4/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk5/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk5/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk5/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk6/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk6/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk7/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk7/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk7/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk8/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk8/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk8/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk9/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk9/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk8/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk5/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk6/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk6/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk7/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk7/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk7/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk9/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk9/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk9/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk8/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk8/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk1/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk1/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk2/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk2/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk2/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk3/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk3/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk3/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk4/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk4/boot.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk4/boot.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk5/boot.html

### IGT changes ###

#### Issues hit ####

* igt@feature_discovery@psr2:
- shard-iclb: [PASS][58] -> [SKIP][59] ([i915#658])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb2/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-iclb8/igt@[email protected]

* igt@gem_ctx_shared@exec-single-timeline@bcs0:
- shard-iclb: [PASS][60] -> [DMESG-WARN][61] ([i915#4391]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb1/igt@gem_ctx_shared@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-iclb7/igt@gem_ctx_shared@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][62] -> [FAIL][63] ([i915#232])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-tglb6/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb8/igt@[email protected]
- shard-skl: [PASS][64] -> [TIMEOUT][65] ([i915#3063])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-skl1/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl3/igt@[email protected]

* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [PASS][66] -> [SKIP][67] ([i915#4525]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb4/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-iclb5/igt@[email protected]

* igt@gem_exec_capture@pi@rcs0:
- shard-skl: NOTRUN -> [INCOMPLETE][68] ([i915#4547])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl6/igt@gem_exec_capture@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-glk: NOTRUN -> [FAIL][69] ([i915#2842])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][70] -> [FAIL][71] ([i915#2842])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk5/igt@gem_exec_fair@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk9/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@basic:
- shard-kbl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#4613])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-kbl6/igt@[email protected]

* igt@gem_lmem_swapping@heavy-verify-random:
- shard-skl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#4613])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl2/igt@[email protected]

* igt@gem_pread@exhaustion:
- shard-glk: NOTRUN -> [WARN][74] ([i915#2658])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk5/igt@[email protected]

* igt@gem_pwrite@basic-exhaustion:
- shard-kbl: NOTRUN -> [WARN][75] ([i915#2658])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-kbl6/igt@[email protected]

* igt@gem_pxp@verify-pxp-execution-after-suspend-resume:
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#4270]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@gem_render_copy@y-tiled-to-vebox-x-tiled:
- shard-glk: NOTRUN -> [SKIP][77] ([fdo#109271]) +37 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk5/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-iclb: NOTRUN -> [SKIP][78] ([i915#3323])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-iclb8/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][79] ([i915#3323])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb7/igt@[email protected]

* igt@gem_userptr_blits@unsync-overlap:
- shard-tglb: NOTRUN -> [SKIP][80] ([i915#3297])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][81] -> [DMESG-WARN][82] ([i915#180]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-kbl6/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-kbl4/igt@[email protected]

* igt@gen9_exec_parse@shadow-peek:
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#2527] / [i915#2856]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][84] ([i915#2856])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-iclb8/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][85] -> [FAIL][86] ([i915#454])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb1/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-iclb3/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#1937])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-kbl6/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_rc6_residency@media-rc6-accuracy:
- shard-tglb: NOTRUN -> [SKIP][88] ([fdo#109289] / [fdo#111719])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [PASS][89] -> [FAIL][90] ([i915#2521])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-skl7/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl7/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-skl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#3777])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl2/igt@[email protected]

* igt@kms_big_fb@y-tiled-16bpp-rotate-0:
- shard-glk: [PASS][92] -> [DMESG-WARN][93] ([i915#118]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk2/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk6/igt@[email protected]

* igt@kms_big_fb@y-tiled-8bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][94] ([fdo#111614])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@kms_big_fb@yf-tiled-64bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][95] ([fdo#111615])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#109278]) +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-iclb8/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs.html

* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#3886]) +4 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-kbl6/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#3886])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk5/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][99] ([i915#3689] / [i915#3886])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][100] ([fdo#109271] / [i915#3886]) +2 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl6/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][101] ([i915#3689]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-d-crc-primary-rotation-180-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][102] ([fdo#111615] / [i915#3689]) +2 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@kms_ccs@pipe-d-crc-primary-rotation-180-yf_tiled_ccs.html

* igt@kms_chamelium@common-hpd-after-suspend:
- shard-apl: NOTRUN -> [SKIP][103] ([fdo#109271] / [fdo#111827]) +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-apl1/igt@[email protected]

* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-glk: NOTRUN -> [SKIP][104] ([fdo#109271] / [fdo#111827]) +2 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk5/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-0-75:
- shard-kbl: NOTRUN -> [SKIP][105] ([fdo#109271] / [fdo#111827]) +3 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-kbl6/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-red-to-blue:
- shard-tglb: NOTRUN -> [SKIP][106] ([fdo#109284] / [fdo#111827]) +3 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb7/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][107] ([fdo#109271] / [fdo#111827]) +3 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][108] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-iclb8/igt@[email protected]

* igt@kms_content_protection@srm:
- shard-tglb: NOTRUN -> [SKIP][109] ([i915#1063])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding:
- shard-tglb: NOTRUN -> [SKIP][110] ([i915#3359]) +2 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen:
- shard-kbl: NOTRUN -> [SKIP][111] ([fdo#109271]) +43 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-kbl3/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-512x170-random:
- shard-tglb: NOTRUN -> [SKIP][112] ([fdo#109279] / [i915#3359])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-32x32-sliding:
- shard-tglb: NOTRUN -> [SKIP][113] ([i915#3319])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@kms_cursor_legacy@all-pipes-single-move:
- shard-kbl: [PASS][114] -> [INCOMPLETE][115] ([i915#794])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-kbl7/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-kbl7/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- shard-tglb: NOTRUN -> [SKIP][116] ([i915#4103])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-tglb: [PASS][117] -> [FAIL][118] ([i915#2370] / [i915#533])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-tglb2/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb6/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][119] -> [FAIL][120] ([i915#2346] / [i915#533])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-skl: [PASS][121] -> [FAIL][122] ([i915#2346]) +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-skl2/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl3/igt@[email protected]

* igt@kms_flip@2x-flip-vs-panning-interruptible:
- shard-iclb: NOTRUN -> [SKIP][123] ([fdo#109274])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-iclb8/igt@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate:
- shard-tglb: NOTRUN -> [SKIP][124] ([fdo#109274] / [fdo#111825]) +3 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1:
- shard-skl: [PASS][125] -> [FAIL][126] ([i915#2122]) +2 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-skl2/igt@kms_flip@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl3/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][127] -> [FAIL][128] ([i915#79]) +2 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-skl9/igt@kms_flip@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-apl: [PASS][129] -> [DMESG-WARN][130] ([i915#180]) +1 similar issue
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-apl4/igt@kms_flip@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-apl2/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling:
- shard-tglb: NOTRUN -> [SKIP][131] ([i915#2587])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb6/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-glk: [PASS][132] -> [FAIL][133] ([i915#2546]) +1 similar issue
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-glk2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][134] ([fdo#109280] / [fdo#111825]) +8 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-apl: NOTRUN -> [SKIP][135] ([fdo#109271]) +21 similar issues
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-apl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite.html

* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][136] -> [FAIL][137] ([i915#1188])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-skl1/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl8/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-glk: NOTRUN -> [SKIP][138] ([fdo#109271] / [i915#533])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-glk5/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][139] -> [FAIL][140] ([fdo#108145] / [i915#265])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-skl4/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][141] ([fdo#108145] / [i915#265])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-kbl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][142] ([fdo#108145] / [i915#265])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-apl1/igt@[email protected]

* igt@kms_plane_lowres@pipe-b-tiling-none:
- shard-tglb: NOTRUN -> [SKIP][143] ([i915#3536])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@kms_plane_lowres@pipe-c-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][144] ([fdo#111615] / [fdo#112054])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-tglb: NOTRUN -> [SKIP][145] ([i915#2920])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@kms_psr2_su@page_flip-p010:
- shard-skl: NOTRUN -> [SKIP][146] ([fdo#109271] / [i915#658])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl6/igt@kms_psr2_su@page_flip-p010.html

* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][147] -> [SKIP][148] ([fdo#109441]) +1 similar issue
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-iclb8/igt@kms_psr@psr2_cursor_blt.html

* igt@kms_psr@psr2_primary_render:
- shard-tglb: NOTRUN -> [FAIL][149] ([i915#132] / [i915#3467])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@kms_psr@psr2_primary_render.html

* igt@kms_setmode@basic:
- shard-apl: [PASS][150] -> [FAIL][151] ([i915#31])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-apl3/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-apl1/igt@[email protected]

* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> [FAIL][152] ([IGT#2])
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-apl1/igt@kms_sysfs_edid_timing.html
- shard-skl: NOTRUN -> [FAIL][153] ([IGT#2])
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl6/igt@kms_sysfs_edid_timing.html

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][154] -> [DMESG-WARN][155] ([i915#180] / [i915#295])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-kbl7/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-kbl4/igt@[email protected]

* igt@nouveau_crc@pipe-a-source-outp-complete:
- shard-tglb: NOTRUN -> [SKIP][156] ([i915#2530])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-tglb: NOTRUN -> [SKIP][157] ([fdo#109289])
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@[email protected]

* igt@perf@polling-parameterized:
- shard-skl: [PASS][158] -> [FAIL][159] ([i915#1542])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11066/shard-skl10/igt@[email protected]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl10/igt@[email protected]

* igt@prime_nv_api@i915_self_import:
- shard-skl: NOTRUN -> [SKIP][160] ([fdo#109271]) +63 similar issues
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-skl2/igt@prime_nv_api@i915_self_import.html

* igt@prime_nv_test@i915_nv_sharing:
- shard-tglb: NOTRUN -> [SKIP][161] ([fdo#109291]) +2 similar issues
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/shard-tglb1/igt@prime_nv_test@i915_nv_sharing.html

* igt@sysfs_clients@fair-0:
- shard-kbl:

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21969/index.html

#6 lore raw
In reply to Stanislav Lisovskiy
Quoted 5 lines · Stanislav Lisovskiy

Currently we only recalculate CDCLK if active plane mask changes or if we do a full modeset, however according to BSpec required Dbuf bandwidth calculations also depend on pipe/plane scaling ratio, which means that CDCLK must be recalculated everytime plane scaling ratio changes,

Already handled by the plane min_cdclk stuff.

Quoted 2 lines

because it affects
display buffer bandwidth requirements.

Yes, the dbuf bw code is borked. I have old patches on the list that started to fix up all the data rate related stuff, but IIRC I didn't finish it because I ran out of time at the time. I think I have a branch that has a bit more but I'll need to check how far along I actually got in fixing it all...

Quoted 120 lines
---
 drivers/gpu/drm/i915/display/intel_display.c | 63 +++++++++++++++++++-
 1 file changed, 60 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +60 -3
index bf7ce684dd8e..2c616348e993 100644
@@ -7499,13 +7499,65 @@ static int intel_bigjoiner_add_affected_planes(struct intel_atomic_state *state)
 	return 0;
 }
 
+static bool scaling_affects_cdclk(struct intel_plane_state *old_plane_state,
+				  struct intel_plane_state *new_plane_state)
+{
+	int old_src_w = drm_rect_width(&old_plane_state->uapi.src) >> 16;
+	int old_src_h = drm_rect_height(&old_plane_state->uapi.src) >> 16;
+	int old_dst_w = drm_rect_width(&old_plane_state->uapi.dst);
+	int old_dst_h = drm_rect_height(&old_plane_state->uapi.dst);
+	int new_src_w = drm_rect_width(&new_plane_state->uapi.src) >> 16;
+	int new_src_h = drm_rect_height(&new_plane_state->uapi.src) >> 16;
+	int new_dst_w = drm_rect_width(&new_plane_state->uapi.dst);
+	int new_dst_h = drm_rect_height(&new_plane_state->uapi.dst);
+	int old_hscale_ratio, new_hscale_ratio;
+	int old_vscale_ratio, new_vscale_ratio;
+
+	if (needs_scaling(old_plane_state) != needs_scaling(new_plane_state))
+		return true;
+
+	if (!old_dst_w || !old_dst_h)
+		return true;
+
+	DRM_DEBUG_KMS("old_dst_w %d old_dst_h %d\n", old_dst_w, old_dst_h);
+
+	old_hscale_ratio = DIV_ROUND_UP(old_src_w, old_dst_w);
+	old_vscale_ratio = DIV_ROUND_UP(old_src_h, old_dst_h);
+
+	if (!new_dst_w || !new_dst_h)
+		return true;
+
+	DRM_DEBUG_KMS("new_dst_w %d new_dst_h %d\n", new_dst_w, new_dst_h);
+
+	new_hscale_ratio = DIV_ROUND_UP(new_src_w, new_dst_w);
+	new_vscale_ratio = DIV_ROUND_UP(new_src_h, new_dst_h);
+
+	DRM_DEBUG_KMS("new_hscale_ratio %d new_vscale_ratio %d "
+		      "old_hscale_ratio %d old_vscale_ratio %d\n",
+		      new_hscale_ratio, new_vscale_ratio,
+		      old_hscale_ratio, old_vscale_ratio);
+
+	if ((old_hscale_ratio != new_hscale_ratio) ||
+	    (old_vscale_ratio != new_vscale_ratio)) {
+		DRM_DEBUG_KMS("Scaling ratios changed from %dx%d"
+			      " to %dx%d - need cdclk recalc\n",
+			      old_hscale_ratio, old_vscale_ratio,
+			      new_hscale_ratio, new_vscale_ratio);
+		return true;
+	}
+
+	return false;
+}
+
 static int intel_atomic_check_planes(struct intel_atomic_state *state)
 {
 	struct drm_i915_private *dev_priv = to_i915(state->base.dev);
 	struct intel_crtc_state *old_crtc_state, *new_crtc_state;
 	struct intel_plane_state *plane_state;
+	struct intel_plane_state *old_plane_state;
 	struct intel_plane *plane;
 	struct intel_crtc *crtc;
+	bool need_cdclk_calc = false;
 	int i, ret;
 
 	ret = icl_add_linked_planes(state);
@@ -7516,7 +7568,7 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 	if (ret)
 		return ret;
 
-	for_each_new_intel_plane_in_state(state, plane, plane_state, i) {
+	for_each_oldnew_intel_plane_in_state(state, plane, old_plane_state, plane_state, i) {
 		ret = intel_plane_atomic_check(state, plane);
 		if (ret) {
 			drm_dbg_atomic(&dev_priv->drm,
@@ -7524,6 +7576,9 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 				       plane->base.base.id, plane->base.name);
 			return ret;
 		}
+
+		if (scaling_affects_cdclk(old_plane_state, plane_state))
+			need_cdclk_calc = true;
 	}
 
 	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
@@ -7539,18 +7594,20 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 		 * the planes' minimum cdclk calculation. Add such planes
 		 * to the state before we compute the minimum cdclk.
 		 */
-		if (!active_planes_affects_min_cdclk(dev_priv))
+		if (!active_planes_affects_min_cdclk(dev_priv) && !need_cdclk_calc)
 			continue;
 
 		old_active_planes = old_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
 		new_active_planes = new_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
 
-		if (hweight8(old_active_planes) == hweight8(new_active_planes))
+		if ((hweight8(old_active_planes) == hweight8(new_active_planes)) && !need_cdclk_calc)
 			continue;
 
 		ret = intel_crtc_add_planes_to_state(state, crtc, new_active_planes);
 		if (ret)
 			return ret;
+
+
 	}
 
 	return 0;
Signature · 1 line
2.24.1.485.gad05a3d8e5
Signature · 2 lines
Ville Syrjälä
Intel
#7 lore raw
Quoted 8 lines · Ville Syrjälä
Quoted 5 lines · Stanislav Lisovskiy

Currently we only recalculate CDCLK if active plane mask changes or if we do a full modeset, however according to BSpec required Dbuf bandwidth calculations also depend on pipe/plane scaling ratio, which means that CDCLK must be recalculated everytime plane scaling ratio changes,

Already handled by the plane min_cdclk stuff.

Problem is that plane min_cdclk will only be called for those which are added to the state.
In intel_atomic_check_planes we call intel_crtc_add_planes_to_state only if active_planes_affects_min_cdclk is true and active_planes mask got changed.
However if we got one of planes scaling ratio changed, we need to recalculate CDCLK once again and make sure we have all the active planes in state for that. Don't we need all active planes in state to calculate it properly?

Quoted 9 lines
Quoted 3 lines

because it affects
display buffer bandwidth requirements.

Yes, the dbuf bw code is borked. I have old patches on the list that started to fix up all the data rate related stuff, but IIRC I didn't finish it because I ran out of time at the time. I think I have a branch that has a bit more but I'll need to check how far along I actually got in fixing it all...

Yeah, it kind of tries to take into account that multiple BSpec requirements into account, however as I remember at the moment when this was committed we were still not even sure, we interpret BSpec properly here. By the way we are still missing cumulative bpp W/A here in upstream.

Stan

Quoted 125 lines
Quoted 121 lines
---
 drivers/gpu/drm/i915/display/intel_display.c | 63 +++++++++++++++++++-
 1 file changed, 60 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +60 -3
index bf7ce684dd8e..2c616348e993 100644
@@ -7499,13 +7499,65 @@ static int intel_bigjoiner_add_affected_planes(struct intel_atomic_state *state)
 	return 0;
 }
 
+static bool scaling_affects_cdclk(struct intel_plane_state *old_plane_state,
+				  struct intel_plane_state *new_plane_state)
+{
+	int old_src_w = drm_rect_width(&old_plane_state->uapi.src) >> 16;
+	int old_src_h = drm_rect_height(&old_plane_state->uapi.src) >> 16;
+	int old_dst_w = drm_rect_width(&old_plane_state->uapi.dst);
+	int old_dst_h = drm_rect_height(&old_plane_state->uapi.dst);
+	int new_src_w = drm_rect_width(&new_plane_state->uapi.src) >> 16;
+	int new_src_h = drm_rect_height(&new_plane_state->uapi.src) >> 16;
+	int new_dst_w = drm_rect_width(&new_plane_state->uapi.dst);
+	int new_dst_h = drm_rect_height(&new_plane_state->uapi.dst);
+	int old_hscale_ratio, new_hscale_ratio;
+	int old_vscale_ratio, new_vscale_ratio;
+
+	if (needs_scaling(old_plane_state) != needs_scaling(new_plane_state))
+		return true;
+
+	if (!old_dst_w || !old_dst_h)
+		return true;
+
+	DRM_DEBUG_KMS("old_dst_w %d old_dst_h %d\n", old_dst_w, old_dst_h);
+
+	old_hscale_ratio = DIV_ROUND_UP(old_src_w, old_dst_w);
+	old_vscale_ratio = DIV_ROUND_UP(old_src_h, old_dst_h);
+
+	if (!new_dst_w || !new_dst_h)
+		return true;
+
+	DRM_DEBUG_KMS("new_dst_w %d new_dst_h %d\n", new_dst_w, new_dst_h);
+
+	new_hscale_ratio = DIV_ROUND_UP(new_src_w, new_dst_w);
+	new_vscale_ratio = DIV_ROUND_UP(new_src_h, new_dst_h);
+
+	DRM_DEBUG_KMS("new_hscale_ratio %d new_vscale_ratio %d "
+		      "old_hscale_ratio %d old_vscale_ratio %d\n",
+		      new_hscale_ratio, new_vscale_ratio,
+		      old_hscale_ratio, old_vscale_ratio);
+
+	if ((old_hscale_ratio != new_hscale_ratio) ||
+	    (old_vscale_ratio != new_vscale_ratio)) {
+		DRM_DEBUG_KMS("Scaling ratios changed from %dx%d"
+			      " to %dx%d - need cdclk recalc\n",
+			      old_hscale_ratio, old_vscale_ratio,
+			      new_hscale_ratio, new_vscale_ratio);
+		return true;
+	}
+
+	return false;
+}
+
 static int intel_atomic_check_planes(struct intel_atomic_state *state)
 {
 	struct drm_i915_private *dev_priv = to_i915(state->base.dev);
 	struct intel_crtc_state *old_crtc_state, *new_crtc_state;
 	struct intel_plane_state *plane_state;
+	struct intel_plane_state *old_plane_state;
 	struct intel_plane *plane;
 	struct intel_crtc *crtc;
+	bool need_cdclk_calc = false;
 	int i, ret;
 
 	ret = icl_add_linked_planes(state);
@@ -7516,7 +7568,7 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 	if (ret)
 		return ret;
 
-	for_each_new_intel_plane_in_state(state, plane, plane_state, i) {
+	for_each_oldnew_intel_plane_in_state(state, plane, old_plane_state, plane_state, i) {
 		ret = intel_plane_atomic_check(state, plane);
 		if (ret) {
 			drm_dbg_atomic(&dev_priv->drm,
@@ -7524,6 +7576,9 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 				       plane->base.base.id, plane->base.name);
 			return ret;
 		}
+
+		if (scaling_affects_cdclk(old_plane_state, plane_state))
+			need_cdclk_calc = true;
 	}
 
 	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
@@ -7539,18 +7594,20 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
 		 * the planes' minimum cdclk calculation. Add such planes
 		 * to the state before we compute the minimum cdclk.
 		 */
-		if (!active_planes_affects_min_cdclk(dev_priv))
+		if (!active_planes_affects_min_cdclk(dev_priv) && !need_cdclk_calc)
 			continue;
 
 		old_active_planes = old_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
 		new_active_planes = new_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
 
-		if (hweight8(old_active_planes) == hweight8(new_active_planes))
+		if ((hweight8(old_active_planes) == hweight8(new_active_planes)) && !need_cdclk_calc)
 			continue;
 
 		ret = intel_crtc_add_planes_to_state(state, crtc, new_active_planes);
 		if (ret)
 			return ret;
+
+
 	}
 
 	return 0;
Signature · 1 line
2.24.1.485.gad05a3d8e5
Signature · 2 lines
Ville Syrjälä
Intel
#8 lore raw
Quoted 10 lines · Stanislav
Quoted 8 lines · Ville Syrjälä
Quoted 5 lines · Stanislav Lisovskiy

Currently we only recalculate CDCLK if active plane mask changes or if we do a full modeset, however according to BSpec required Dbuf bandwidth calculations also depend on pipe/plane scaling ratio, which means that CDCLK must be recalculated everytime plane scaling ratio changes,

Already handled by the plane min_cdclk stuff.

Quoted 9 lines

Problem is that plane min_cdclk will only be called for those which are added to the state.
In intel_atomic_check_planes we call intel_crtc_add_planes_to_state only if active_planes_affects_min_cdclk is true and active_planes mask got changed.
However if we got one of planes scaling ratio changed, we need to recalculate CDCLK once again and make sure we have all the active planes in state for that. Don't we need all active planes in state to calculate it properly?

If the plane's scaling ratio is changing then that plane is already in the state. The min_cdclk/data_rate/etc. are all then cached in the crtc state so that plane isn't needed again until its scaling ratio (or whatever else) changes again.

Signature · 2 lines
Ville Syrjälä
Intel
#9 lore raw
Quoted 21 lines · Ville Syrjälä
Quoted 10 lines · Stanislav
Quoted 8 lines · Ville Syrjälä
Quoted 5 lines · Stanislav Lisovskiy

Currently we only recalculate CDCLK if active plane mask changes or if we do a full modeset, however according to BSpec required Dbuf bandwidth calculations also depend on pipe/plane scaling ratio, which means that CDCLK must be recalculated everytime plane scaling ratio changes,

Already handled by the plane min_cdclk stuff.

Quoted 9 lines

Problem is that plane min_cdclk will only be called for those which are added to the state.
In intel_atomic_check_planes we call intel_crtc_add_planes_to_state only if active_planes_affects_min_cdclk is true and active_planes mask got changed.
However if we got one of planes scaling ratio changed, we need to recalculate CDCLK once again and make sure we have all the active planes in state for that. Don't we need all active planes in state to calculate it properly?

Quoted 4 lines

If the plane's scaling ratio is changing then that plane is already in the state. The min_cdclk/data_rate/etc. are all then cached in the crtc state so that plane isn't needed again until its scaling ratio (or whatever else) changes again.

Yep, was just wondering that according to this logic why we do call intel_crtc_add_planes_to_state, once active plane mask changes then.

Stan

Quoted 4 lines
Signature · 3 lines
-- 
Ville Syrjälä
Intel