firmware_loader: simplfy builtin or module check
Subsystems (2)
Luis Chamberlain
maintainerPATCH v2 1/1 firmware_loader: simplfy builtin or module check
The existing check is outdated and confuses developers. Use the already existing IS_REACHABLE() defined on kconfig.h which makes the intention much clearer.
--- include/linux/firmware.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/firmware.h +1 -1
@@ -34,7 +34,7 @@ static inline bool firmware_request_builtin(struct firmware *fw, }#endif -#if defined(CONFIG_FW_LOADER ) || (defined(CONFIG_FW_LOADER_MODULE ) && defined(MODULE )) +#if IS_REACHABLE (CONFIG_FW_LOADER )int request_firmware (const struct firmware **fw,const char *name,struct device *device); int firmware_request_nowarn(const struct firmware **fw, const char *name,
Signature · 1 line
2.34.1
Quoted 3 lines · Luis Chamberlain
The existing check is outdated and confuses developers. Use the already existing
IS_REACHABLE()defined onkconfig.hwhich makes the intention much clearer.
Yes.
Quoted 6 lines
Reported-by Borislav Petkov <[email protected]>Reported-by Greg Kroah-Hartman <[email protected]>Suggested-by Masahiro Yamada <[email protected]>Cc Randy Dunlap <[email protected]>Cc Masahiro Yamada <[email protected]>Signed-off-by Luis Chamberlain <[email protected]>
Thanks.
Quoted 17 lines
--- include/linux/firmware.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/firmware.h +1
-1@@ -34,7 +34,7 @@ static inline bool firmware_request_builtin(struct firmware *fw, }#endif -#if defined(CONFIG_FW_LOADER ) || (defined(CONFIG_FW_LOADER_MODULE ) && defined(MODULE )) +#if IS_REACHABLE (CONFIG_FW_LOADER )int request_firmware (const struct firmware **fw,const char *name,struct device *device); int firmware_request_nowarn(const struct firmware **fw, const char *name,
Signature · 1 line
~Randy
Quoted 30 lines · Luis Chamberlain
The existing check is outdated and confuses developers. Use the already existing
IS_REACHABLE()defined onkconfig.hwhich makes the intention much clearer.Reported-by Borislav Petkov <[email protected]>Reported-by Greg Kroah-Hartman <[email protected]>Suggested-by Masahiro Yamada <[email protected]>Cc Randy Dunlap <[email protected]>Cc Masahiro Yamada <[email protected]>Signed-off-by Luis Chamberlain <[email protected]>--- include/linux/firmware.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/firmware.h +1
-1@@ -34,7 +34,7 @@ static inline bool firmware_request_builtin(struct firmware *fw, }#endif -#if defined(CONFIG_FW_LOADER ) || (defined(CONFIG_FW_LOADER_MODULE ) && defined(MODULE )) +#if IS_REACHABLE (CONFIG_FW_LOADER )int request_firmware (const struct firmware **fw,const char *name,struct device *device); int firmware_request_nowarn(const struct firmware **fw, const char *name,Signature · 1 line
2.34.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot