Skip to contentSkip to conversation

aoe: remove redundant assignment on variable n

PATCH Applied Colin Ian King 2 participants 2 messages Jan 13, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 aoe: remove redundant assignment on variable n

The variable n is being bit-wise or'd with a value and reassigned before being returned. The update of n is redundant, replace the |= operator with | instead. Cleans up clang scan warning:

drivers/block/aoe/aoecmd.c:125:9: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n' [deadcode.DeadStores]

---
 drivers/block/aoe/aoecmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/aoe/aoecmd.c +1 -1
index 588889bea7c3..6af111f568e4 100644
@@ -122,7 +122,7 @@ newtag(struct aoedev *d)
 	register ulong n;
 
 	n = jiffies & 0xffff;
-	return n |= (++d->lasttag & 0x7fff) << 16;
+	return n | (++d->lasttag & 0x7fff) << 16;
 }
 
 static u32
Signature · 1 line
2.33.1
maintainer Applied
#1 lore raw
Quoted 9 lines · Colin Ian King

The variable n is being bit-wise or'd with a value and reassigned before being returned. The update of n is redundant, replace the |= operator with | instead. Cleans up clang scan warning:

drivers/block/aoe/aoecmd.c:125:9: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n' [deadcode.DeadStores]

[...]

Applied, thanks!

[1/1] aoe: remove redundant assignment on variable n

      commit: a6431e351c6ec5bb6800787d259b343088f369a3

Best regards,

Signature · 1 line
Jens Axboe