kernel-shark: Use cmake imported targets instead of variables
PATCH v2 1/1 kernel-shark: Use cmake imported targets instead of variables
Using cmake imported targets instead of package variables is recommended way to define package dependencies.
The GLUT_LIBRARY cmake variable was renamed in cmake 3.22.1, which breaks the Kernel Shark build with the latest cmake.
Reported-by Michal Sojka <[email protected]>
Signed-off-by Tzvetomir Stoyanov (VMware) <[email protected]>
--- src/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
src/CMakeLists.txt +2 -2
@@ -59,8 +59,8 @@ if (OPENGL_FOUND) KsPlugins.cpp) target_link_libraries(kshark-plot kshark - ${GLUT_LIBRARY} - ${OPENGL_LIBRARIES}) + GLUT::GLUT + OpenGL::GLU) set_target_properties(kshark-plot PROPERTIES SUFFIX ".so.${KS_VERSION_STRING}") install(TARGETS kshark-plot
Signature · 1 line
2.34.1
Hi Tzvetomir and Yordan,
I'm not sure my sign-off is necessary, but if Yordan wants it, you have it :-)
Cheers,
-Michal
Quoted 8 lines · Tzvetomir Stoyanov (VMware)
Using cmake imported targets instead of package variables is recommended way to define package dependencies.
The
GLUT_LIBRARYcmake variable was renamed in cmake 3.22.1, which breaks the Kernel Shark build with the latest cmake.Reported-by Michal Sojka <[email protected]>Signed-off-by Tzvetomir Stoyanov (VMware) <[email protected]>
Signed-off-by Michal Sojka <[email protected]>
Quoted 21 lines
--- src/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)src/CMakeLists.txt +2
-2@@ -59,8 +59,8 @@ if (OPENGL_FOUND) KsPlugins.cpp) target_link_libraries(kshark-plot kshark - ${GLUT_LIBRARY} - ${OPENGL_LIBRARIES}) + GLUT::GLUT + OpenGL::GLU) set_target_properties(kshark-plot PROPERTIES SUFFIX ".so.${KS_VERSION_STRING}") install(TARGETS kshark-plotSignature · 1 line
2.34.1