net/mlx5: fix wrong MPRQ WQE size assertion
PATCH 1/1 net/mlx5: fix wrong MPRQ WQE size assertion
Preparation of the stride size and the number of strides for Multi-Packet RQ was updated recently to accommodate the hardware limitation about minimum WQE size. The wrong assertion was introduced to ensure this limitation is met. Assert that the configured WQE size is not less than the minimum supported size.
--- drivers/net/mlx5/mlx5_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/mlx5_rxq.c +1 -1
@@ -1619,7 +1619,7 @@ mlx5_mprq_prepare(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc, RTE_BIT32(log_def_stride_size)); log_stride_wqe_size = log_def_stride_num + log_def_stride_size; } -MLX5_ASSERT (log_stride_wqe_size < config->mprq.log_min_stride_wqe_size); +MLX5_ASSERT (log_stride_wqe_size >= config->mprq.log_min_stride_wqe_size);if (desc <=RTE_BIT32 (*actual_log_stride_num)) goto unsupport;if (min_mbuf_size >RTE_BIT32 (log_stride_wqe_size)) {
Signature · 1 line
2.18.2
Hi,
Quoted 15 lines
-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Thursday, January 13, 2022 4:36 PM
To: [email protected]
Cc: Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>; Matan Azrad <[email protected]>; Michael Baum <[email protected]>
Subject: [PATCH] net/mlx5: fix wrong MPRQ WQE size assertionPreparation of the stride size and the number of strides for Multi-Packet RQ was updated recently to accommodate the hardware limitation about minimum WQE size. The wrong assertion was introduced to ensure this limitation is met. Assert that the configured WQE size is not less than the minimum supported size.
Quoted 4 lines
Fixes 219f08a ("net/mlx5: fix missing adjustment MPRQ stride devargs")Signed-off-by Alexander Kozyrev <[email protected]>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh