Skip to contentSkip to conversation

ACPI: PCC: make pcc_ctx static

PATCH In review Jiapeng Chong 2 participants 2 messages Jan 13, 2022 – Jan 14, 2022 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: PCC: make pcc_ctx static

This symbol is not used outside of acpi_pcc.c, so marks it static.

Fix the following sparse warning:

drivers/acpi/acpi_pcc.c:34:22: warning: symbol 'pcc_ctx' was not declared. Should it be static?

---
 drivers/acpi/acpi_pcc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/acpi_pcc.c +1 -1
index 41e3ebd204ff..a12b55d81209 100644
@@ -31,7 +31,7 @@ struct pcc_data {
 	struct acpi_pcc_info ctx;
 };
 
-struct acpi_pcc_info pcc_ctx;
+static struct acpi_pcc_info pcc_ctx;
 
 static void pcc_rx_callback(struct mbox_client *cl, void *m)
 {
Signature · 1 line
2.20.1.7.g153144c
#1 lore raw
Quoted 8 lines · Jiapeng Chong

This symbol is not used outside of acpi_pcc.c, so marks it static.

Fix the following sparse warning:

drivers/acpi/acpi_pcc.c:34:22: warning: symbol 'pcc_ctx' was not declared. Should it be static?

The fix is now already applied [1]

Signature · 4 lines
Regards,
Sudeep

[1] https://lore.kernel.org/lkml/CAJZ5v0iG0-O1m2hS62yXMNW4p1JhWhxXZCDQc=mxKc50mU7GZw@mail.gmail.com