Skip to contentSkip to conversation

Remove some hacks required for GuC 62.0.0

PATCH In review Matthew Brost 3 participants 11 messages Jan 11, 2022 – Jan 13, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Remove some hacks required for GuC 62.0.0

Remove a hack required because schedule disable done G2H was received before context reset G2H in GuC firmware 62.0.0. Since we have upgraded 69.0.3, this is no longer required.

Also revive selftest which proves this works before / after change.

Matthew Brost (2):
drm/i915/selftests: Add a cancel request selftest that triggers a
reset
drm/i915/guc: Remove hacks for reset and schedule disable G2H being
received out of order

 .../gpu/drm/i915/gt/uc/intel_guc_submission.c |  30 +----
 drivers/gpu/drm/i915/selftests/i915_request.c | 117 ++++++++++++++++++
 2 files changed, 119 insertions(+), 28 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/2 drm/i915/selftests: Add a cancel request selftest that triggers a reset

Add a cancel request selftest that results in an engine reset to cancel the request as it is non-preemptable. Also insert a NOP request after the cancelled request and confirm that it completes successfully.

v2:
(Tvrtko)
- Skip test if preemption timeout compiled out
- Skip test if engine reset isn't supported
- Update debug prints to be more descriptive
v3:
- Add comment explaining test

---
 drivers/gpu/drm/i915/selftests/i915_request.c | 117 ++++++++++++++++++
 1 file changed, 117 insertions(+)
drivers/gpu/drm/i915/selftests/i915_request.c +117 -0
index 7f66f6d299b26..f78de99d5ae1e 100644
@@ -782,6 +782,115 @@ static int __cancel_completed(struct intel_engine_cs *engine)
 	return err;
 }
 
+/*
+ * Test to prove a non-preemptable request can be cancelled and a subsequent
+ * request on the same context can successfully complete after cancallation.
+ *
+ * Testing methodology is to create non-preemptable request and submit it,
+ * wait for spinner to start, create a NOP request and submit it, cancel the
+ * spinner, wait for spinner to complete and verify it failed with an error,
+ * finally wait for NOP request to complete verify it succeeded without an
+ * error. Preemption timeout also reduced / restored so test runs in a timely
+ * maner.
+ */
+static int __cancel_reset(struct drm_i915_private *i915,
+			  struct intel_engine_cs *engine)
+{
+	struct intel_context *ce;
+	struct igt_spinner spin;
+	struct i915_request *rq, *nop;
+	unsigned long preempt_timeout_ms;
+	int err = 0;
+
+	if (!CONFIG_DRM_I915_PREEMPT_TIMEOUT ||
+	    !intel_has_reset_engine(engine->gt))
+		return 0;
+
+	preempt_timeout_ms = engine->props.preempt_timeout_ms;
+	engine->props.preempt_timeout_ms = 100;
+
+	if (igt_spinner_init(&spin, engine->gt))
+		goto out_restore;
+
+	ce = intel_context_create(engine);
+	if (IS_ERR(ce)) {
+		err = PTR_ERR(ce);
+		goto out_spin;
+	}
+
+	rq = igt_spinner_create_request(&spin, ce, MI_NOOP);
+	if (IS_ERR(rq)) {
+		err = PTR_ERR(rq);
+		goto out_ce;
+	}
+
+	pr_debug("%s: Cancelling active non-preemptable request\n",
+		 engine->name);
+	i915_request_get(rq);
+	i915_request_add(rq);
+	if (!igt_wait_for_spinner(&spin, rq)) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
+
+		pr_err("Failed to start spinner on %s\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
+		err = -ETIME;
+		goto out_rq;
+	}
+
+	nop = intel_context_create_request(ce);
+	if (IS_ERR(nop))
+		goto out_nop;
+	i915_request_get(nop);
+	i915_request_add(nop);
+
+	i915_request_cancel(rq, -EINTR);
+
+	if (i915_request_wait(rq, 0, HZ) < 0) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
+
+		pr_err("%s: Failed to cancel hung request\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
+		err = -ETIME;
+		goto out_nop;
+	}
+
+	if (rq->fence.error != -EINTR) {
+		pr_err("%s: fence not cancelled (%u)\n",
+		       engine->name, rq->fence.error);
+		err = -EINVAL;
+		goto out_nop;
+	}
+
+	if (i915_request_wait(nop, 0, HZ) < 0) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
+
+		pr_err("%s: Failed to complete nop request\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
+		err = -ETIME;
+		goto out_nop;
+	}
+
+	if (nop->fence.error != 0) {
+		pr_err("%s: Nop request errored (%u)\n",
+		       engine->name, nop->fence.error);
+		err = -EINVAL;
+	}
+
+out_nop:
+	i915_request_put(nop);
+out_rq:
+	i915_request_put(rq);
+out_ce:
+	intel_context_put(ce);
+out_spin:
+	igt_spinner_fini(&spin);
+out_restore:
+	engine->props.preempt_timeout_ms = preempt_timeout_ms;
+	if (err)
+		pr_err("%s: %s error %d\n", __func__, engine->name, err);
+	return err;
+}
+
 static int live_cancel_request(void *arg)
 {
 	struct drm_i915_private *i915 = arg;
@@ -814,6 +923,14 @@ static int live_cancel_request(void *arg)
 			return err;
 		if (err2)
 			return err2;
+
+		/* Expects reset so call outside of igt_live_test_* */
+		err = __cancel_reset(i915, engine);
+		if (err)
+			return err;
+
+		if (igt_flush_test(i915))
+			return -EIO;
 	}
 
 	return 0;
Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH 1/2] drm/i915/selftests: Add a cancel request selftest that triggers a reset

Quoted 22 lines · Matthew Brost

Add a cancel request selftest that results in an engine reset to cancel the request as it is non-preemptable. Also insert a NOP request after the cancelled request and confirm that it completes successfully.

v2:
(Tvrtko)
- Skip test if preemption timeout compiled out
- Skip test if engine reset isn't supported
- Update debug prints to be more descriptive
v3:
- Add comment explaining test

---
  drivers/gpu/drm/i915/selftests/i915_request.c | 117 ++++++++++++++++++
  1 file changed, 117 insertions(+)
drivers/gpu/drm/i915/selftests/i915_request.c +0 -0
index 7f66f6d299b26..f78de99d5ae1e 100644

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 787

Quoted 6 lines
drivers/gpu/drm/i915/selftests/i915_request.c +3 -0
@@ -782,6 +782,115 @@ static int __cancel_completed(struct intel_engine_cs *engine)
  	return err;
  }
 
+/*
+ * Test to prove a non-preemptable request can be cancelled and a subsequent
+ * request on the same context can successfully complete after cancallation.

cancellation

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 789

Quoted 2 lines
drivers/gpu/drm/i915/selftests/i915_request.c +2 -0
+ *
+ * Testing methodology is to create non-preemptable request and submit it,

a non-preemptible

Quoted 6 lines
drivers/gpu/drm/i915/selftests/i915_request.c +6 -0
+ * wait for spinner to start, create a NOP request and submit it, cancel the
+ * spinner, wait for spinner to complete and verify it failed with an error,
+ * finally wait for NOP request to complete verify it succeeded without an
+ * error. Preemption timeout also reduced / restored so test runs in a timely
+ * maner.
+ */

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 805

Quoted 10 lines
drivers/gpu/drm/i915/selftests/i915_request.c +10 -0
+static int __cancel_reset(struct drm_i915_private *i915,
+			  struct intel_engine_cs *engine)
+{
+	struct intel_context *ce;
+	struct igt_spinner spin;
+	struct i915_request *rq, *nop;
+	unsigned long preempt_timeout_ms;
+	int err = 0;
+
+	if (!CONFIG_DRM_I915_PREEMPT_TIMEOUT ||

Does this matter? The test is overriding the default anyway.

Quoted 27 lines
drivers/gpu/drm/i915/selftests/i915_request.c +27 -0
+	    !intel_has_reset_engine(engine->gt))
+		return 0;
+
+	preempt_timeout_ms = engine->props.preempt_timeout_ms;
+	engine->props.preempt_timeout_ms = 100;
+
+	if (igt_spinner_init(&spin, engine->gt))
+		goto out_restore;
+
+	ce = intel_context_create(engine);
+	if (IS_ERR(ce)) {
+		err = PTR_ERR(ce);
+		goto out_spin;
+	}
+
+	rq = igt_spinner_create_request(&spin, ce, MI_NOOP);
+	if (IS_ERR(rq)) {
+		err = PTR_ERR(rq);
+		goto out_ce;
+	}
+
+	pr_debug("%s: Cancelling active non-preemptable request\n",
+		 engine->name);
+	i915_request_get(rq);
+	i915_request_add(rq);
+	if (!igt_wait_for_spinner(&spin, rq)) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 842

Quoted 10 lines
drivers/gpu/drm/i915/selftests/i915_request.c +10 -0
+
+		pr_err("Failed to start spinner on %s\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
+		err = -ETIME;
+		goto out_rq;
+	}
+
+	nop = intel_context_create_request(ce);
+	if (IS_ERR(nop))
+		goto out_nop;

Should be out_rq?

John.

Quoted 69 lines
drivers/gpu/drm/i915/selftests/i915_request.c +59 -0
+	i915_request_get(nop);
+	i915_request_add(nop);
+
+	i915_request_cancel(rq, -EINTR);
+
+	if (i915_request_wait(rq, 0, HZ) < 0) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
+
+		pr_err("%s: Failed to cancel hung request\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
+		err = -ETIME;
+		goto out_nop;
+	}
+
+	if (rq->fence.error != -EINTR) {
+		pr_err("%s: fence not cancelled (%u)\n",
+		       engine->name, rq->fence.error);
+		err = -EINVAL;
+		goto out_nop;
+	}
+
+	if (i915_request_wait(nop, 0, HZ) < 0) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
+
+		pr_err("%s: Failed to complete nop request\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
+		err = -ETIME;
+		goto out_nop;
+	}
+
+	if (nop->fence.error != 0) {
+		pr_err("%s: Nop request errored (%u)\n",
+		       engine->name, nop->fence.error);
+		err = -EINVAL;
+	}
+
+out_nop:
+	i915_request_put(nop);
+out_rq:
+	i915_request_put(rq);
+out_ce:
+	intel_context_put(ce);
+out_spin:
+	igt_spinner_fini(&spin);
+out_restore:
+	engine->props.preempt_timeout_ms = preempt_timeout_ms;
+	if (err)
+		pr_err("%s: %s error %d\n", __func__, engine->name, err);
+	return err;
+}
+
  static int live_cancel_request(void *arg)
  {
  	struct drm_i915_private *i915 = arg;
@@ -814,6 +923,14 @@ static int live_cancel_request(void *arg)
  			return err;
  		if (err2)
  			return err2;
+
+		/* Expects reset so call outside of igt_live_test_* */
+		err = __cancel_reset(i915, engine);
+		if (err)
+			return err;
+
+		if (igt_flush_test(i915))
+			return -EIO;
  	}
 
  	return 0;
#3 lore raw

Re: [PATCH 1/2] drm/i915/selftests: Add a cancel request selftest that triggers a reset

Quoted 18 lines · John Harrison
Quoted 17 lines · Matthew Brost

Add a cancel request selftest that results in an engine reset to cancel the request as it is non-preemptable. Also insert a NOP request after the cancelled request and confirm that it completes successfully.

v2:
(Tvrtko)
- Skip test if preemption timeout compiled out
- Skip test if engine reset isn't supported
- Update debug prints to be more descriptive
v3:
- Add comment explaining test

---
  drivers/gpu/drm/i915/selftests/i915_request.c | 117 ++++++++++++++++++
  1 file changed, 117 insertions(+)
Quoted 12 lines

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 786

Quoted 10 lines
drivers/gpu/drm/i915/selftests/i915_request.c +3 -0
index 7f66f6d299b26..f78de99d5ae1e 100644
@@ -782,6 +782,115 @@ static int __cancel_completed(struct intel_engine_cs *engine)
  	return err;
  }
+/*
+ * Test to prove a non-preemptable request can be cancelled and a subsequent
+ * request on the same context can successfully complete after cancallation.

cancellation

Yep.

Quoted 4 lines

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 789

Quoted 2 lines
drivers/gpu/drm/i915/selftests/i915_request.c +2 -0
+ *
+ * Testing methodology is to create non-preemptable request and submit it,

a non-preemptible

Yep.

Quoted 9 lines
Quoted 9 lines
drivers/gpu/drm/i915/selftests/i915_request.c +9 -0
+ * wait for spinner to start, create a NOP request and submit it, cancel the
+ * spinner, wait for spinner to complete and verify it failed with an error,
+ * finally wait for NOP request to complete verify it succeeded without an
+ * error. Preemption timeout also reduced / restored so test runs in a timely
+ * maner.
+ */
+static int __cancel_reset(struct drm_i915_private *i915,
+			  struct intel_engine_cs *engine)
+{
Quoted 9 lines

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 805

Quoted 7 lines
drivers/gpu/drm/i915/selftests/i915_request.c +7 -0
+	struct intel_context *ce;
+	struct igt_spinner spin;
+	struct i915_request *rq, *nop;
+	unsigned long preempt_timeout_ms;
+	int err = 0;
+
+	if (!CONFIG_DRM_I915_PREEMPT_TIMEOUT ||

Does this matter? The test is overriding the default anyway.

Yes. Execlists don't try to preempt anything if CONFIG_DRM_I915_PREEMPT_TIMEOUT is turned off. If we wan't to avoid the cancelation doing a full GT reset, CONFIG_DRM_I915_PREEMPT_TIMEOUT should be turned on.

Quoted 30 lines
Quoted 30 lines
drivers/gpu/drm/i915/selftests/i915_request.c +30 -0
+	    !intel_has_reset_engine(engine->gt))
+		return 0;
+
+	preempt_timeout_ms = engine->props.preempt_timeout_ms;
+	engine->props.preempt_timeout_ms = 100;
+
+	if (igt_spinner_init(&spin, engine->gt))
+		goto out_restore;
+
+	ce = intel_context_create(engine);
+	if (IS_ERR(ce)) {
+		err = PTR_ERR(ce);
+		goto out_spin;
+	}
+
+	rq = igt_spinner_create_request(&spin, ce, MI_NOOP);
+	if (IS_ERR(rq)) {
+		err = PTR_ERR(rq);
+		goto out_ce;
+	}
+
+	pr_debug("%s: Cancelling active non-preemptable request\n",
+		 engine->name);
+	i915_request_get(rq);
+	i915_request_add(rq);
+	if (!igt_wait_for_spinner(&spin, rq)) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
+
+		pr_err("Failed to start spinner on %s\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
Quoted 9 lines

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 842

Quoted 7 lines
drivers/gpu/drm/i915/selftests/i915_request.c +7 -0
+		err = -ETIME;
+		goto out_rq;
+	}
+
+	nop = intel_context_create_request(ce);
+	if (IS_ERR(nop))
+		goto out_nop;

Should be out_rq?

Yes, it should.

Matt

Quoted 72 lines

John.

Quoted 68 lines
drivers/gpu/drm/i915/selftests/i915_request.c +59 -0
+	i915_request_get(nop);
+	i915_request_add(nop);
+
+	i915_request_cancel(rq, -EINTR);
+
+	if (i915_request_wait(rq, 0, HZ) < 0) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
+
+		pr_err("%s: Failed to cancel hung request\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
+		err = -ETIME;
+		goto out_nop;
+	}
+
+	if (rq->fence.error != -EINTR) {
+		pr_err("%s: fence not cancelled (%u)\n",
+		       engine->name, rq->fence.error);
+		err = -EINVAL;
+		goto out_nop;
+	}
+
+	if (i915_request_wait(nop, 0, HZ) < 0) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
+
+		pr_err("%s: Failed to complete nop request\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
+		err = -ETIME;
+		goto out_nop;
+	}
+
+	if (nop->fence.error != 0) {
+		pr_err("%s: Nop request errored (%u)\n",
+		       engine->name, nop->fence.error);
+		err = -EINVAL;
+	}
+
+out_nop:
+	i915_request_put(nop);
+out_rq:
+	i915_request_put(rq);
+out_ce:
+	intel_context_put(ce);
+out_spin:
+	igt_spinner_fini(&spin);
+out_restore:
+	engine->props.preempt_timeout_ms = preempt_timeout_ms;
+	if (err)
+		pr_err("%s: %s error %d\n", __func__, engine->name, err);
+	return err;
+}
+
  static int live_cancel_request(void *arg)
  {
  	struct drm_i915_private *i915 = arg;
@@ -814,6 +923,14 @@ static int live_cancel_request(void *arg)
  			return err;
  		if (err2)
  			return err2;
+
+		/* Expects reset so call outside of igt_live_test_* */
+		err = __cancel_reset(i915, engine);
+		if (err)
+			return err;
+
+		if (igt_flush_test(i915))
+			return -EIO;
  	}
  	return 0;
#4 lore raw

Re: [PATCH 1/2] drm/i915/selftests: Add a cancel request selftest that triggers a reset

Quoted 57 lines · Matthew Brost
Quoted 18 lines · John Harrison
Quoted 17 lines · Matthew Brost

Add a cancel request selftest that results in an engine reset to cancel the request as it is non-preemptable. Also insert a NOP request after the cancelled request and confirm that it completes successfully.

v2:
(Tvrtko)
- Skip test if preemption timeout compiled out
- Skip test if engine reset isn't supported
- Update debug prints to be more descriptive
v3:
- Add comment explaining test

---
   drivers/gpu/drm/i915/selftests/i915_request.c | 117 ++++++++++++++++++
   1 file changed, 117 insertions(+)
Quoted 12 lines

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 786

Quoted 10 lines
drivers/gpu/drm/i915/selftests/i915_request.c +3 -0
index 7f66f6d299b26..f78de99d5ae1e 100644
@@ -782,6 +782,115 @@ static int __cancel_completed(struct intel_engine_cs *engine)
   	return err;
   }
+/*
+ * Test to prove a non-preemptable request can be cancelled and a subsequent
+ * request on the same context can successfully complete after cancallation.

cancellation

Yep.

Quoted 4 lines

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 789

Quoted 2 lines
drivers/gpu/drm/i915/selftests/i915_request.c +2 -0
+ *
+ * Testing methodology is to create non-preemptable request and submit it,

a non-preemptible

Yep.

Quoted 9 lines
Quoted 9 lines
drivers/gpu/drm/i915/selftests/i915_request.c +9 -0
+ * wait for spinner to start, create a NOP request and submit it, cancel the
+ * spinner, wait for spinner to complete and verify it failed with an error,
+ * finally wait for NOP request to complete verify it succeeded without an
+ * error. Preemption timeout also reduced / restored so test runs in a timely
+ * maner.
+ */
+static int __cancel_reset(struct drm_i915_private *i915,
+			  struct intel_engine_cs *engine)
+{
Quoted 9 lines

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 805

Quoted 7 lines
drivers/gpu/drm/i915/selftests/i915_request.c +7 -0
+	struct intel_context *ce;
+	struct igt_spinner spin;
+	struct i915_request *rq, *nop;
+	unsigned long preempt_timeout_ms;
+	int err = 0;
+
+	if (!CONFIG_DRM_I915_PREEMPT_TIMEOUT ||

Does this matter? The test is overriding the default anyway.

Quoted 5 lines

Yes. Execlists don't try to preempt anything if CONFIG_DRM_I915_PREEMPT_TIMEOUT is turned off. If we wan't to avoid the cancelation doing a full GT reset, CONFIG_DRM_I915_PREEMPT_TIMEOUT should be turned on.

Hmm, I would read that as a bug. The description for the config parameter is:
          "This is adjustable via /sys/class/drm/card?/engine/*/preempt_timeout_ms

          May be 0 to disable the timeout.

          The compiled in default may get overridden at driver probe time on certain platforms and certain engines which will be reflected in the sysfs control."

I would take that as meaning that even if the compiled in default is zero, the user or even the i915 driver itself could override that at runtime and enable pre-emption again. So having any code use this as a flag is broken. Indeed, any code other than 'engine->default_preempt_timeout = CONFIG_PREEMPT_TIMEOUT' is broken, IMHO.

But maybe that's for a different patch. If the driver is already behaving badly and doing the correct thing here will actually cause test failures then you can't really do much other than follow the existing bad behaviour.

John.

Quoted 114 lines
Quoted 30 lines
Quoted 30 lines
drivers/gpu/drm/i915/selftests/i915_request.c +30 -0
+	    !intel_has_reset_engine(engine->gt))
+		return 0;
+
+	preempt_timeout_ms = engine->props.preempt_timeout_ms;
+	engine->props.preempt_timeout_ms = 100;
+
+	if (igt_spinner_init(&spin, engine->gt))
+		goto out_restore;
+
+	ce = intel_context_create(engine);
+	if (IS_ERR(ce)) {
+		err = PTR_ERR(ce);
+		goto out_spin;
+	}
+
+	rq = igt_spinner_create_request(&spin, ce, MI_NOOP);
+	if (IS_ERR(rq)) {
+		err = PTR_ERR(rq);
+		goto out_ce;
+	}
+
+	pr_debug("%s: Cancelling active non-preemptable request\n",
+		 engine->name);
+	i915_request_get(rq);
+	i915_request_add(rq);
+	if (!igt_wait_for_spinner(&spin, rq)) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
+
+		pr_err("Failed to start spinner on %s\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
Quoted 9 lines

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 842

Quoted 7 lines
drivers/gpu/drm/i915/selftests/i915_request.c +7 -0
+		err = -ETIME;
+		goto out_rq;
+	}
+
+	nop = intel_context_create_request(ce);
+	if (IS_ERR(nop))
+		goto out_nop;

Should be out_rq?

Yes, it should.

Matt

Quoted 71 lines

John.

Quoted 68 lines
drivers/gpu/drm/i915/selftests/i915_request.c +59 -0
+	i915_request_get(nop);
+	i915_request_add(nop);
+
+	i915_request_cancel(rq, -EINTR);
+
+	if (i915_request_wait(rq, 0, HZ) < 0) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
+
+		pr_err("%s: Failed to cancel hung request\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
+		err = -ETIME;
+		goto out_nop;
+	}
+
+	if (rq->fence.error != -EINTR) {
+		pr_err("%s: fence not cancelled (%u)\n",
+		       engine->name, rq->fence.error);
+		err = -EINVAL;
+		goto out_nop;
+	}
+
+	if (i915_request_wait(nop, 0, HZ) < 0) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
+
+		pr_err("%s: Failed to complete nop request\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
+		err = -ETIME;
+		goto out_nop;
+	}
+
+	if (nop->fence.error != 0) {
+		pr_err("%s: Nop request errored (%u)\n",
+		       engine->name, nop->fence.error);
+		err = -EINVAL;
+	}
+
+out_nop:
+	i915_request_put(nop);
+out_rq:
+	i915_request_put(rq);
+out_ce:
+	intel_context_put(ce);
+out_spin:
+	igt_spinner_fini(&spin);
+out_restore:
+	engine->props.preempt_timeout_ms = preempt_timeout_ms;
+	if (err)
+		pr_err("%s: %s error %d\n", __func__, engine->name, err);
+	return err;
+}
+
   static int live_cancel_request(void *arg)
   {
   	struct drm_i915_private *i915 = arg;
@@ -814,6 +923,14 @@ static int live_cancel_request(void *arg)
   			return err;
   		if (err2)
   			return err2;
+
+		/* Expects reset so call outside of igt_live_test_* */
+		err = __cancel_reset(i915, engine);
+		if (err)
+			return err;
+
+		if (igt_flush_test(i915))
+			return -EIO;
   	}
   	return 0;
#5 lore raw

Re: [PATCH 1/2] drm/i915/selftests: Add a cancel request selftest that triggers a reset

Quoted 74 lines · John Harrison
Quoted 57 lines · Matthew Brost
Quoted 18 lines · John Harrison
Quoted 17 lines · Matthew Brost

Add a cancel request selftest that results in an engine reset to cancel the request as it is non-preemptable. Also insert a NOP request after the cancelled request and confirm that it completes successfully.

v2:
(Tvrtko)
- Skip test if preemption timeout compiled out
- Skip test if engine reset isn't supported
- Update debug prints to be more descriptive
v3:
- Add comment explaining test

---
   drivers/gpu/drm/i915/selftests/i915_request.c | 117 ++++++++++++++++++
   1 file changed, 117 insertions(+)
Quoted 12 lines

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 786

Quoted 10 lines
drivers/gpu/drm/i915/selftests/i915_request.c +3 -0
index 7f66f6d299b26..f78de99d5ae1e 100644
@@ -782,6 +782,115 @@ static int __cancel_completed(struct intel_engine_cs *engine)
   	return err;
   }
+/*
+ * Test to prove a non-preemptable request can be cancelled and a subsequent
+ * request on the same context can successfully complete after cancallation.

cancellation

Yep.

Quoted 4 lines

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 789

Quoted 2 lines
drivers/gpu/drm/i915/selftests/i915_request.c +2 -0
+ *
+ * Testing methodology is to create non-preemptable request and submit it,

a non-preemptible

Yep.

Quoted 9 lines
Quoted 9 lines
drivers/gpu/drm/i915/selftests/i915_request.c +9 -0
+ * wait for spinner to start, create a NOP request and submit it, cancel the
+ * spinner, wait for spinner to complete and verify it failed with an error,
+ * finally wait for NOP request to complete verify it succeeded without an
+ * error. Preemption timeout also reduced / restored so test runs in a timely
+ * maner.
+ */
+static int __cancel_reset(struct drm_i915_private *i915,
+			  struct intel_engine_cs *engine)
+{
Quoted 9 lines

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 805

Quoted 7 lines
drivers/gpu/drm/i915/selftests/i915_request.c +7 -0
+	struct intel_context *ce;
+	struct igt_spinner spin;
+	struct i915_request *rq, *nop;
+	unsigned long preempt_timeout_ms;
+	int err = 0;
+
+	if (!CONFIG_DRM_I915_PREEMPT_TIMEOUT ||

Does this matter? The test is overriding the default anyway.

Quoted 4 lines

Yes. Execlists don't try to preempt anything if CONFIG_DRM_I915_PREEMPT_TIMEOUT is turned off. If we wan't to avoid the cancelation doing a full GT reset, CONFIG_DRM_I915_PREEMPT_TIMEOUT should be turned on.

Hmm, I would read that as a bug. The description for the config parameter is:
          "This is adjustable via /sys/class/drm/card?/engine/*/preempt_timeout_ms

          May be 0 to disable the timeout.

          The compiled in default may get overridden at driver probe time on certain platforms and certain engines which will be reflected in the
          sysfs control."

Quoted 6 lines

I would take that as meaning that even if the compiled in default is zero, the user or even the i915 driver itself could override that at runtime and enable pre-emption again. So having any code use this as a flag is broken. Indeed, any code other than 'engine->default_preempt_timeout = CONFIG_PREEMPT_TIMEOUT' is broken, IMHO.

Can't really argue against you here.

Quoted 4 lines

But maybe that's for a different patch. If the driver is already behaving badly and doing the correct thing here will actually cause test failures then you can't really do much other than follow the existing bad behaviour.

Yea, agree it is out of scope this patch / series. We can cleanup the execlists code in a follow up patch if needed + loop in an execlists expert for a reviewer. Maybe there is a unknown reason that code is doing this?

Matt

Quoted 118 lines

John.

Quoted 114 lines
Quoted 30 lines
Quoted 30 lines
drivers/gpu/drm/i915/selftests/i915_request.c +30 -0
+	    !intel_has_reset_engine(engine->gt))
+		return 0;
+
+	preempt_timeout_ms = engine->props.preempt_timeout_ms;
+	engine->props.preempt_timeout_ms = 100;
+
+	if (igt_spinner_init(&spin, engine->gt))
+		goto out_restore;
+
+	ce = intel_context_create(engine);
+	if (IS_ERR(ce)) {
+		err = PTR_ERR(ce);
+		goto out_spin;
+	}
+
+	rq = igt_spinner_create_request(&spin, ce, MI_NOOP);
+	if (IS_ERR(rq)) {
+		err = PTR_ERR(rq);
+		goto out_ce;
+	}
+
+	pr_debug("%s: Cancelling active non-preemptable request\n",
+		 engine->name);
+	i915_request_get(rq);
+	i915_request_add(rq);
+	if (!igt_wait_for_spinner(&spin, rq)) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
+
+		pr_err("Failed to start spinner on %s\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
Quoted 9 lines

drivers/gpu/drm/i915/selftests/i915_request.c static int __cancel_completed(struct intel_engine_cs *engine) · line 842

Quoted 7 lines
drivers/gpu/drm/i915/selftests/i915_request.c +7 -0
+		err = -ETIME;
+		goto out_rq;
+	}
+
+	nop = intel_context_create_request(ce);
+	if (IS_ERR(nop))
+		goto out_nop;

Should be out_rq?

Yes, it should.

Matt

Quoted 71 lines

John.

Quoted 68 lines
drivers/gpu/drm/i915/selftests/i915_request.c +59 -0
+	i915_request_get(nop);
+	i915_request_add(nop);
+
+	i915_request_cancel(rq, -EINTR);
+
+	if (i915_request_wait(rq, 0, HZ) < 0) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
+
+		pr_err("%s: Failed to cancel hung request\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
+		err = -ETIME;
+		goto out_nop;
+	}
+
+	if (rq->fence.error != -EINTR) {
+		pr_err("%s: fence not cancelled (%u)\n",
+		       engine->name, rq->fence.error);
+		err = -EINVAL;
+		goto out_nop;
+	}
+
+	if (i915_request_wait(nop, 0, HZ) < 0) {
+		struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
+
+		pr_err("%s: Failed to complete nop request\n", engine->name);
+		intel_engine_dump(engine, &p, "%s\n", engine->name);
+		err = -ETIME;
+		goto out_nop;
+	}
+
+	if (nop->fence.error != 0) {
+		pr_err("%s: Nop request errored (%u)\n",
+		       engine->name, nop->fence.error);
+		err = -EINVAL;
+	}
+
+out_nop:
+	i915_request_put(nop);
+out_rq:
+	i915_request_put(rq);
+out_ce:
+	intel_context_put(ce);
+out_spin:
+	igt_spinner_fini(&spin);
+out_restore:
+	engine->props.preempt_timeout_ms = preempt_timeout_ms;
+	if (err)
+		pr_err("%s: %s error %d\n", __func__, engine->name, err);
+	return err;
+}
+
   static int live_cancel_request(void *arg)
   {
   	struct drm_i915_private *i915 = arg;
@@ -814,6 +923,14 @@ static int live_cancel_request(void *arg)
   			return err;
   		if (err2)
   			return err2;
+
+		/* Expects reset so call outside of igt_live_test_* */
+		err = __cancel_reset(i915, engine);
+		if (err)
+			return err;
+
+		if (igt_flush_test(i915))
+			return -EIO;
   	}
   	return 0;
#6 lore raw

PATCH 2/2 drm/i915/guc: Remove hacks for reset and schedule disable G2H being received out of order

In reply to Matthew Brost

In the i915 there are several hacks in place to make request cancelation work with an old version of the GuC which delivered the G2H indicating schedule disable is done before G2H indicating a context reset. Version 69 fixes this, so we can remove these hacks.

---
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 30 ++-----------------
 1 file changed, 2 insertions(+), 28 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +2 -28
index 23a40f10d376d..3918f1be114fa 100644
@@ -1533,7 +1533,6 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
 	unsigned long flags;
 	u32 head;
 	int i, number_children = ce->parallel.number_children;
-	bool skip = false;
 	struct intel_context *parent = ce;
 
 	GEM_BUG_ON(intel_context_is_child(ce));
@@ -1544,23 +1543,10 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
 	 * GuC will implicitly mark the context as non-schedulable when it sends
 	 * the reset notification. Make sure our state reflects this change. The
 	 * context will be marked enabled on resubmission.
-	 *
-	 * XXX: If the context is reset as a result of the request cancellation
-	 * this G2H is received after the schedule disable complete G2H which is
-	 * wrong as this creates a race between the request cancellation code
-	 * re-submitting the context and this G2H handler. This is a bug in the
-	 * GuC but can be worked around in the meantime but converting this to a
-	 * NOP if a pending enable is in flight as this indicates that a request
-	 * cancellation has occurred.
 	 */
 	spin_lock_irqsave(&ce->guc_state.lock, flags);
-	if (likely(!context_pending_enable(ce)))
-		clr_context_enabled(ce);
-	else
-		skip = true;
+	clr_context_enabled(ce);
 	spin_unlock_irqrestore(&ce->guc_state.lock, flags);
-	if (unlikely(skip))
-		goto out_put;
 
 	/*
 	 * For each context in the relationship find the hanging request
@@ -1592,7 +1578,6 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
 	}
 
 	__unwind_incomplete_requests(parent);
-out_put:
 	intel_context_put(parent);
 }
 
@@ -2531,12 +2516,6 @@ static void guc_context_cancel_request(struct intel_context *ce,
 					true);
 		}
 
-		/*
-		 * XXX: Racey if context is reset, see comment in
-		 * __guc_reset_context().
-		 */
-		flush_work(&ce_to_guc(ce)->ct.requests.worker);
-
 		guc_context_unblock(block_context);
 		intel_context_put(ce);
 	}
@@ -3971,12 +3950,7 @@ static void guc_handle_context_reset(struct intel_guc *guc,
 {
 	trace_intel_context_reset(ce);
 
-	/*
-	 * XXX: Racey if request cancellation has occurred, see comment in
-	 * __guc_reset_context().
-	 */
-	if (likely(!intel_context_is_banned(ce) &&
-		   !context_blocked(ce))) {
+	if (likely(!intel_context_is_banned(ce))) {
 		capture_error_state(guc, ce);
 		guc_context_replay(ce);
 	} else {
Signature · 1 line
2.34.1
Reviewed-by on v1 2/2
#7 lore raw

Re: [PATCH 2/2] drm/i915/guc: Remove hacks for reset and schedule disable G2H being received out of order

Quoted 6 lines · Matthew Brost

In the i915 there are several hacks in place to make request cancelation work with an old version of the GuC which delivered the G2H indicating schedule disable is done before G2H indicating a context reset. Version 69 fixes this, so we can remove these hacks.

Quoted 76 lines
---
  .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 30 ++-----------------
  1 file changed, 2 insertions(+), 28 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +2 -28
index 23a40f10d376d..3918f1be114fa 100644
@@ -1533,7 +1533,6 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
  	unsigned long flags;
  	u32 head;
  	int i, number_children = ce->parallel.number_children;
-	bool skip = false;
  	struct intel_context *parent = ce;
 
  	GEM_BUG_ON(intel_context_is_child(ce));
@@ -1544,23 +1543,10 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
  	 * GuC will implicitly mark the context as non-schedulable when it sends
  	 * the reset notification. Make sure our state reflects this change. The
  	 * context will be marked enabled on resubmission.
-	 *
-	 * XXX: If the context is reset as a result of the request cancellation
-	 * this G2H is received after the schedule disable complete G2H which is
-	 * wrong as this creates a race between the request cancellation code
-	 * re-submitting the context and this G2H handler. This is a bug in the
-	 * GuC but can be worked around in the meantime but converting this to a
-	 * NOP if a pending enable is in flight as this indicates that a request
-	 * cancellation has occurred.
  	 */
  	spin_lock_irqsave(&ce->guc_state.lock, flags);
-	if (likely(!context_pending_enable(ce)))
-		clr_context_enabled(ce);
-	else
-		skip = true;
+	clr_context_enabled(ce);
  	spin_unlock_irqrestore(&ce->guc_state.lock, flags);
-	if (unlikely(skip))
-		goto out_put;
 
  	/*
  	 * For each context in the relationship find the hanging request
@@ -1592,7 +1578,6 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
  	}
 
  	__unwind_incomplete_requests(parent);
-out_put:
  	intel_context_put(parent);
  }
 
@@ -2531,12 +2516,6 @@ static void guc_context_cancel_request(struct intel_context *ce,
  					true);
  		}
 
-		/*
-		 * XXX: Racey if context is reset, see comment in
-		 * __guc_reset_context().
-		 */
-		flush_work(&ce_to_guc(ce)->ct.requests.worker);
-
  		guc_context_unblock(block_context);
  		intel_context_put(ce);
  	}
@@ -3971,12 +3950,7 @@ static void guc_handle_context_reset(struct intel_guc *guc,
  {
  	trace_intel_context_reset(ce);
 
-	/*
-	 * XXX: Racey if request cancellation has occurred, see comment in
-	 * __guc_reset_context().
-	 */
-	if (likely(!intel_context_is_banned(ce) &&
-		   !context_blocked(ce))) {
+	if (likely(!intel_context_is_banned(ce))) {
  		capture_error_state(guc, ce);
  		guc_context_replay(ce);
  	} else {
#8 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Remove some hacks required for GuC 62.0.0

In reply to Matthew Brost
== Series Details ==

== Series Details ==

Series: Remove some hacks required for GuC 62.0.0
URL : https://patchwork.freedesktop.org/series/98773/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
845f929c1888 drm/i915/selftests: Add a cancel request selftest that triggers a reset
4d510c189a0d drm/i915/guc: Remove hacks for reset and schedule disable G2H being received out of order
-:7: WARNING:TYPO_SPELLING: 'cancelation' may be misspelled - perhaps 'cancellation'?
#7: 
In the i915 there are several hacks in place to make request cancelation
                                                             ^^^^^^^^^^^

total: 0 errors, 1 warnings, 0 checks, 63 lines checked

#9 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for Remove some hacks required for GuC 62.0.0

In reply to Matthew Brost
== Series Details ==

== Series Details ==

Series: Remove some hacks required for GuC 62.0.0
URL : https://patchwork.freedesktop.org/series/98773/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11069 -> Patchwork_21975
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/index.html

Participating hosts (44 -> 41)
------------------------------

Additional (1): fi-kbl-soraka
Missing (4): fi-bsw-cyan fi-bdw-samus bat-jsl-2 bat-adlp-4

Known issues
------------

Here are the changes found in Patchwork_21975 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@cs-compute:
- fi-cfl-guc: NOTRUN -> [SKIP][1] ([fdo#109271]) +26 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-cfl-guc/igt@amdgpu/[email protected]

* igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-skl-6600u: NOTRUN -> [SKIP][2] ([fdo#109271]) +18 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-skl-6600u/igt@amdgpu/[email protected]

* igt@debugfs_test@read_all_entries:
- fi-kbl-soraka: NOTRUN -> [DMESG-WARN][3] ([i915#1982] / [i915#262])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-kbl-soraka/igt@debugfs_test@read_all_entries.html

* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271]) +8 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-kbl-soraka/igt@gem_exec_fence@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-kbl-soraka/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-kbl-soraka/igt@[email protected]

* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][7] ([i915#1886] / [i915#2291])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][8] -> [INCOMPLETE][9] ([i915#3921])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/fi-snb-2600/igt@i915_selftest@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-snb-2600/igt@i915_selftest@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +8 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-kbl-soraka/igt@[email protected]

* igt@kms_chamelium@dp-edid-read:
- fi-cfl-guc: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-cfl-guc/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#533])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-kbl-soraka/igt@[email protected]
- fi-cfl-guc: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#533])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-cfl-guc/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3@smem:
- fi-tgl-1115g4: [FAIL][14] ([i915#1888]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/fi-tgl-1115g4/igt@gem_exec_suspend@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-tgl-1115g4/igt@gem_exec_suspend@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [DMESG-WARN][16] ([i915#4269]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/fi-cml-u2/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-cml-u2/igt@[email protected]

* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: [INCOMPLETE][18] ([i915#4838]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/fi-skl-6600u/igt@kms_psr@primary_page_flip.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4838]: https://gitlab.freedesktop.org/drm/intel/issues/4838
[i915#4898]: https://gitlab.freedesktop.org/drm/intel/issues/4898
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533

Build changes
-------------

* Linux: CI_DRM_11069 -> Patchwork_21975

CI-20190529: 20190529
CI_DRM_11069: fd4f1b6004407e645951f719524b404211ba101d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6326: ec75f64fcbcf4aac58fbf1bf629e8f59b19db4ce @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21975: 4d510c189a0d5dbb7deb6d52cae4718da99eebeb @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

4d510c189a0d drm/i915/guc: Remove hacks for reset and schedule disable G2H being received out of order 845f929c1888 drm/i915/selftests: Add a cancel request selftest that triggers a reset

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/index.html

#10 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for Remove some hacks required for GuC 62.0.0

In reply to Matthew Brost
== Series Details ==

== Series Details ==

Series: Remove some hacks required for GuC 62.0.0
URL : https://patchwork.freedesktop.org/series/98773/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11069_full -> Patchwork_21975_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in Patchwork_21975_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@feature_discovery@psr2:
- shard-iclb: [PASS][1] -> [SKIP][2] ([i915#658])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb6/igt@[email protected]

* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [PASS][3] -> [SKIP][4] ([i915#4525]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb3/igt@[email protected]

* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [PASS][5] -> [FAIL][6] ([i915#2842]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-kbl4/igt@gem_exec_fair@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl7/igt@gem_exec_fair@[email protected]
- shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2842]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-tglb6/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][9] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][10] -> [FAIL][11] ([i915#2849])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb5/igt@gem_exec_fair@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb3/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@heavy-multi:
- shard-skl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4613]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl2/igt@[email protected]

* igt@gem_lmem_swapping@heavy-verify-random:
- shard-kbl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4613])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl1/igt@[email protected]

* igt@gem_lmem_swapping@random:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4613])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl4/igt@[email protected]

* igt@gem_pwrite@basic-exhaustion:
- shard-skl: NOTRUN -> [WARN][15] ([i915#2658]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl4/igt@[email protected]

* igt@gem_render_copy@linear-to-vebox-y-tiled:
- shard-apl: NOTRUN -> [SKIP][16] ([fdo#109271]) +27 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl4/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-iclb: NOTRUN -> [SKIP][17] ([i915#3323])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][18] ([i915#3323])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-tglb5/igt@[email protected]

* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][19] ([i915#3002]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl6/igt@[email protected]

* igt@gen9_exec_parse@shadow-peek:
- shard-tglb: NOTRUN -> [SKIP][20] ([i915#2527] / [i915#2856])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][21] ([i915#2856])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb6/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [PASS][22] -> [SKIP][23] ([i915#4281])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb2/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb3/igt@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-apl: [PASS][24] -> [DMESG-WARN][25] ([i915#180]) +5 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-apl1/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl2/igt@[email protected]

* igt@kms_async_flips@crc:
- shard-skl: NOTRUN -> [FAIL][26] ([i915#4272])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl1/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][27] ([i915#3743]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3777])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl1/igt@[email protected]

* igt@kms_big_fb@y-tiled-32bpp-rotate-0:
- shard-glk: [PASS][29] -> [DMESG-WARN][30] ([i915#118])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-glk7/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-glk8/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#3777]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl2/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][32] ([i915#3763])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl1/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3777])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl4/igt@[email protected]

* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][34] ([fdo#109278]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb6/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs.html

* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#3886])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl4/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3886]) +11 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl2/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-kbl: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl1/igt@[email protected]

* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-skl: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +15 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl7/igt@[email protected]

* igt@kms_color_chamelium@pipe-b-ctm-0-25:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl6/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-red-to-blue:
- shard-tglb: NOTRUN -> [SKIP][40] ([fdo#109284] / [fdo#111827])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][41] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding:
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#3359]) +2 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-tglb8/igt@[email protected]

* igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][43] -> [DMESG-WARN][44] ([i915#1982])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-skl10/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions-varying-size.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl2/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions-varying-size.html

* igt@kms_flip@2x-flip-vs-panning-interruptible:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109274])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][46] ([fdo#109274] / [fdo#111825])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-tglb5/igt@[email protected]

* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][47] -> [DMESG-WARN][48] ([i915#180]) +3 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-kbl7/igt@kms_flip@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl4/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#2587])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-tglb8/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack-mmap-gtt:
- shard-skl: NOTRUN -> [SKIP][50] ([fdo#109271]) +224 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#109280] / [fdo#111825]) +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#533]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][53] ([i915#265])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][54] ([fdo#108145] / [i915#265])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: NOTRUN -> [FAIL][55] ([fdo#108145] / [i915#265]) +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl2/igt@[email protected]

* igt@kms_plane_multiple@atomic-pipe-d-tiling-x:
- shard-kbl: NOTRUN -> [SKIP][56] ([fdo#109271]) +30 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl1/igt@[email protected]

* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-skl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#2733])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl1/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html

* igt@kms_psr2_su@page_flip-nv12:
- shard-skl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#658])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl2/igt@kms_psr2_su@page_flip-nv12.html

* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][59] -> [SKIP][60] ([fdo#109441]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb6/igt@kms_psr@psr2_cursor_blt.html

* igt@kms_vblank@pipe-c-accuracy-idle:
- shard-skl: NOTRUN -> [FAIL][61] ([i915#43])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl2/igt@[email protected]

* igt@kms_writeback@writeback-pixel-formats:
- shard-skl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#2437])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl6/igt@[email protected]

* igt@prime_nv_pcopy@test_semaphore:
- shard-tglb: NOTRUN -> [SKIP][63] ([fdo#109291])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-tglb8/igt@prime_nv_pcopy@test_semaphore.html

* igt@sysfs_clients@fair-0:
- shard-skl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#2994]) +2 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl4/igt@[email protected]

* igt@sysfs_clients@split-25:
- shard-kbl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#2994])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl1/igt@[email protected]

#### Possible fixes ####

* igt@gem_eio@in-flight-contexts-1us:
- shard-tglb: [TIMEOUT][66] ([i915#3063]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-tglb1/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-tglb6/igt@[email protected]

* igt@gem_eio@in-flight-suspend:
- shard-kbl: [DMESG-WARN][68] ([i915#180]) -> [PASS][69] +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-kbl4/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl1/igt@[email protected]

* igt@gem_eio@kms:
- shard-tglb: [FAIL][70] ([i915#232]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-tglb1/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-tglb6/igt@[email protected]

* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][72] ([i915#4525]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb5/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb2/igt@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][74] ([i915#2842]) -> [PASS][75] +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-kbl6/igt@gem_exec_fair@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [FAIL][76] ([i915#2842]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-glk5/igt@gem_exec_fair@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-glk1/igt@gem_exec_fair@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [DMESG-WARN][78] ([i915#118]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-glk3/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-glk9/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [FAIL][80] ([i915#2346]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-skl7/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl8/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-iclb: [FAIL][82] ([i915#2346]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb7/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb5/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [DMESG-WARN][84] ([i915#180]) -> [PASS][85] +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-apl1/igt@kms_flip@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl4/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-glk: [FAIL][86] ([i915#2546]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-glk4/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-glk5/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-slowdraw:
- shard-skl: [DMESG-WARN][88] ([i915#1982]) -> [PASS][89] +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-skl4/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl1/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-skl: [INCOMPLETE][90] ([i915#4939]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-skl8/igt@kms_plane@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl4/igt@kms_plane@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][92] ([fdo#108145] / [i915#265]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-skl1/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-skl4/igt@[email protected]

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][94] ([fdo#109441]) -> [PASS][95] +3 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

* igt@kms_psr@suspend:
- shard-iclb: [SKIP][96] -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb5/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb2/igt@[email protected]

#### Warnings ####

* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [SKIP][98] ([i915#4525]) -> [FAIL][99] ([i915#4916])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb8/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb1/igt@[email protected]

* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][100] ([i915#2852]) -> [FAIL][101] ([i915#2842])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb7/igt@gem_exec_fair@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb1/igt@gem_exec_fair@[email protected]

* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][102] ([i915#2684]) -> [WARN][103] ([i915#1804] / [i915#2684])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb2/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb3/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][104] ([i915#1804] / [i915#2684]) -> [WARN][105] ([i915#2684])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb3/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb8/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][106] ([i915#2920]) -> [SKIP][107] ([fdo#111068] / [i915#658])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb2/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb4/igt@[email protected]

* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [FAIL][108] ([i915#4148]) -> [SKIP][109] ([fdo#109642] / [fdo#111068] / [i915#658])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-iclb4/igt@kms_psr2_su@page_flip-xrgb8888.html

* igt@runner@aborted:
- shard-kbl: ([FAIL][110], [FAIL][111], [FAIL][112], [FAIL][113], [FAIL][114]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#4312]) -> ([FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#4312])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-kbl4/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-kbl7/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-kbl3/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-kbl4/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-kbl4/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl4/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl4/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl7/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl4/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl6/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-kbl4/igt@[email protected]
- shard-apl: ([FAIL][121], [FAIL][122]) ([i915#180] / [i915#1814] / [i915#4312]) -> ([FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#4312])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-apl1/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11069/shard-apl4/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl6/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl4/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl6/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl4/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl2/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/shard-apl4/igt@[email protected]

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#232]: https://gitlab.freedesktop.org/drm/intel/issues/232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2733]: https://gitlab.freedesktop.org/drm/intel/issues/2733
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2852]: https://gitlab.freedesktop.org/drm/intel/issues/2852
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3763]: https://gitlab.freedesktop.org/drm/intel/issues/3763
[i915#3777]: https://gitlab.freedesktop.org/drm/intel/issues/3777
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4148]: https://gitlab.freedesktop.org/drm/intel/issues/4148
[i915#4272]: https://gitlab.freedesktop.org/drm/intel/issues/4272
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4916]: https://gitlab.freedesktop.org/drm/intel/issues/4916
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658

Build changes
-------------

* Linux: CI_DRM_11069 -> Patchwork_21975

CI-20190529: 20190529
CI_DRM_11069: fd4f1b6004407e645951f719524b404211ba101d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6326: ec75f64fcbcf4aac58fbf1bf629e8f59b19db4ce @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21975: 4d510c189a0d5dbb7deb6d52cae4718da99eebeb @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21975/index.html