Skip to contentSkip to conversation

ubifs: use default_groups in kobj_type

PATCH Superseded Greg Kroah-Hartman 2 participants 3 messages Jan 13, 2022 – Jan 14, 2022

Subsystems (2)
Memory technology devices (MTD) UBI file system (UBIFS)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Greg Kroah-Hartman

author
#0 lore raw

PATCH 1/1 ubifs: use default_groups in kobj_type

There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the AMD mce sysfs code to use default_groups field which has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups to kobj_type") so that we can soon get rid of the obsolete default_attrs field.

Cc Richard Weinberger <[email protected]>
Cc Stefan Schaeckeler <[email protected]>
Cc [email protected]
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
 fs/ubifs/sysfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/ubifs/sysfs.c +2 -1
index 7acc5a74e5fa..06ad8fa1fcfb 100644
@@ -42,6 +42,7 @@ static struct attribute *ubifs_attrs[] = {
 	ATTR_LIST(errors_crc),
 	NULL,
 };
+ATTRIBUTE_GROUPS(ubifs);
 
 static ssize_t ubifs_attr_show(struct kobject *kobj,
 			       struct attribute *attr, char *buf)

@@ -74,7 +75,7 @@ static const struct sysfs_ops ubifs_attr_ops = {
 };
 
 static struct kobj_type ubifs_sb_ktype = {
-	.default_attrs	= ubifs_attrs,
+	.default_groups	= ubifs_groups,
 	.sysfs_ops	= &ubifs_attr_ops,
 	.release	= ubifs_sb_release,
 };
Signature · 1 line
2.34.1
#1 lore raw

Hi,

Am 2022-01-13 19:08, schrieb Greg Kroah-Hartman:

Quoted 3 lines

There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the AMD mce sysfs code to use default_groups field which

copy & paste mistake?

Quoted 3 lines

has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups to kobj_type") so that we can soon get rid of the obsolete default_attrs field.

-michael

author
#2 lore raw
Quoted 8 lines · Michael Walle

Hi,

Am 2022-01-13 19:08, schrieb Greg Kroah-Hartman:

Quoted 3 lines

There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the AMD mce sysfs code to use default_groups field which

copy & paste mistake?

Ugh, yes, sorry, will go fix this up, thanks...

greg k-h