Skip to contentSkip to conversation

ARM: dts: aspeed: rainier: add reset-cause-pinhole

PATCH In review Andrew Geissler 2 participants 3 messages Jan 13, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: dts: aspeed: rainier: add reset-cause-pinhole

This GPIO is used on the rainier system to indicate the BMC was reset due to a physical pinhole reset.

See the following doc for more information:
https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md

---
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts +2 -1
index cfaa606666e2..7ea70c7d698f 100644
@@ -247,7 +247,8 @@ &gpio0 {
 	/*C0-C7*/	"","","","","","","","",
 	/*D0-D7*/	"","","","","","","","",
 	/*E0-E7*/	"","","","","","","","",
-	/*F0-F7*/	"","","battery-voltage-read-enable","","","","factory-reset-toggle","",
+	/*F0-F7*/	"","","battery-voltage-read-enable","reset-cause-pinhole","","",
+				"factory-reset-toggle","",
 	/*G0-G7*/	"","","","","","","","",
 	/*H0-H7*/	"","bmc-ingraham0","rear-enc-id0","rear-enc-fault0","","","","",
 	/*I0-I7*/	"","","","","","","bmc-secure-boot","",
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/2 ARM: dts: aspeed: everest: add reset-cause-pinhole

This GPIO is used on the everest system to indicate the BMC was reset due to a physical pinhole reset.

It has been verified that the previous name for this pin has not been utilized by userspace so the name change is ok.

See the following doc for more information:
https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md

---
 arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts +1 -1
index f48b33b0c606..6b5d5c56951f 100644
@@ -271,7 +271,7 @@ &gpio0 {
 	/*D0-D7*/	"","","","","","","","",
 	/*E0-E7*/	"","","","","","","","",
 	/*F0-F7*/	"PIN_HOLE_RESET_IN_N","","battery-voltage-read-enable",
-				"PIN_HOLE_RESET_OUT_N","","",
+				"reset-cause-pinhole","","",
 				"factory-reset-toggle","",
 	/*G0-G7*/	"","","","","","","","",
 	/*H0-H7*/	"led-rtc-battery","led-bmc","led-rear-enc-id0","led-rear-enc-fault0","","","","",
Signature · 1 line
2.25.1
maintainer
#2 lore raw
In reply to Andrew Geissler

Hi Andrew,

Quoted 8 lines · Andrew Geissler

This GPIO is used on the rainier system to indicate the BMC was reset due to a physical pinhole reset.

See the following doc for more information:
https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md

I couldn't apply these cleanly to any tree I had. I think you had a patch to add battery-voltage-read-enable, but that's not in the tree yet.

I fixed them up to apply.

Cheers,

Joel

Quoted 21 lines
---
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts +2 -2
index cfaa606666e2..7ea70c7d698f 100644
@@ -247,7 +247,8 @@ &gpio0 {
        /*C0-C7*/       "","","","","","","","",
        /*D0-D7*/       "","","","","","","","",
        /*E0-E7*/       "","","","","","","","",
-       /*F0-F7*/       "","","battery-voltage-read-enable","","","","factory-reset-toggle","",
+       /*F0-F7*/       "","","battery-voltage-read-enable","reset-cause-pinhole","","",
+                               "factory-reset-toggle","",
        /*G0-G7*/       "","","","","","","","",
        /*H0-H7*/       "","bmc-ingraham0","rear-enc-id0","rear-enc-fault0","","","","",
        /*I0-I7*/       "","","","","","","bmc-secure-boot","",
--

2.25.1