clk: mediatek: Fix memory leaks on probe
Subsystems (2)
PATCH RESEND v2 1/1 clk: mediatek: Fix memory leaks on probe
Handle the error branches to free memory where required.
Addresses-Coverity-ID: 1491825 ("Resource leak")
Signed-off-by José Expósito <[email protected]>
Reviewed-by Chen-Yu Tsai <[email protected]>
---
v2: Add Reviewed-by tag
--- drivers/clk/mediatek/clk-mt8192.c | 36 +++++++++++++++++++++++++------ 1 file changed, 30 insertions(+), 6 deletions(-)
drivers/clk/mediatek/clk-mt8192.c +30 -6
@@ -1236,9 +1236,17 @@ static int clk_mt8192_infra_probe(struct platform_device *pdev) r =mtk_clk_register_gates (node, infra_clks,ARRAY_SIZE (infra_clks), clk_data);if (r) -return r; + goto free_clk_data; + + r =of_clk_add_provider (node, of_clk_src_onecell_get, clk_data); +if (r) + goto free_clk_data; + +return r; -return of_clk_add_provider (node, of_clk_src_onecell_get, clk_data); +free_clk_data: +mtk_free_clk_data (clk_data); +return r; }static int clk_mt8192_peri_probe (struct platform_device *pdev)
@@ -1253,9 +1261,17 @@ static int clk_mt8192_peri_probe(struct platform_device *pdev) r =mtk_clk_register_gates (node, peri_clks,ARRAY_SIZE (peri_clks), clk_data);if (r) -return r; + goto free_clk_data; + + r =of_clk_add_provider (node, of_clk_src_onecell_get, clk_data); +if (r) + goto free_clk_data; -return of_clk_add_provider (node, of_clk_src_onecell_get, clk_data); +return r; + +free_clk_data: +mtk_free_clk_data (clk_data); +return r; }static int clk_mt8192_apmixed_probe (struct platform_device *pdev)
@@ -1271,9 +1287,17 @@ static int clk_mt8192_apmixed_probe(struct platform_device *pdev)mtk_clk_register_plls (node, plls,ARRAY_SIZE (plls), clk_data); r =mtk_clk_register_gates (node, apmixed_clks,ARRAY_SIZE (apmixed_clks), clk_data);if (r) -return r; + goto free_clk_data; -return of_clk_add_provider (node, of_clk_src_onecell_get, clk_data); + r =of_clk_add_provider (node, of_clk_src_onecell_get, clk_data); +if (r) + goto free_clk_data; + +return r; + +free_clk_data: +mtk_free_clk_data (clk_data); +return r; }static const struct of_device_id of_match_clk_mt8192[] = {
Signature · 1 line
2.25.1
Stephen Boyd
maintainerPlease Cc the clk mailing list on clk driver patches.
Quoting José Expósito (2022-01-07 10:24:51)
Quoted 6 lines
Handle the error branches to free memory where required.
Addresses-Coverity-ID: 1491825 ("Resource leak")
Signed-off-by José Expósito <[email protected]>Reviewed-by Chen-Yu Tsai <[email protected]>