Skip to contentSkip to conversation

package/rtl8723bu: bump to version 19b4bdc05483a1e79a4f955a80f8f72cdd5dedc3

PATCH Applied Doug Brown via buildroot 3 participants 5 messages Jan 14, 2022 – Feb 16, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/rtl8723bu: bump to version 19b4bdc05483a1e79a4f955a80f8f72cdd5dedc3

This version fixes a bug that prevents the user from switching from one access point to another.

---
 package/rtl8723bu/rtl8723bu.hash | 2 +-
 package/rtl8723bu/rtl8723bu.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/rtl8723bu/rtl8723bu.hash +1 -1
index 04bc776a07..1dad7154b4 100644
@@ -1,2 +1,2 @@
 # Locally computed
-sha256  4c7314dccebda1e55ec8dcf0d5ca8915c2490d17a9f56923f25e6e0e945c10cc  rtl8723bu-9ce1c38439f4f574bb7adaf33949835c25536a28.tar.gz
+sha256  1cd658742ce10b21c92877e09cecc98880680d5f150de3845553005abc542977  rtl8723bu-19b4bdc05483a1e79a4f955a80f8f72cdd5dedc3.tar.gz
package/rtl8723bu/rtl8723bu.mk +1 -1
index c35fad5832..e490bddf09 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RTL8723BU_VERSION = 9ce1c38439f4f574bb7adaf33949835c25536a28
+RTL8723BU_VERSION = 19b4bdc05483a1e79a4f955a80f8f72cdd5dedc3
 RTL8723BU_SITE = $(call github,lwfinger,rtl8723bu,$(RTL8723BU_VERSION))
 RTL8723BU_LICENSE = GPL-2.0, proprietary (*.bin firmware blobs)
 
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/2 package/rtl8723bu: fix firmware install path

The rtl8723b_fw.bin file installed by this package is not actually used by this driver at all. It is used by the btrtl Bluetooth driver in the mainline kernel. The mainline btrtl driver looks for the file in /lib/firmware/rtl_bt rather than /lib/firmware/rtlwifi. This driver's Makefile has an install target that confirms the correct destination firmware directory.

---
 package/rtl8723bu/rtl8723bu.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/rtl8723bu/rtl8723bu.mk +1 -1
index e490bddf09..838bbedb74 100644
@@ -13,7 +13,7 @@ RTL8723BU_MODULE_MAKE_OPTS = \
 	KSRC=$(LINUX_DIR)
 
 define RTL8723BU_INSTALL_TARGET_CMDS
-	$(INSTALL) -D -m 644 $(@D)/rtl8723b_fw.bin $(TARGET_DIR)/lib/firmware/rtlwifi/rtl8723b_fw.bin
+	$(INSTALL) -D -m 644 $(@D)/rtl8723b_fw.bin $(TARGET_DIR)/lib/firmware/rtl_bt/rtl8723b_fw.bin
 endef
 
 $(eval $(kernel-module))
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH 2/2] package/rtl8723bu: fix firmware install path

Quoted 8 lines · Doug Brown via buildroot

The rtl8723b_fw.bin file installed by this package is not actually used by this driver at all. It is used by the btrtl Bluetooth driver in the mainline kernel. The mainline btrtl driver looks for the file in /lib/firmware/rtl_bt rather than /lib/firmware/rtlwifi. This driver's Makefile has an install target that confirms the correct destination firmware directory.

Applied to master, thanks.

I also double-checked that this was indeed wrong from the very first version
that was added to Buildroot.

@Peter this is for stable.

Regards,
Arnout

Quoted 9 lines
---
  package/rtl8723bu/rtl8723bu.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
package/rtl8723bu/rtl8723bu.mk +0 -0
index e490bddf09..838bbedb74 100644

package/rtl8723bu/rtl8723bu.mk RTL8723BU_MODULE_MAKE_OPTS = \ · line 19

Quoted 8 lines
package/rtl8723bu/rtl8723bu.mk +1 -1
@@ -13,7 +13,7 @@ RTL8723BU_MODULE_MAKE_OPTS = \
  	KSRC=$(LINUX_DIR)
 
  define RTL8723BU_INSTALL_TARGET_CMDS
-	$(INSTALL) -D -m 644 $(@D)/rtl8723b_fw.bin $(TARGET_DIR)/lib/firmware/rtlwifi/rtl8723b_fw.bin
+	$(INSTALL) -D -m 644 $(@D)/rtl8723b_fw.bin $(TARGET_DIR)/lib/firmware/rtl_bt/rtl8723b_fw.bin
  endef
 
  $(eval $(kernel-module))

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw

Re: [Buildroot] [PATCH 2/2] package/rtl8723bu: fix firmware install path

In reply to Doug Brown via buildroot
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Doug" == Doug Brown via buildroot <[email protected]> writes:

The rtl8723b_fw.bin file installed by this package is not actually used by this driver at all. It is used by the btrtl Bluetooth driver in the mainline kernel. The mainline btrtl driver looks for the file in /lib/firmware/rtl_bt rather than /lib/firmware/rtlwifi. This driver's Makefile has an install target that confirms the correct destination firmware directory.

Committed to 2021.02.x and 2021.11.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw
In reply to Doug Brown via buildroot
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Doug" == Doug Brown via buildroot <[email protected]> writes:

This version fixes a bug that prevents the user from switching from one access point to another.

Committed to 2021.02.x and 2021.11.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot