Skip to contentSkip to conversation

drm/amdgpu: drop redundant check of ip discovery_bin

PATCH In review Guchun Chen 2 participants 2 messages Jan 14, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/amdgpu: drop redundant check of ip discovery_bin

Early check in amdgpu_discovery_reg_base_init promises this.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +0 -5
index 57e001d73ec9..2f891ae90bad 100644
@@ -1194,11 +1194,6 @@ int amdgpu_discovery_set_ip_blocks(struct amdgpu_device *adev)
 			return -EINVAL;
 
 		amdgpu_discovery_harvest_ip(adev);
-
-		if (!adev->mman.discovery_bin) {
-			DRM_ERROR("ip discovery uninitialized\n");
-			return -EINVAL;
-		}
 		break;
 	}
 
Signature · 1 line
2.17.1
maintainer Reviewed-by on v1 1/2
#1 lore raw

[Public]

Series is:

________________________________
From: Chen, Guchun <[email protected]>
Sent: Friday, January 14, 2022 12:58 AM
To: [email protected] <[email protected]>; Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Pan, Xinhui <[email protected]>; Zhang, Hawking <[email protected]>; Zhou, Peng Ju <[email protected]>
Cc: Chen, Guchun <[email protected]>
Subject: [PATCH 1/2] drm/amdgpu: drop redundant check of ip discovery_bin

Early check in amdgpu_discovery_reg_base_init promises this.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +0 -5
index 57e001d73ec9..2f891ae90bad 100644
@@ -1194,11 +1194,6 @@ int amdgpu_discovery_set_ip_blocks(struct amdgpu_device *adev)
                         return -EINVAL;
 
                 amdgpu_discovery_harvest_ip(adev);
-
-               if (!adev->mman.discovery_bin) {
-                       DRM_ERROR("ip discovery uninitialized\n");
-                       return -EINVAL;
-               }
                 break;
         }
 

--
2.17.1