lib82596: Fix IRQ check in sni_82596_probe
Subsystems (2)
PATCH 1/1 lib82596: Fix IRQ check in sni_82596_probe
platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example:
int irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;Fix the check of return value to catch errors correctly.
Fixes 115978859272 ("i825xx: Move the Intel 82586/82593/82596 based drivers")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/net/ethernet/i825xx/sni_82596.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/i825xx/sni_82596.c +2 -1
@@ -117,9 +117,10 @@ static int sni_82596_probe(struct platform_device *dev) netdevice->dev_addr[5 ] =readb (eth_addr +0x06 );iounmap (eth_addr); -if (!netdevice->irq) { +if (netdevice->irq <0 ) {printk (KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n" , __FILE__, netdevice->base_addr); + retval = netdevice->irq; goto probe_failed; }
Signature · 1 line
2.17.1
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 8 lines · On Fri, 14 Jan 2022 06:57:24 +0000 you wrote:
platform_get_irq()returns negative error number instead 0 on failure. And the doc ofplatform_get_irq()provides a usage example:int irq = platform_get_irq(pdev, 0); if (irq < 0) return irq;[...]
Here is the summary with links:
- lib82596: Fix IRQ check in sni_82596_probe
https://git.kernel.org/netdev/net/c/99218cbf81bf
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html