Add support to register platform service IRQ
v4 cover Add support to register platform service IRQ
Some platforms have dedicated IRQ lines for platform-specific System Errors like AER/PME etc. The root complex on these platform will use these seperate IRQ lines to report AER/PME etc., interrupts and will not generate MSI/MSI-X/INTx interrupts for these services.
These patches will add new method for these kind of platforms to register the platform IRQ number with respective PCIe services.
Changes in v4 (Stefan):
- Remove 2nd check for PCI_EXP_TYPE_ROOT_PORT
- Change init_platform_service_irqs() from void to return int
Changes in v3 (Stefan):
- Restructure patches from 4 patches in v2 to now 2 patches in v3
- Rename of functions names
- init_platform_service_irqs() now uses "struct pci_dev *" instead of "struct pci_host_bridge *"
- pcie_init_platform_service_irqs() is called before pcie_init_service_irqs()
- Use more PCIe spec terminology as suggested by Bjorn (hopefully enough, I don't have the spec at hand)
Bharat Kumar Gogada (2):
PCI/portdrv: Add option to setup IRQs for platform-specific Service
Errors
PCI: xilinx-nwl: Add method to init_platform_service_irqs hook
drivers/pci/controller/pcie-xilinx-nwl.c | 18 +++++++++++ drivers/pci/pcie/portdrv_core.c | 39 +++++++++++++++++++++++- include/linux/pci.h | 2 ++ 3 files changed, 58 insertions(+), 1 deletion(-)
Signature · 1 line
2.34.1
PATCH v4 1/2 PCI/portdrv: Add option to setup IRQs for platform-specific Service Errors
From: Bharat Kumar Gogada <[email protected]>
As per section 6.2.4.1.2, 6.2.6 in PCIe r4.0 (and later versions), platform-specific System Errors like AER can be delivered via platform- specific interrupt lines.
This patch adds the init_platform_service_irqs() hook to struct pci_host_bridge, making it possible that platforms may implement this function to hook IRQs for these platform-specific System Errors, like AER.
If these platform-specific service IRQs have been successfully installed via pcie_init_platform_service_irqs(), pcie_init_service_irqs() is skipped.
--- drivers/pci/pcie/portdrv_core.c | 39 ++++++++++++++++++++++++++++++++- include/linux/pci.h | 2 ++ 2 files changed, 40 insertions(+), 1 deletion(-)
drivers/pci/pcie/portdrv_core.c +38 -1
@@ -190,6 +190,31 @@ static int pcie_init_service_irqs(struct pci_dev *dev, int *irqs, int mask)return 0 ; } +/** +* pcie_init_platform_service_irqs - initialize platform service irqs for +* platform-specific System Errors +* @dev: PCI Express port to handle +* @irqs: Array of irqs to populate +* @mask: Bitmask of capabilities +* +* Return value: -ENODEV, in case no platform-specific IRQ is available +*/ +static int pcie_init_platform_service_irqs (struct pci_dev *dev, +int *irqs,int mask) +{ +struct pci_host_bridge *bridge; + +if (pci_pcie_type (dev) ==PCI_EXP_TYPE_ROOT_PORT ) { + bridge =pci_find_host_bridge (dev->bus); +if (bridge && bridge->init_platform_service_irqs) { +return bridge->init_platform_service_irqs (dev, irqs, + mask); + } + } + +return -ENODEV ; +} +/** * get_port_device_capability - discover capabilities of a PCI Express port * @dev: PCI Express port to examine
@@ -335,7 +360,19 @@ int pcie_port_device_register(struct pci_dev *dev) irq_services |=PCIE_PORT_SERVICE_DPC ; irq_services &= capabilities; -if (irq_services) { +/* +* Some platforms have dedicated interrupts from root complex to +* interrupt controller for PCIe platform-specific System Errors +* like AER/PME etc., check if the platform registered with any such +* IRQ. +*/ + status =pcie_init_platform_service_irqs (dev, irqs, capabilities); + +/* +* Only install service irqs, when the platform-specific hook was +* unsuccessful +*/ +if (irq_services && status) {/* * Initialize service IRQs. Don't use service devices that * require interrupts if there is no way to generate them.
include/linux/pci.h +2 -0
@@ -554,6 +554,8 @@ struct pci_host_bridge {u8 (*swizzle_irq)(struct pci_dev *,u8 *);/* Platform IRQ swizzler */ int (*map_irq)(const struct pci_dev *,u8 ,u8 );void (*release_fn)(struct pci_host_bridge *); +int (*init_platform_service_irqs)(struct pci_dev *dev,int *irqs, +int plat_mask);void *release_data; unsigned int ignore_reset_delay:1; /* For entire hierarchy */ unsigned int no_ext_tags:1; /* No Extended Tags */
Signature · 1 line
2.34.1
Re: [PATCH v4 1/2] PCI/portdrv: Add option to setup IRQs for platform-specific Service Errors
Quoted 15 lines · On Friday 14 January 2022 08:58:33 Stefan Roese wrote:
From: Bharat Kumar Gogada <[email protected]>
As per section 6.2.4.1.2, 6.2.6 in PCIe r4.0 (and later versions), platform-specific System Errors like AER can be delivered via platform- specific interrupt lines.
This patch adds the
init_platform_service_irqs()hook to structpci_host_bridge, making it possible that platforms may implement this function to hook IRQs for these platform-specific System Errors, like AER.If these platform-specific service IRQs have been successfully installed via
pcie_init_platform_service_irqs(),pcie_init_service_irqs()is skipped.
Quoted 5 lines
Signed-off-by Bharat Kumar Gogada <[email protected]>Signed-off-by Stefan Roese <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Pali Rohár <[email protected]>Cc Michal Simek <[email protected]>
Quoted 78 lines
--- drivers/pci/pcie/portdrv_core.c | 39 ++++++++++++++++++++++++++++++++- include/linux/pci.h | 2 ++ 2 files changed, 40 insertions(+), 1 deletion(-)drivers/pci/pcie/portdrv_core.c +38
-1@@ -190,6 +190,31 @@ static int pcie_init_service_irqs(struct pci_dev *dev, int *irqs, int mask)return 0 ; } +/** +* pcie_init_platform_service_irqs - initialize platform service irqs for +* platform-specific System Errors +* @dev: PCI Express port to handle +* @irqs: Array of irqs to populate +* @mask: Bitmask of capabilities +* +* Return value: -ENODEV, in case no platform-specific IRQ is available +*/ +static int pcie_init_platform_service_irqs (struct pci_dev *dev, +int *irqs,int mask) +{ +struct pci_host_bridge *bridge; + +if (pci_pcie_type (dev) ==PCI_EXP_TYPE_ROOT_PORT ) { + bridge =pci_find_host_bridge (dev->bus); +if (bridge && bridge->init_platform_service_irqs) { +return bridge->init_platform_service_irqs (dev, irqs, + mask); + } + } + +return -ENODEV ; +} +/** * get_port_device_capability - discover capabilities of a PCI Express port * @dev: PCI Express port to examine @@ -335,7 +360,19 @@ int pcie_port_device_register(struct pci_dev *dev) irq_services |=PCIE_PORT_SERVICE_DPC ; irq_services &= capabilities; -if (irq_services) { +/* +* Some platforms have dedicated interrupts from root complex to +* interrupt controller for PCIe platform-specific System Errors +* like AER/PME etc., check if the platform registered with any such +* IRQ. +*/ + status =pcie_init_platform_service_irqs (dev, irqs, capabilities); + +/* +* Only install service irqs, when the platform-specific hook was +* unsuccessful +*/ +if (irq_services && status) {/* * Initialize service IRQs. Don't use service devices that * require interrupts if there is no way to generate them. include/linux/pci.h +2
-0@@ -554,6 +554,8 @@ struct pci_host_bridge {u8 (*swizzle_irq)(struct pci_dev *,u8 *);/* Platform IRQ swizzler */ int (*map_irq)(const struct pci_dev *,u8 ,u8 );void (*release_fn)(struct pci_host_bridge *); +int (*init_platform_service_irqs)(struct pci_dev *dev,int *irqs, +int plat_mask);void *release_data; unsigned int ignore_reset_delay:1; /* For entire hierarchy */ unsigned int no_ext_tags:1; /* No Extended Tags */Signature · 1 line
2.34.1
Re: [PATCH v4 1/2] PCI/portdrv: Add option to setup IRQs for platform-specific Service Errors
In reply to Stefan RoeseIn subject line, I assume you mean "System Errors" instead of "Service Errors"?
Quoted 5 lines · Stefan Roese
From: Bharat Kumar Gogada <[email protected]>
As per section 6.2.4.1.2, 6.2.6 in PCIe r4.0 (and later versions), platform-specific System Errors like AER can be delivered via platform- specific interrupt lines.
IIUC, this refers to the top left branch in Figure 6-3 of PCIe r6.0, sec 6.2.6, which shows "System Error (platform specific)" controlled by "System Error Enables (one per error class) in the Root Control register," i.e., the PCI_EXP_RTCTL_SECEE, PCI_EXP_RTCTL_SENFEE, and PCI_EXP_RTCTL_SEFEE bits.
Where are those enable bits set? The only references I see are to them being cleared via SYSTEM_ERROR_INTR_ON_MESG_MASK in aer_enable_rootport().
Quoted 24 lines
This patch adds the
init_platform_service_irqs()hook to structpci_host_bridge, making it possible that platforms may implement this function to hook IRQs for these platform-specific System Errors, like AER.If these platform-specific service IRQs have been successfully installed via
pcie_init_platform_service_irqs(),pcie_init_service_irqs()is skipped.Signed-off-by Bharat Kumar Gogada <[email protected]>Signed-off-by Stefan Roese <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Pali Rohár <[email protected]>Cc Michal Simek <[email protected]>--- drivers/pci/pcie/portdrv_core.c | 39 ++++++++++++++++++++++++++++++++- include/linux/pci.h | 2 ++ 2 files changed, 40 insertions(+), 1 deletion(-)drivers/pci/pcie/portdrv_core.c +0
-0
drivers/pci/pcie/portdrv_core.c static int pcie_init_service_irqs(struct pci_dev *dev, int *irqs, int mask) · line 198
Quoted 9 lines
drivers/pci/pcie/portdrv_core.c +6
-0@@ -190,6 +190,31 @@ static int pcie_init_service_irqs(struct pci_dev *dev, int *irqs, int mask)return 0 ; } +/** +* pcie_init_platform_service_irqs - initialize platform service irqs for +* platform-specific System Errors +* @dev: PCI Express port to handle +* @irqs: Array of irqs to populate +* @mask: Bitmask of capabilities
s/irqs/IRQs/ above (twice) for consistency.
Quoted 22 lines
drivers/pci/pcie/portdrv_core.c +18
-0+* Return value: -ENODEV, in case no platform-specific IRQ is available +*/ +static int pcie_init_platform_service_irqs (struct pci_dev *dev, +int *irqs,int mask) +{ +struct pci_host_bridge *bridge; + +if (pci_pcie_type (dev) ==PCI_EXP_TYPE_ROOT_PORT ) { + bridge =pci_find_host_bridge (dev->bus); +if (bridge && bridge->init_platform_service_irqs) { +return bridge->init_platform_service_irqs (dev, irqs, + mask); + } + } + +return -ENODEV ; +} +/** * get_port_device_capability - discover capabilities of a PCI Express port * @dev: PCI Express port to examine
drivers/pci/pcie/portdrv_core.c int pcie_port_device_register(struct pci_dev *dev) · line 367
Quoted 9 lines
drivers/pci/pcie/portdrv_core.c +5
-1@@ -335,7 +360,19 @@ int pcie_port_device_register(struct pci_dev *dev) irq_services |=PCIE_PORT_SERVICE_DPC ; irq_services &= capabilities; -if (irq_services) { +/* +* Some platforms have dedicated interrupts from root complex to +* interrupt controller for PCIe platform-specific System Errors +* like AER/PME etc., check if the platform registered with any such +* IRQ.
I don't see "PME etc" mentioned in the spec sections you cite. 6.2.4.1.2 and 6.2.6 only cover interrupts in response to error Messages. Are there other sections that cover PME and whatever other interrupts you have in mind?
6.7.3.4 ("Software Notification of Hot-Plug Events") talks about PME and Hot-Plug Event interrupts, but these aren't errors, and I only see signaling via INTx, MSI, or MSI-X. Is there provision for a different method?
drivers/pci/pcie/portdrv_core.c int pcie_port_device_register(struct pci_dev *dev) · line 373
Quoted 6 lines
drivers/pci/pcie/portdrv_core.c +6
-0+*/ + status =pcie_init_platform_service_irqs (dev, irqs, capabilities); + +/* +* Only install service irqs, when the platform-specific hook was +* unsuccessful
s/irqs/IRQs/ again.
Quoted 21 lines
drivers/pci/pcie/portdrv_core.c +2
-0+*/ +if (irq_services && status) {/* * Initialize service IRQs. Don't use service devices that * require interrupts if there is no way to generate them. include/linux/pci.h +2
-0@@ -554,6 +554,8 @@ struct pci_host_bridge {u8 (*swizzle_irq)(struct pci_dev *,u8 *);/* Platform IRQ swizzler */ int (*map_irq)(const struct pci_dev *,u8 ,u8 );void (*release_fn)(struct pci_host_bridge *); +int (*init_platform_service_irqs)(struct pci_dev *dev,int *irqs, +int plat_mask);void *release_data; unsigned int ignore_reset_delay:1; /* For entire hierarchy */ unsigned int no_ext_tags:1; /* No Extended Tags */Signature · 1 line
2.34.1
Re: [PATCH v4 1/2] PCI/portdrv: Add option to setup IRQs for platform-specific Service Errors
Quoted 2 lines · Bjorn Helgaas
In subject line, I assume you mean "System Errors" instead of "Service Errors"?
Background: I took over submitting this patchset from Bharat. Here his last revision:
https://www.spinics.net/lists/kernel/msg2960164.html
Just to explain, that I didn't choose the naming.
To answer your question I personally think too, that "System Errors" is more appropriate than "Service Errors". But still this patchset replaces or better enhances the already present pcie_init_service_irqs() by a platform-specific version. I can only suspect, that this is the reasoning for this "Service" naming.
Quoted 13 lines · Stefan Roese
Quoted 5 lines
From: Bharat Kumar Gogada <[email protected]>
As per section 6.2.4.1.2, 6.2.6 in PCIe r4.0 (and later versions), platform-specific System Errors like AER can be delivered via platform- specific interrupt lines.
IIUC, this refers to the top left branch in Figure 6-3 of PCIe r6.0, sec 6.2.6, which shows "System Error (platform specific)" controlled by "System Error Enables (one per error class) in the Root Control register," i.e., the
PCI_EXP_RTCTL_SECEE,PCI_EXP_RTCTL_SENFEE, andPCI_EXP_RTCTL_SEFEEbits.
Quoted 3 lines
Where are those enable bits set? The only references I see are to them being cleared via
SYSTEM_ERROR_INTR_ON_MESG_MASKinaer_enable_rootport().
Interesting, thanks. Again, I didn't write the original commit text, so my comments are a bit "limited" here. Perhaps Bharat might have something add here?
Quoted 27 lines
Quoted 27 lines
This patch adds the
init_platform_service_irqs()hook to structpci_host_bridge, making it possible that platforms may implement this function to hook IRQs for these platform-specific System Errors, like AER.If these platform-specific service IRQs have been successfully installed via
pcie_init_platform_service_irqs(),pcie_init_service_irqs()is skipped.Signed-off-by Bharat Kumar Gogada <[email protected]>Signed-off-by Stefan Roese <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Pali Rohár <[email protected]>Cc Michal Simek <[email protected]>--- drivers/pci/pcie/portdrv_core.c | 39 ++++++++++++++++++++++++++++++++- include/linux/pci.h | 2 ++ 2 files changed, 40 insertions(+), 1 deletion(-)drivers/pci/pcie/portdrv_core.c +0
-0@@ -190,6 +190,31 @@ static int pcie_init_service_irqs(struct pci_dev *dev, int *irqs, int mask)return 0 ; }
Quoted 8 lines
drivers/pci/pcie/portdrv_core.c static int pcie_init_service_irqs(struct pci_dev *dev, int *irqs, int mask) · line 198
Quoted 6 lines
drivers/pci/pcie/portdrv_core.c +6
-0+/** +* pcie_init_platform_service_irqs - initialize platform service irqs for +* platform-specific System Errors +* @dev: PCI Express port to handle +* @irqs: Array of irqs to populate +* @mask: Bitmask of capabilities s/irqs/IRQs/ above (twice) for consistency.
Yes.
Quoted 25 lines
Quoted 25 lines
drivers/pci/pcie/portdrv_core.c +18
-0+* Return value: -ENODEV, in case no platform-specific IRQ is available +*/ +static int pcie_init_platform_service_irqs (struct pci_dev *dev, +int *irqs,int mask) +{ +struct pci_host_bridge *bridge; + +if (pci_pcie_type (dev) ==PCI_EXP_TYPE_ROOT_PORT ) { + bridge =pci_find_host_bridge (dev->bus); +if (bridge && bridge->init_platform_service_irqs) { +return bridge->init_platform_service_irqs (dev, irqs, + mask); + } + } + +return -ENODEV ; +} +/** * get_port_device_capability - discover capabilities of a PCI Express port * @dev: PCI Express port to examine @@ -335,7 +360,19 @@ int pcie_port_device_register(struct pci_dev *dev) irq_services |=PCIE_PORT_SERVICE_DPC ; irq_services &= capabilities;
Quoted 11 lines
drivers/pci/pcie/portdrv_core.c int pcie_port_device_register(struct pci_dev *dev) · line 367
Quoted 6 lines
drivers/pci/pcie/portdrv_core.c +5
-1-if (irq_services) { +/* +* Some platforms have dedicated interrupts from root complex to +* interrupt controller for PCIe platform-specific System Errors +* like AER/PME etc., check if the platform registered with any such +* IRQ. I don't see "PME etc" mentioned in the spec sections you cite. 6.2.4.1.2 and 6.2.6 only cover interrupts in response to error Messages. Are there other sections that cover PME and whatever other interrupts you have in mind?
Bharat?
Quoted 4 lines
6.7.3.4 ("Software Notification of Hot-Plug Events") talks about PME and Hot-Plug Event interrupts, but these aren't errors, and I only see signaling via INTx, MSI, or MSI-X. Is there provision for a different method?
Here the quote from Bharat's original cover letter:
"Some platforms have dedicated IRQ lines for PCIe services like AER/PME etc. The root complex on these platform will use these seperate IRQ lines to report AER/PME etc., interrupts and will not generate MSI/ MSI-X/INTx interrupts for these services.
These patches will add new method for these kind of platforms to register the platform IRQ number with respective PCIe services."
To sum it up, on our Xilinx ZynqMP platform this patch series is needed to deliver AER related interrupts. As this SoC needs this platform specific IRQ line for signalling of these events.
Quoted 8 lines
drivers/pci/pcie/portdrv_core.c int pcie_port_device_register(struct pci_dev *dev) · line 373
Quoted 6 lines
drivers/pci/pcie/portdrv_core.c +6
-0+*/ + status =pcie_init_platform_service_irqs (dev, irqs, capabilities); + +/* +* Only install service irqs, when the platform-specific hook was +* unsuccessful s/irqs/IRQs/ again.
Yes.
Thanks,
Stefan
Quoted 21 lines
Quoted 21 lines
drivers/pci/pcie/portdrv_core.c +2
-0+*/ +if (irq_services && status) {/* * Initialize service IRQs. Don't use service devices that * require interrupts if there is no way to generate them. include/linux/pci.h +2
-0@@ -554,6 +554,8 @@ struct pci_host_bridge {u8 (*swizzle_irq)(struct pci_dev *,u8 *);/* Platform IRQ swizzler */ int (*map_irq)(const struct pci_dev *,u8 ,u8 );void (*release_fn)(struct pci_host_bridge *); +int (*init_platform_service_irqs)(struct pci_dev *dev,int *irqs, +int plat_mask);void *release_data; unsigned int ignore_reset_delay:1; /* For entire hierarchy */ unsigned int no_ext_tags:1; /* No Extended Tags */Signature · 1 line
2.34.1
Re: [PATCH v4 1/2] PCI/portdrv: Add option to setup IRQs for platform-specific Service Errors
Quoted 8 lines · On Monday 30 May 2022 10:18:41 Stefan Roese wrote:
Quoted 2 lines · Bjorn Helgaas
In subject line, I assume you mean "System Errors" instead of "Service Errors"?
Background: I took over submitting this patchset from Bharat. Here his last revision:
https://www.spinics.net/lists/kernel/msg2960164.html
Quoted 7 lines
Just to explain, that I didn't choose the naming.
To answer your question I personally think too, that "System Errors" is more appropriate than "Service Errors". But still this patchset replaces or better enhances the already present
pcie_init_service_irqs()by a platform-specific version. I can only suspect, that this is the reasoning for this "Service" naming.
Hello! Based on the below text "Here the quote from Bharat's original cover letter:" I think that the better naming should be: "Service interrupts". Because it adds support for interrupts from PCIe services like AER, PME or HP. Only AER are errors, other IRQs are just services.
Quoted 101 lines
Quoted 13 lines · Stefan Roese
Quoted 5 lines
From: Bharat Kumar Gogada <[email protected]>
As per section 6.2.4.1.2, 6.2.6 in PCIe r4.0 (and later versions), platform-specific System Errors like AER can be delivered via platform- specific interrupt lines.
IIUC, this refers to the top left branch in Figure 6-3 of PCIe r6.0, sec 6.2.6, which shows "System Error (platform specific)" controlled by "System Error Enables (one per error class) in the Root Control register," i.e., the
PCI_EXP_RTCTL_SECEE,PCI_EXP_RTCTL_SENFEE, andPCI_EXP_RTCTL_SEFEEbits.Quoted 3 lines
Where are those enable bits set? The only references I see are to them being cleared via
SYSTEM_ERROR_INTR_ON_MESG_MASKinaer_enable_rootport().Interesting, thanks. Again, I didn't write the original commit text, so my comments are a bit "limited" here. Perhaps Bharat might have something add here?
Quoted 19 lines
Quoted 19 lines
This patch adds the
init_platform_service_irqs()hook to structpci_host_bridge, making it possible that platforms may implement this function to hook IRQs for these platform-specific System Errors, like AER.If these platform-specific service IRQs have been successfully installed via
pcie_init_platform_service_irqs(),pcie_init_service_irqs()is skipped.Signed-off-by Bharat Kumar Gogada <[email protected]>Signed-off-by Stefan Roese <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Pali Rohár <[email protected]>Cc Michal Simek <[email protected]>--- drivers/pci/pcie/portdrv_core.c | 39 ++++++++++++++++++++++++++++++++- include/linux/pci.h | 2 ++ 2 files changed, 40 insertions(+), 1 deletion(-)Quoted 15 lines
drivers/pci/pcie/portdrv_core.c static int pcie_init_service_irqs(struct pci_dev *dev, int *irqs, int mask) · line 197
Quoted 13 lines
drivers/pci/pcie/portdrv_core.c +6
-0@@ -190,6 +190,31 @@ static int pcie_init_service_irqs(struct pci_dev *dev, int *irqs, int mask)return 0 ; } +/** +* pcie_init_platform_service_irqs - initialize platform service irqs for +* platform-specific System Errors +* @dev: PCI Express port to handle +* @irqs: Array of irqs to populate +* @mask: Bitmask of capabilities s/irqs/IRQs/ above (twice) for consistency.
Yes.
Quoted 27 lines
Quoted 27 lines
drivers/pci/pcie/portdrv_core.c +20
-1+* Return value: -ENODEV, in case no platform-specific IRQ is available +*/ +static int pcie_init_platform_service_irqs (struct pci_dev *dev, +int *irqs,int mask) +{ +struct pci_host_bridge *bridge; + +if (pci_pcie_type (dev) ==PCI_EXP_TYPE_ROOT_PORT ) { + bridge =pci_find_host_bridge (dev->bus); +if (bridge && bridge->init_platform_service_irqs) { +return bridge->init_platform_service_irqs (dev, irqs, + mask); + } + } + +return -ENODEV ; +} +/** * get_port_device_capability - discover capabilities of a PCI Express port * @dev: PCI Express port to examine @@ -335,7 +360,19 @@ int pcie_port_device_register(struct pci_dev *dev) irq_services |=PCIE_PORT_SERVICE_DPC ; irq_services &= capabilities; -if (irq_services) { +/* +* Some platforms have dedicated interrupts from root complex to Quoted 8 lines
drivers/pci/pcie/portdrv_core.c int pcie_port_device_register(struct pci_dev *dev) · line 367
Quoted 3 lines
drivers/pci/pcie/portdrv_core.c +3
-0+* interrupt controller for PCIe platform-specific System Errors +* like AER/PME etc., check if the platform registered with any such +* IRQ. I don't see "PME etc" mentioned in the spec sections you cite. 6.2.4.1.2 and 6.2.6 only cover interrupts in response to error Messages. Are there other sections that cover PME and whatever other interrupts you have in mind?
Bharat?
Quoted 4 lines
6.7.3.4 ("Software Notification of Hot-Plug Events") talks about PME and Hot-Plug Event interrupts, but these aren't errors, and I only see signaling via INTx, MSI, or MSI-X. Is there provision for a different method?
Quoted 5 lines
Here the quote from Bharat's original cover letter:
"Some platforms have dedicated IRQ lines for PCIe services like AER/PME etc. The root complex on these platform will use these seperate IRQ lines to report AER/PME etc., interrupts and will not generate MSI/ MSI-X/INTx interrupts for these services.
This is the best explanation of this change.
Quoted 42 lines
These patches will add new method for these kind of platforms to register the platform IRQ number with respective PCIe services."
To sum it up, on our Xilinx ZynqMP platform this patch series is needed to deliver AER related interrupts. As this SoC needs this platform specific IRQ line for signalling of these events.
Quoted 8 lines
drivers/pci/pcie/portdrv_core.c int pcie_port_device_register(struct pci_dev *dev) · line 373
Quoted 6 lines
drivers/pci/pcie/portdrv_core.c +6
-0+*/ + status =pcie_init_platform_service_irqs (dev, irqs, capabilities); + +/* +* Only install service irqs, when the platform-specific hook was +* unsuccessful s/irqs/IRQs/ again.
Yes.
Thanks,
StefanQuoted 21 lines
Quoted 21 lines
drivers/pci/pcie/portdrv_core.c +2
-0+*/ +if (irq_services && status) {/* * Initialize service IRQs. Don't use service devices that * require interrupts if there is no way to generate them. include/linux/pci.h +2
-0@@ -554,6 +554,8 @@ struct pci_host_bridge {u8 (*swizzle_irq)(struct pci_dev *,u8 *);/* Platform IRQ swizzler */ int (*map_irq)(const struct pci_dev *,u8 ,u8 );void (*release_fn)(struct pci_host_bridge *); +int (*init_platform_service_irqs)(struct pci_dev *dev,int *irqs, +int plat_mask);void *release_data; unsigned int ignore_reset_delay:1; /* For entire hierarchy */ unsigned int no_ext_tags:1; /* No Extended Tags */Signature · 1 line
2.34.1
Re: [PATCH v4 1/2] PCI/portdrv: Add option to setup IRQs for platform-specific Service Errors
Quoted 8 lines · Pali Rohár
Quoted 7 lines · On Monday 30 May 2022 10:18:41 Stefan Roese wrote:
Quoted 2 lines · Bjorn Helgaas
In subject line, I assume you mean "System Errors" instead of "Service Errors"?
Background: I took over submitting this patchset from Bharat. Here his last revision:
https://www.spinics.net/lists/kernel/msg2960164.html
Here's the link to the more usable lore archive:
https://lore.kernel.org/all/[email protected]/
Quoted 10 lines
Quoted 5 lines
To answer your question I personally think too, that "System Errors" is more appropriate than "Service Errors". But still this patchset replaces or better enhances the already present
pcie_init_service_irqs()by a platform-specific version. I can only suspect, that this is the reasoning for this "Service" naming.Hello! Based on the below text "Here the quote from Bharat's original cover letter:" I think that the better naming should be: "Service interrupts". Because it adds support for interrupts from PCIe services like AER, PME or HP. Only AER are errors, other IRQs are just services.
The question I'm trying to answer is whether this series concerns the "System Error" mechanism or the "Error Interrupt" mechanism. We should figure out which one this is and use the correct name.
The sec 6.2.4.1.2 cited below clearly refers to the AER Root Error Command register, which controls interrupt generation via INTx, MSI, or MSI-X, i.e., the standard "Error Interrupt" shown on the RIGHT side of Figure 6-3 in sec 6.2.6.
The "System Error" signaling on the LEFT side of Figure 6-3 would be controlled by the Root Control register in the PCIe capability.
It should be easy to use setpci to set/clear these two sets of enable bits and figure out which path is of interest here.
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines · Stefan Roese
Quoted 5 lines
From: Bharat Kumar Gogada <[email protected]>
As per section 6.2.4.1.2, 6.2.6 in PCIe r4.0 (and later versions), platform-specific System Errors like AER can be delivered via platform- specific interrupt lines.
...
6.7.3.4 ("Software Notification of Hot-Plug Events") talks about PME and Hot-Plug Event interrupts, but these aren't errors, and I only see signaling via INTx, MSI, or MSI-X. Is there provision for a different method?
Quoted 7 lines
Quoted 5 lines
Here the quote from Bharat's original cover letter:
"Some platforms have dedicated IRQ lines for PCIe services like AER/PME etc. The root complex on these platform will use these seperate IRQ lines to report AER/PME etc., interrupts and will not generate MSI/ MSI-X/INTx interrupts for these services.This is the best explanation of this change.
As far as I can tell, "dedicated IRQ lines for services like AER/PME etc" would violate the PCIe spec. That's OK, we can work around that sort of thing, but it needs to be clearly called out as some kind of quirk and not mixed in with things like System Error signaling, which is allowed to be platform-specific.
Bjorn
Re: [PATCH v4 1/2] PCI/portdrv: Add option to setup IRQs for platform-specific Service Errors
Quoted 19 lines · On Tuesday 31 May 2022 16:31:58 Bjorn Helgaas wrote:
Quoted 8 lines · Pali Rohár
Quoted 7 lines · On Monday 30 May 2022 10:18:41 Stefan Roese wrote:
Quoted 2 lines · Bjorn Helgaas
In subject line, I assume you mean "System Errors" instead of "Service Errors"?
Background: I took over submitting this patchset from Bharat. Here his last revision:
https://www.spinics.net/lists/kernel/msg2960164.htmlHere's the link to the more usable lore archive:
https://lore.kernel.org/all/[email protected]/Quoted 6 lines
Quoted 5 lines
To answer your question I personally think too, that "System Errors" is more appropriate than "Service Errors". But still this patchset replaces or better enhances the already present
pcie_init_service_irqs()by a platform-specific version. I can only suspect, that this is the reasoning for this "Service" naming.
Quoted 8 lines
Quoted 4 lines
Hello! Based on the below text "Here the quote from Bharat's original cover letter:" I think that the better naming should be: "Service interrupts". Because it adds support for interrupts from PCIe services like AER, PME or HP. Only AER are errors, other IRQs are just services.
The question I'm trying to answer is whether this series concerns the "System Error" mechanism or the "Error Interrupt" mechanism. We should figure out which one this is and use the correct name.
My understanding is that neither "System Error", nor "Error Interrupt". But patch series is about "dedicated IRQ lines for services". One of PCIe service is AER, which is one of the mostly used PCIe service in kernel and therefore it is the root of confusions with keyword "error".
Quoted 30 lines
The sec 6.2.4.1.2 cited below clearly refers to the AER Root Error Command register, which controls interrupt generation via INTx, MSI, or MSI-X, i.e., the standard "Error Interrupt" shown on the RIGHT side of Figure 6-3 in sec 6.2.6.
The "System Error" signaling on the LEFT side of Figure 6-3 would be controlled by the Root Control register in the PCIe capability.
It should be easy to use setpci to set/clear these two sets of enable bits and figure out which path is of interest here.
Quoted 19 lines
Quoted 18 lines
Quoted 7 lines · Stefan Roese
Quoted 5 lines
From: Bharat Kumar Gogada <[email protected]>
As per section 6.2.4.1.2, 6.2.6 in PCIe r4.0 (and later versions), platform-specific System Errors like AER can be delivered via platform- specific interrupt lines.
Quoted 5 lines
...
6.7.3.4 ("Software Notification of Hot-Plug Events") talks about PME and Hot-Plug Event interrupts, but these aren't errors, and I only see signaling via INTx, MSI, or MSI-X. Is there provision for a different method?Here the quote from Bharat's original cover letter:
"Some platforms have dedicated IRQ lines for PCIe services like AER/PME etc. The root complex on these platform will use these seperate IRQ lines to report AER/PME etc., interrupts and will not generate MSI/ MSI-X/INTx interrupts for these services.
Quoted 4 lines
Quoted 1 line
This is the best explanation of this change.
As far as I can tell, "dedicated IRQ lines for services like AER/PME etc" would violate the PCIe spec.
I think too, that this does not conform to PCIe spec.
Quoted 6 lines
That's OK, we can work around that
sort of thing, but it needs to be clearly called out as some kind of quirk and not mixed in with things like System Error signaling, which is allowed to be platform-specific.Bjorn
I agree.
Re: [PATCH v4 1/2] PCI/portdrv: Add option to setup IRQs for platform-specific Service Errors
In reply to Bjorn HelgaasQuoted 28 lines · Bjorn Helgaas
Quoted 8 lines · Pali Rohár
Quoted 7 lines · On Monday 30 May 2022 10:18:41 Stefan Roese wrote:
Quoted 2 lines · Bjorn Helgaas
In subject line, I assume you mean "System Errors" instead of "Service Errors"?
Background: I took over submitting this patchset from Bharat. Here his last revision:
https://www.spinics.net/lists/kernel/msg2960164.htmlHere's the link to the more usable lore archive:
https://lore.kernel.org/all/[email protected]/Quoted 10 lines
Quoted 5 lines
To answer your question I personally think too, that "System Errors" is more appropriate than "Service Errors". But still this patchset replaces or better enhances the already present
pcie_init_service_irqs()by a platform-specific version. I can only suspect, that this is the reasoning for this "Service" naming.Hello! Based on the below text "Here the quote from Bharat's original cover letter:" I think that the better naming should be: "Service interrupts". Because it adds support for interrupts from PCIe services like AER, PME or HP. Only AER are errors, other IRQs are just services.
The question I'm trying to answer is whether this series concerns the "System Error" mechanism or the "Error Interrupt" mechanism. We should figure out which one this is and use the correct name.
Quoted 7 lines
The sec 6.2.4.1.2 cited below clearly refers to the AER Root Error Command register, which controls interrupt generation via INTx, MSI, or MSI-X, i.e., the standard "Error Interrupt" shown on the RIGHT side of Figure 6-3 in sec 6.2.6.
The "System Error" signaling on the LEFT side of Figure 6-3 would be controlled by the Root Control register in the PCIe capability.
"System Error" is probably incorrect. You've already stated, that these error bits are generally disabled in the PCI_EXP_RTCTL reg in aer_enable_rootport():
/* Disable system error generation in response to error messages */ pcie_capability_clear_word(pdev, PCI_EXP_RTCTL, SYSTEM_ERROR_INTR_ON_MESG_MASK);
This leaves "Error Interrupt", but I might be wrong here.
Quoted 2 lines
It should be easy to use setpci to set/clear these two sets of enable bits and figure out which path is of interest here.
Here the value of the PCI_EXP_RTCTL register at runtime:
# setpci -v -s 00:00.0 CAP_EXP+0x1c.w 0000:00:00.0 (cap 10 @60) @7c = 0010
So all "System Error" enable bits are disabled.
Please let me know if I should make some other "setpci" tests.
Quoted 19 lines
Quoted 19 lines
Quoted 18 lines
Quoted 7 lines · Stefan Roese
Quoted 5 lines
From: Bharat Kumar Gogada <[email protected]>
As per section 6.2.4.1.2, 6.2.6 in PCIe r4.0 (and later versions), platform-specific System Errors like AER can be delivered via platform- specific interrupt lines.
Quoted 5 lines
...
6.7.3.4 ("Software Notification of Hot-Plug Events") talks about PME and Hot-Plug Event interrupts, but these aren't errors, and I only see signaling via INTx, MSI, or MSI-X. Is there provision for a different method?Here the quote from Bharat's original cover letter:
"Some platforms have dedicated IRQ lines for PCIe services like AER/PME etc. The root complex on these platform will use these seperate IRQ lines to report AER/PME etc., interrupts and will not generate MSI/ MSI-X/INTx interrupts for these services.
Quoted 4 lines
Quoted 1 line
This is the best explanation of this change.
As far as I can tell, "dedicated IRQ lines for services like AER/PME etc" would violate the PCIe spec.
AFAICT this is the case here.
Quoted 4 lines
That's OK, we can work around that
sort of thing, but it needs to be clearly called out as some kind of quirk and not mixed in with things like System Error signaling, which is allowed to be platform-specific.
Agreed. So how to process with this patchset? Should I reword the patch subject line (and the commit text and comments) to something like:
Add option to setup IRQs for platform-specific Error Interrupt ?
Thanks,
Stefan
Re: [PATCH v4 1/2] PCI/portdrv: Add option to setup IRQs for platform-specific Service Errors
Quoted 89 lines · On Wednesday 01 June 2022 13:47:12 Stefan Roese wrote:
Quoted 28 lines · Bjorn Helgaas
Quoted 8 lines · Pali Rohár
Quoted 7 lines · On Monday 30 May 2022 10:18:41 Stefan Roese wrote:
Quoted 2 lines · Bjorn Helgaas
In subject line, I assume you mean "System Errors" instead of "Service Errors"?
Background: I took over submitting this patchset from Bharat. Here his last revision:
https://www.spinics.net/lists/kernel/msg2960164.htmlHere's the link to the more usable lore archive:
https://lore.kernel.org/all/[email protected]/Quoted 10 lines
Quoted 5 lines
To answer your question I personally think too, that "System Errors" is more appropriate than "Service Errors". But still this patchset replaces or better enhances the already present
pcie_init_service_irqs()by a platform-specific version. I can only suspect, that this is the reasoning for this "Service" naming.Hello! Based on the below text "Here the quote from Bharat's original cover letter:" I think that the better naming should be: "Service interrupts". Because it adds support for interrupts from PCIe services like AER, PME or HP. Only AER are errors, other IRQs are just services.
The question I'm trying to answer is whether this series concerns the "System Error" mechanism or the "Error Interrupt" mechanism. We should figure out which one this is and use the correct name.
Quoted 7 lines
The sec 6.2.4.1.2 cited below clearly refers to the AER Root Error Command register, which controls interrupt generation via INTx, MSI, or MSI-X, i.e., the standard "Error Interrupt" shown on the RIGHT side of Figure 6-3 in sec 6.2.6.
The "System Error" signaling on the LEFT side of Figure 6-3 would be controlled by the Root Control register in the PCIe capability.
"System Error" is probably incorrect. You've already stated, that these error bits are generally disabled in the
PCI_EXP_RTCTLreg inaer_enable_rootport():/* Disable system error generation in response to error messages */ pcie_capability_clear_word(pdev, PCI_EXP_RTCTL, SYSTEM_ERROR_INTR_ON_MESG_MASK);This leaves "Error Interrupt", but I might be wrong here.
Quoted 2 lines
It should be easy to use setpci to set/clear these two sets of enable bits and figure out which path is of interest here.
Here the value of the
PCI_EXP_RTCTLregister at runtime:# setpci -v -s 00:00.0 CAP_EXP+0x1c.w 0000:00:00.0 (cap 10 @60) @7c = 0010So all "System Error" enable bits are disabled.
Please let me know if I should make some other "setpci" tests.
Quoted 19 lines
Quoted 19 lines
Quoted 18 lines
Quoted 7 lines · Stefan Roese
Quoted 5 lines
From: Bharat Kumar Gogada <[email protected]>
As per section 6.2.4.1.2, 6.2.6 in PCIe r4.0 (and later versions), platform-specific System Errors like AER can be delivered via platform- specific interrupt lines.
Quoted 5 lines
...
6.7.3.4 ("Software Notification of Hot-Plug Events") talks about PME and Hot-Plug Event interrupts, but these aren't errors, and I only see signaling via INTx, MSI, or MSI-X. Is there provision for a different method?Here the quote from Bharat's original cover letter:
"Some platforms have dedicated IRQ lines for PCIe services like AER/PME etc. The root complex on these platform will use these seperate IRQ lines to report AER/PME etc., interrupts and will not generate MSI/ MSI-X/INTx interrupts for these services.Quoted 4 lines
Quoted 1 line
This is the best explanation of this change.
As far as I can tell, "dedicated IRQ lines for services like AER/PME etc" would violate the PCIe spec.
AFAICT this is the case here.
Quoted 4 lines
That's OK, we can work around that
sort of thing, but it needs to be clearly called out as some kind of quirk and not mixed in with things like System Error signaling, which is allowed to be platform-specific.
Quoted 7 lines
Agreed. So how to process with this patchset? Should I reword the patch subject line (and the commit text and comments) to something like:
Add option to setup IRQs for platform-specific Error Interrupt ?
Thanks,
Stefan
I think it should be named "Service Interrupt" or something like that as it is bound only to _errors_ but to any platform-specific interrupt.
Re: [PATCH v4 1/2] PCI/portdrv: Add option to setup IRQs for platform-specific Service Errors
In reply to Stefan RoeseQuoted 50 lines · Stefan Roese
Quoted 28 lines · Bjorn Helgaas
Quoted 8 lines · Pali Rohár
Quoted 7 lines · On Monday 30 May 2022 10:18:41 Stefan Roese wrote:
Quoted 2 lines · Bjorn Helgaas
In subject line, I assume you mean "System Errors" instead of "Service Errors"?
Background: I took over submitting this patchset from Bharat. Here his last revision:
https://www.spinics.net/lists/kernel/msg2960164.htmlHere's the link to the more usable lore archive:
https://lore.kernel.org/all/[email protected]/Quoted 10 lines
Quoted 5 lines
To answer your question I personally think too, that "System Errors" is more appropriate than "Service Errors". But still this patchset replaces or better enhances the already present
pcie_init_service_irqs()by a platform-specific version. I can only suspect, that this is the reasoning for this "Service" naming.Hello! Based on the below text "Here the quote from Bharat's original cover letter:" I think that the better naming should be: "Service interrupts". Because it adds support for interrupts from PCIe services like AER, PME or HP. Only AER are errors, other IRQs are just services.
The question I'm trying to answer is whether this series concerns the "System Error" mechanism or the "Error Interrupt" mechanism. We should figure out which one this is and use the correct name.
Quoted 7 lines
The sec 6.2.4.1.2 cited below clearly refers to the AER Root Error Command register, which controls interrupt generation via INTx, MSI, or MSI-X, i.e., the standard "Error Interrupt" shown on the RIGHT side of Figure 6-3 in sec 6.2.6.
The "System Error" signaling on the LEFT side of Figure 6-3 would be controlled by the Root Control register in the PCIe capability.
"System Error" is probably incorrect. You've already stated, that these error bits are generally disabled in the
PCI_EXP_RTCTLreg inaer_enable_rootport():/* Disable system error generation in response to error messages */ pcie_capability_clear_word(pdev, PCI_EXP_RTCTL, SYSTEM_ERROR_INTR_ON_MESG_MASK);This leaves "Error Interrupt", but I might be wrong here.
Quoted 2 lines
It should be easy to use setpci to set/clear these two sets of enable bits and figure out which path is of interest here.
Quoted 7 lines
Here the value of the
PCI_EXP_RTCTLregister at runtime:# setpci -v -s 00:00.0 CAP_EXP+0x1c.w 0000:00:00.0 (cap 10 @60) @7c = 0010So all "System Error" enable bits are disabled.
Please let me know if I should make some other "setpci" tests.
I assume you have verified that neither PCI_EXP_RTCTL nor PCI_ERR_ROOT_COMMAND controls these interrupts. (I guess it's possible that PCI_ERR_ROOT_COR/UNCOR_RCV might be ANDed with the platform bits, but I think there are other potential interrupt sources, too.)
So I think we need a description that is clearly not related to the PCIe spec terminology, e.g., "platform-specific PCIe interrupts".
Quoted 31 lines
Quoted 19 lines
Quoted 19 lines
Quoted 18 lines
Quoted 7 lines · Stefan Roese
Quoted 5 lines
From: Bharat Kumar Gogada <[email protected]>
As per section 6.2.4.1.2, 6.2.6 in PCIe r4.0 (and later versions), platform-specific System Errors like AER can be delivered via platform- specific interrupt lines.
Quoted 5 lines
...
6.7.3.4 ("Software Notification of Hot-Plug Events") talks about PME and Hot-Plug Event interrupts, but these aren't errors, and I only see signaling via INTx, MSI, or MSI-X. Is there provision for a different method?Here the quote from Bharat's original cover letter:
"Some platforms have dedicated IRQ lines for PCIe services like AER/PME etc. The root complex on these platform will use these seperate IRQ lines to report AER/PME etc., interrupts and will not generate MSI/ MSI-X/INTx interrupts for these services.Quoted 4 lines
Quoted 1 line
This is the best explanation of this change.
As far as I can tell, "dedicated IRQ lines for services like AER/PME etc" would violate the PCIe spec.
AFAICT this is the case here.
Quoted 4 lines
That's OK, we can work around that
sort of thing, but it needs to be clearly called out as some kind of quirk and not mixed in with things like System Error signaling, which is allowed to be platform-specific.
Quoted 4 lines
Agreed. So how to process with this patchset? Should I reword the patch subject line (and the commit text and comments) to something like:
Add option to setup IRQs for platform-specific Error Interrupt ?
Yes. But "Error Interrupt" should not be capitalized because that implies a proper noun defined by the PCIe spec. And I thought there were potentially non-error interrupts coming, too.
PATCH v4 2/2 PCI: xilinx-nwl: Add method to init_platform_service_irqs hook
In reply to Stefan RoeseFrom: Bharat Kumar Gogada <[email protected]>
Add nwl_init_platform_service_irqs() hook to init_platform_service_irqs to register the platform-specific Service Errors IRQs for this PCIe controller to fully support e.g. AER on this platform.
--- drivers/pci/controller/pcie-xilinx-nwl.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
drivers/pci/controller/pcie-xilinx-nwl.c +18 -0
@@ -24,6 +24,7 @@#include <linux/irqchip/chained_irq.h> #include "../pci.h" +#include "../pcie/portdrv.h" /* Bridge core config registers */ #define BRCFG_PCIE_RX0 0x00000000
@@ -806,6 +807,22 @@ static int nwl_pcie_parse_dt(struct nwl_pcie *pcie,return 0 ; } +static int nwl_init_platform_service_irqs (struct pci_dev *dev,int *irqs, +int plat_mask) +{ +struct pci_host_bridge *bridge; +struct nwl_pcie *pcie; + + bridge =pci_find_host_bridge (dev->bus); + pcie =pci_host_bridge_priv (bridge); +if (plat_mask &PCIE_PORT_SERVICE_AER ) { + irqs[PCIE_PORT_SERVICE_AER_SHIFT ] = pcie->irq_misc; +return 0 ;/* platform-specific service IRQ installed */ + } + +return -ENODEV ;/* platform-specific service IRQ not installed */ +} +static const struct of_device_id nwl_pcie_of_match[] = { { .compatible ="xlnx,nwl-pcie-2.11" , }, {}
@@ -857,6 +874,7 @@ static int nwl_pcie_probe(struct platform_device *pdev) bridge->sysdata = pcie; bridge->ops = &nwl_pcie_ops; + bridge->init_platform_service_irqs = nwl_init_platform_service_irqs;if (IS_ENABLED (CONFIG_PCI_MSI )) { err =nwl_pcie_enable_msi (pcie);
Signature · 1 line
2.34.1
Re: [PATCH v4 2/2] PCI: xilinx-nwl: Add method to init_platform_service_irqs hook
Quoted 11 lines · On Friday 14 January 2022 08:58:34 Stefan Roese wrote:
From: Bharat Kumar Gogada <[email protected]>
Add
nwl_init_platform_service_irqs()hook toinit_platform_service_irqsto register the platform-specific Service Errors IRQs for this PCIe controller to fully support e.g. AER on this platform.Signed-off-by Bharat Kumar Gogada <[email protected]>Signed-off-by Stefan Roese <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Pali Rohár <[email protected]>Cc Michal Simek <[email protected]>
Quoted 22 lines
--- drivers/pci/controller/pcie-xilinx-nwl.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)drivers/pci/controller/pcie-xilinx-nwl.c +3
-0@@ -24,6 +24,7 @@#include <linux/irqchip/chained_irq.h> #include "../pci.h" +#include "../pcie/portdrv.h" /* Bridge core config registers */ #define BRCFG_PCIE_RX0 0x00000000@@ -806,6 +807,22 @@ static int nwl_pcie_parse_dt(struct nwl_pcie *pcie,return 0 ; } +static int nwl_init_platform_service_irqs (struct pci_dev *dev,int *irqs, +int plat_mask)
drivers/pci/controller/pcie-xilinx-nwl.c static int nwl_pcie_parse_dt(struct nwl_pcie *pcie, · line 821
Quoted 10 lines
drivers/pci/controller/pcie-xilinx-nwl.c +10
-0+{ +struct pci_host_bridge *bridge; +struct nwl_pcie *pcie; + + bridge =pci_find_host_bridge (dev->bus); + pcie =pci_host_bridge_priv (bridge); +if (plat_mask &PCIE_PORT_SERVICE_AER ) { + irqs[PCIE_PORT_SERVICE_AER_SHIFT ] = pcie->irq_misc; +return 0 ;/* platform-specific service IRQ installed */ + }
Just I want to be sure, with this change PME and HP interrupts are not provided even when plat_mask argument contains them.
Quoted 18 lines
drivers/pci/controller/pcie-xilinx-nwl.c +5
-0+ +return -ENODEV ;/* platform-specific service IRQ not installed */ +} +static const struct of_device_id nwl_pcie_of_match[] = { { .compatible ="xlnx,nwl-pcie-2.11" , }, {}@@ -857,6 +874,7 @@ static int nwl_pcie_probe(struct platform_device *pdev) bridge->sysdata = pcie; bridge->ops = &nwl_pcie_ops; + bridge->init_platform_service_irqs = nwl_init_platform_service_irqs;if (IS_ENABLED (CONFIG_PCI_MSI )) { err =nwl_pcie_enable_msi (pcie);Signature · 1 line
2.34.1
Re: [PATCH v4 2/2] PCI: xilinx-nwl: Add method to init_platform_service_irqs hook
Quoted 35 lines · Pali Rohár
Quoted 11 lines · On Friday 14 January 2022 08:58:34 Stefan Roese wrote:
From: Bharat Kumar Gogada <[email protected]>
Add
nwl_init_platform_service_irqs()hook toinit_platform_service_irqsto register the platform-specific Service Errors IRQs for this PCIe controller to fully support e.g. AER on this platform.Signed-off-by Bharat Kumar Gogada <[email protected]>Signed-off-by Stefan Roese <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Pali Rohár <[email protected]>Cc Michal Simek <[email protected]>Reviewed-by Pali Rohár <[email protected]>Quoted 20 lines
--- drivers/pci/controller/pcie-xilinx-nwl.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)drivers/pci/controller/pcie-xilinx-nwl.c +1
-0@@ -24,6 +24,7 @@#include <linux/irqchip/chained_irq.h> #include "../pci.h" +#include "../pcie/portdrv.h" /* Bridge core config registers */ #define BRCFG_PCIE_RX0 0x00000000@@ -806,6 +807,22 @@ static int nwl_pcie_parse_dt(struct nwl_pcie *pcie,return 0 ; }
Quoted 15 lines
drivers/pci/controller/pcie-xilinx-nwl.c static int nwl_pcie_parse_dt(struct nwl_pcie *pcie, · line 821
Quoted 12 lines
drivers/pci/controller/pcie-xilinx-nwl.c +12
-0+static int nwl_init_platform_service_irqs (struct pci_dev *dev,int *irqs, +int plat_mask) +{ +struct pci_host_bridge *bridge; +struct nwl_pcie *pcie; + + bridge =pci_find_host_bridge (dev->bus); + pcie =pci_host_bridge_priv (bridge); +if (plat_mask &PCIE_PORT_SERVICE_AER ) { + irqs[PCIE_PORT_SERVICE_AER_SHIFT ] = pcie->irq_misc; +return 0 ;/* platform-specific service IRQ installed */ + }Just I want to be sure, with this change PME and HP interrupts are not provided even when
plat_maskargument contains them.
This function is only used for Root Ports. E.g. HP at the downstream ports of the PCIe switch still works in our case, as here pcie_init_service_irqs() still gets called:
# cat /proc/interrupts | grep pci 44: 0 0 0 0 GICv2 150 Level nwl_pcie:misc, aerdrv 61: 2 0 0 0 nwl_pcie:msi 1064960 Edge pciehp 63: 0 0 0 0 nwl_pcie:msi 1081344 Edge pciehp 65: 4 0 0 0 nwl_pcie:msi 1097728 Edge pciehp
Thanks,
Stefan
Quoted 13 lines
Quoted 13 lines
drivers/pci/controller/pcie-xilinx-nwl.c +5
-0+ +return -ENODEV ;/* platform-specific service IRQ not installed */ +} +static const struct of_device_id nwl_pcie_of_match[] = { { .compatible ="xlnx,nwl-pcie-2.11" , }, {}@@ -857,6 +874,7 @@ static int nwl_pcie_probe(struct platform_device *pdev) bridge->sysdata = pcie; bridge->ops = &nwl_pcie_ops; + bridge->init_platform_service_irqs = nwl_init_platform_service_irqs;
Quoted 5 lines
Quoted 5 lines
drivers/pci/controller/pcie-xilinx-nwl.c +0
-0if (IS_ENABLED (CONFIG_PCI_MSI )) { err =nwl_pcie_enable_msi (pcie);Signature · 1 line
2.34.1
Viele Grüße,
Stefan Roese
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Re: [PATCH v4 2/2] PCI: xilinx-nwl: Add method to init_platform_service_irqs hook
Quoted 49 lines · On Friday 14 January 2022 13:13:16 Stefan Roese wrote:
Quoted 39 lines · Pali Rohár
Quoted 11 lines · On Friday 14 January 2022 08:58:34 Stefan Roese wrote:
From: Bharat Kumar Gogada <[email protected]>
Add
nwl_init_platform_service_irqs()hook toinit_platform_service_irqsto register the platform-specific Service Errors IRQs for this PCIe controller to fully support e.g. AER on this platform.Signed-off-by Bharat Kumar Gogada <[email protected]>Signed-off-by Stefan Roese <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Pali Rohár <[email protected]>Cc Michal Simek <[email protected]>Reviewed-by Pali Rohár <[email protected]>Quoted 24 lines
--- drivers/pci/controller/pcie-xilinx-nwl.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)drivers/pci/controller/pcie-xilinx-nwl.c +8
-0@@ -24,6 +24,7 @@#include <linux/irqchip/chained_irq.h> #include "../pci.h" +#include "../pcie/portdrv.h" /* Bridge core config registers */ #define BRCFG_PCIE_RX0 0x00000000@@ -806,6 +807,22 @@ static int nwl_pcie_parse_dt(struct nwl_pcie *pcie,return 0 ; } +static int nwl_init_platform_service_irqs (struct pci_dev *dev,int *irqs, +int plat_mask) +{ +struct pci_host_bridge *bridge; +struct nwl_pcie *pcie; + + bridge =pci_find_host_bridge (dev->bus);Quoted 8 lines
drivers/pci/controller/pcie-xilinx-nwl.c static int nwl_pcie_parse_dt(struct nwl_pcie *pcie, · line 821
Quoted 5 lines
drivers/pci/controller/pcie-xilinx-nwl.c +5
-0+ pcie =pci_host_bridge_priv (bridge); +if (plat_mask &PCIE_PORT_SERVICE_AER ) { + irqs[PCIE_PORT_SERVICE_AER_SHIFT ] = pcie->irq_misc; +return 0 ;/* platform-specific service IRQ installed */ + }Just I want to be sure, with this change PME and HP interrupts are not provided even when
plat_maskargument contains them.
Quoted 1 line
This function is only used for Root Ports.
Technically, also Root Ports can support hot plugging. But that it probably not the case of your board if it has PCIe switch connected to the Root Port which is not removable.
But hot plug interrupt can be optionally used also for signalling change of Data Link Layer state. And this information can be useful also in Root Port if to it is connected non-removable device.
So if init_platform_service_irqs callback explicitly do not specify PME or HP interrupts for the Root Port then kernel would not load pme or pciehp service for the Root Port.
This is note for me, that when I will go to use this callback in other drivers, I need to check that I provide interrupts for all supported services...
Quoted 4 lines
E.g. HP at the downstream
ports of the PCIe switch still works in our case, as herepcie_init_service_irqs()still gets called:
Quoted 9 lines
# cat /proc/interrupts | grep pci 44: 0 0 0 0 GICv2 150 Level nwl_pcie:misc, aerdrv 61: 2 0 0 0 nwl_pcie:msi 1064960 Edge pciehp 63: 0 0 0 0 nwl_pcie:msi 1081344 Edge pciehp 65: 4 0 0 0 nwl_pcie:msi 1097728 Edge pciehp
Yes, as PCIe switch is different device it should work fine.
Quoted 27 lines
Thanks,
StefanQuoted 8 lines
Quoted 8 lines
drivers/pci/controller/pcie-xilinx-nwl.c +4
-0+ +return -ENODEV ;/* platform-specific service IRQ not installed */ +} +static const struct of_device_id nwl_pcie_of_match[] = { { .compatible ="xlnx,nwl-pcie-2.11" , }, {}@@ -857,6 +874,7 @@ static int nwl_pcie_probe(struct platform_device *pdev)Quoted 8 lines
Quoted 8 lines
drivers/pci/controller/pcie-xilinx-nwl.c +1
-0bridge->sysdata = pcie; bridge->ops = &nwl_pcie_ops; + bridge->init_platform_service_irqs = nwl_init_platform_service_irqs;if (IS_ENABLED (CONFIG_PCI_MSI )) { err =nwl_pcie_enable_msi (pcie);Signature · 1 line
2.34.1Viele Grüße,
Stefan RoeseSignature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Re: [PATCH v4 2/2] PCI: xilinx-nwl: Add method to init_platform_service_irqs hook
Quoted 60 lines · Pali Rohár
Quoted 49 lines · On Friday 14 January 2022 13:13:16 Stefan Roese wrote:
Quoted 39 lines · Pali Rohár
Quoted 11 lines · On Friday 14 January 2022 08:58:34 Stefan Roese wrote:
From: Bharat Kumar Gogada <[email protected]>
Add
nwl_init_platform_service_irqs()hook toinit_platform_service_irqsto register the platform-specific Service Errors IRQs for this PCIe controller to fully support e.g. AER on this platform.Signed-off-by Bharat Kumar Gogada <[email protected]>Signed-off-by Stefan Roese <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Pali Rohár <[email protected]>Cc Michal Simek <[email protected]>Reviewed-by Pali Rohár <[email protected]>Quoted 24 lines
--- drivers/pci/controller/pcie-xilinx-nwl.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)drivers/pci/controller/pcie-xilinx-nwl.c +8
-0@@ -24,6 +24,7 @@#include <linux/irqchip/chained_irq.h> #include "../pci.h" +#include "../pcie/portdrv.h" /* Bridge core config registers */ #define BRCFG_PCIE_RX0 0x00000000@@ -806,6 +807,22 @@ static int nwl_pcie_parse_dt(struct nwl_pcie *pcie,return 0 ; } +static int nwl_init_platform_service_irqs (struct pci_dev *dev,int *irqs, +int plat_mask) +{ +struct pci_host_bridge *bridge; +struct nwl_pcie *pcie; + + bridge =pci_find_host_bridge (dev->bus);Quoted 8 lines
drivers/pci/controller/pcie-xilinx-nwl.c static int nwl_pcie_parse_dt(struct nwl_pcie *pcie, · line 821
Quoted 5 lines
drivers/pci/controller/pcie-xilinx-nwl.c +5
-0+ pcie =pci_host_bridge_priv (bridge); +if (plat_mask &PCIE_PORT_SERVICE_AER ) { + irqs[PCIE_PORT_SERVICE_AER_SHIFT ] = pcie->irq_misc; +return 0 ;/* platform-specific service IRQ installed */ + }Just I want to be sure, with this change PME and HP interrupts are not provided even when
plat_maskargument contains them.Quoted 1 line
This function is only used for Root Ports.
Technically, also Root Ports can support hot plugging. But that it probably not the case of your board if it has PCIe switch connected to the Root Port which is not removable.
But hot plug interrupt can be optionally used also for signalling change of Data Link Layer state. And this information can be useful also in Root Port if to it is connected non-removable device.
Quoted 7 lines
So if
init_platform_service_irqscallback explicitly do not specify PME or HP interrupts for the Root Port then kernel would not load pme or pciehp service for the Root Port.This is note for me, that when I will go to use this callback in other drivers, I need to check that I provide interrupts for all supported services...
It might very well be the case, that this current implementation does not fully handle all use-cases (controller specific). The code can be extended and/or fixed, once other users will show up.
Thanks,
Stefan
Quoted 14 lines
Quoted 4 lines
E.g. HP at the downstream
ports of the PCIe switch still works in our case, as herepcie_init_service_irqs()still gets called:Quoted 9 lines
# cat /proc/interrupts | grep pci 44: 0 0 0 0 GICv2 150 Level nwl_pcie:misc, aerdrv 61: 2 0 0 0 nwl_pcie:msi 1064960 Edge pciehp 63: 0 0 0 0 nwl_pcie:msi 1081344 Edge pciehp 65: 4 0 0 0 nwl_pcie:msi 1097728 Edge pciehp
Quoted 29 lines
Yes, as PCIe switch is different device it should work fine.
Quoted 27 lines
Thanks,
StefanQuoted 8 lines
Quoted 8 lines
drivers/pci/controller/pcie-xilinx-nwl.c +4
-0+ +return -ENODEV ;/* platform-specific service IRQ not installed */ +} +static const struct of_device_id nwl_pcie_of_match[] = { { .compatible ="xlnx,nwl-pcie-2.11" , }, {}@@ -857,6 +874,7 @@ static int nwl_pcie_probe(struct platform_device *pdev)Quoted 8 lines
Quoted 8 lines
drivers/pci/controller/pcie-xilinx-nwl.c +1
-0bridge->sysdata = pcie; bridge->ops = &nwl_pcie_ops; + bridge->init_platform_service_irqs = nwl_init_platform_service_irqs;if (IS_ENABLED (CONFIG_PCI_MSI )) { err =nwl_pcie_enable_msi (pcie);Signature · 1 line
2.34.1Viele Grüße,
Stefan RoeseSignature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Viele Grüße,
Stefan Roese
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Quoted 12 lines · Stefan Roese
Some platforms have dedicated IRQ lines for platform-specific System Errors like AER/PME etc. The root complex on these platform will use these seperate IRQ lines to report AER/PME etc., interrupts and will not generate MSI/MSI-X/INTx interrupts for these services.
These patches will add new method for these kind of platforms to register the platform IRQ number with respective PCIe services.
Changes in v4 (Stefan):
- Remove 2nd check forPCI_EXP_TYPE_ROOT_PORT
- Changeinit_platform_service_irqs()from void to return int
Quoted 8 lines
Changes in v3 (Stefan):
- Restructure patches from 4 patches in v2 to now 2 patches in v3
- Rename of functions names
-init_platform_service_irqs()now uses "structpci_dev*" instead of "structpci_host_bridge*"
-pcie_init_platform_service_irqs()is called beforepcie_init_service_irqs()
- Use more PCIe spec terminology as suggested by Bjorn (hopefully enough, I don't have the spec at hand)
Bjorn, what's the status of this patchset? I was under the impression, that it would make it into v5.18. Please let me know if something is missing.
Thanks,
Stefan
Quoted 10 lines
Bharat Kumar Gogada (2):
PCI/portdrv: Add option to setup IRQs for platform-specific Service
Errors
PCI: xilinx-nwl: Add method toinit_platform_service_irqshookdrivers/pci/controller/pcie-xilinx-nwl.c | 18 +++++++++++ drivers/pci/pcie/portdrv_core.c | 39 +++++++++++++++++++++++- include/linux/pci.h | 2 ++ 3 files changed, 58 insertions(+), 1 deletion(-)
Viele Grüße,
Stefan Roese
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Quoted 22 lines · Stefan Roese
Quoted 12 lines · Stefan Roese
Some platforms have dedicated IRQ lines for platform-specific System Errors like AER/PME etc. The root complex on these platform will use these seperate IRQ lines to report AER/PME etc., interrupts and will not generate MSI/MSI-X/INTx interrupts for these services.
These patches will add new method for these kind of platforms to register the platform IRQ number with respective PCIe services.
Changes in v4 (Stefan):
- Remove 2nd check forPCI_EXP_TYPE_ROOT_PORT
- Changeinit_platform_service_irqs()from void to return intQuoted 8 lines
Changes in v3 (Stefan):
- Restructure patches from 4 patches in v2 to now 2 patches in v3
- Rename of functions names
-init_platform_service_irqs()now uses "structpci_dev*" instead of "structpci_host_bridge*"
-pcie_init_platform_service_irqs()is called beforepcie_init_service_irqs()
- Use more PCIe spec terminology as suggested by Bjorn (hopefully enough, I don't have the spec at hand)
Quoted 3 lines
Bjorn, what's the status of this patchset? I was under the impression, that it would make it into v5.18. Please let me know if something is missing.
Sorry, I didn't get to it in time for v5.18, but it's on my list for v5.19.
I thought maybe it got assigned to Lorenzo because it touches drivers/pci/controller/, but I can't find it in patchwork
(https://patchwork.kernel.org/project/linux-pci/list/) at all.
Would you mind posting it again to make sure patchwork picks it up? If it's not in patchwork, it's very likely to get missed.
Bjorn
Quoted 18 lines
Quoted 10 lines
Bharat Kumar Gogada (2):
PCI/portdrv: Add option to setup IRQs for platform-specific Service
Errors
PCI: xilinx-nwl: Add method toinit_platform_service_irqshookdrivers/pci/controller/pcie-xilinx-nwl.c | 18 +++++++++++ drivers/pci/pcie/portdrv_core.c | 39 +++++++++++++++++++++++- include/linux/pci.h | 2 ++ 3 files changed, 58 insertions(+), 1 deletion(-)Viele Grüße,
Stefan RoeseSignature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Quoted 27 lines · Bjorn Helgaas
Quoted 22 lines · Stefan Roese
Quoted 12 lines · Stefan Roese
Some platforms have dedicated IRQ lines for platform-specific System Errors like AER/PME etc. The root complex on these platform will use these seperate IRQ lines to report AER/PME etc., interrupts and will not generate MSI/MSI-X/INTx interrupts for these services.
These patches will add new method for these kind of platforms to register the platform IRQ number with respective PCIe services.
Changes in v4 (Stefan):
- Remove 2nd check forPCI_EXP_TYPE_ROOT_PORT
- Changeinit_platform_service_irqs()from void to return intQuoted 8 lines
Changes in v3 (Stefan):
- Restructure patches from 4 patches in v2 to now 2 patches in v3
- Rename of functions names
-init_platform_service_irqs()now uses "structpci_dev*" instead of "structpci_host_bridge*"
-pcie_init_platform_service_irqs()is called beforepcie_init_service_irqs()
- Use more PCIe spec terminology as suggested by Bjorn (hopefully enough, I don't have the spec at hand)Quoted 3 lines
Bjorn, what's the status of this patchset? I was under the impression, that it would make it into v5.18. Please let me know if something is missing.
Quoted 6 lines
Sorry, I didn't get to it in time for v5.18, but it's on my list for v5.19.
I thought maybe it got assigned to Lorenzo because it touches
drivers/pci/controller/, but I can't find it in patchwork
(https://patchwork.kernel.org/project/linux-pci/list/) at all.
Both patches are in patchwork:
https://patchwork.kernel.org/project/linux-pci/patch/[email protected]/
https://patchwork.kernel.org/project/linux-pci/patch/[email protected]/
The first one is assigned to you and the 2nd one to Lorenzo.
Quoted 2 lines
Would you mind posting it again to make sure patchwork picks it up? If it's not in patchwork, it's very likely to get missed.
Since it's already on patchwork, I did not post the patches again. Please let me know if I should re-post them nevertheless.
Thanks,
Stefan
Quoted 20 lines
Bjorn
Quoted 18 lines
Quoted 10 lines
Bharat Kumar Gogada (2):
PCI/portdrv: Add option to setup IRQs for platform-specific Service
Errors
PCI: xilinx-nwl: Add method toinit_platform_service_irqshookdrivers/pci/controller/pcie-xilinx-nwl.c | 18 +++++++++++ drivers/pci/pcie/portdrv_core.c | 39 +++++++++++++++++++++++- include/linux/pci.h | 2 ++ 3 files changed, 58 insertions(+), 1 deletion(-)Viele Grüße,
Stefan RoeseSignature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Viele Grüße,
Stefan Roese
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Quoted 40 lines · Stefan Roese
Quoted 27 lines · Bjorn Helgaas
Quoted 22 lines · Stefan Roese
Quoted 12 lines · Stefan Roese
Some platforms have dedicated IRQ lines for platform-specific System Errors like AER/PME etc. The root complex on these platform will use these seperate IRQ lines to report AER/PME etc., interrupts and will not generate MSI/MSI-X/INTx interrupts for these services.
These patches will add new method for these kind of platforms to register the platform IRQ number with respective PCIe services.
Changes in v4 (Stefan):
- Remove 2nd check forPCI_EXP_TYPE_ROOT_PORT
- Changeinit_platform_service_irqs()from void to return intQuoted 8 lines
Changes in v3 (Stefan):
- Restructure patches from 4 patches in v2 to now 2 patches in v3
- Rename of functions names
-init_platform_service_irqs()now uses "structpci_dev*" instead of "structpci_host_bridge*"
-pcie_init_platform_service_irqs()is called beforepcie_init_service_irqs()
- Use more PCIe spec terminology as suggested by Bjorn (hopefully enough, I don't have the spec at hand)Quoted 3 lines
Bjorn, what's the status of this patchset? I was under the impression, that it would make it into v5.18. Please let me know if something is missing.
Quoted 6 lines
Sorry, I didn't get to it in time for v5.18, but it's on my list for v5.19.
I thought maybe it got assigned to Lorenzo because it touches
drivers/pci/controller/, but I can't find it in patchwork
(https://patchwork.kernel.org/project/linux-pci/list/) at all.Both patches are in patchwork:
https://patchwork.kernel.org/project/linux-pci/patch/[email protected]/
https://patchwork.kernel.org/project/linux-pci/patch/[email protected]/
Quoted 7 lines
The first one is assigned to you and the 2nd one to Lorenzo.
Quoted 2 lines
Would you mind posting it again to make sure patchwork picks it up? If it's not in patchwork, it's very likely to get missed.
Since it's already on patchwork, I did not post the patches again. Please let me know if I should re-post them nevertheless.
No, that should be enough. I spent 10 minutes searching patchwork yesterday; don't know why I couldn't find it.
Quoted 26 lines
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
Bharat Kumar Gogada (2):
PCI/portdrv: Add option to setup IRQs for platform-specific Service
Errors
PCI: xilinx-nwl: Add method toinit_platform_service_irqshookdrivers/pci/controller/pcie-xilinx-nwl.c | 18 +++++++++++ drivers/pci/pcie/portdrv_core.c | 39 +++++++++++++++++++++++- include/linux/pci.h | 2 ++ 3 files changed, 58 insertions(+), 1 deletion(-)Quoted 7 lines
Quoted 7 lines
Viele Grüße,
Stefan RoeseSignature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]Viele Grüße,
Stefan RoeseSignature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]