Skip to contentSkip to conversation

locking/rwsem: drop redundant semicolon of down_write_nest_lock

PATCH In review Guchun Chen 3 participants 3 messages Jan 14, 2022 Locking primitives

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 locking/rwsem: drop redundant semicolon of down_write_nest_lock

Otherwise, braces are needed when using it.

---
 include/linux/rwsem.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/rwsem.h +1 -1
index f9348769e558..efa5c324369a 100644
@@ -230,7 +230,7 @@ extern void _down_write_nest_lock(struct rw_semaphore *sem, struct lockdep_map *
 do {								\
 	typecheck(struct lockdep_map *, &(nest_lock)->dep_map);	\
 	_down_write_nest_lock(sem, &(nest_lock)->dep_map);	\
-} while (0);
+} while (0)
 
 /*
  * Take/release a lock when not the owner will release it.
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw

Am 14.01.22 um 09:37 schrieb Guchun Chen:

Quoted 3 lines

Otherwise, braces are needed when using it.

Peter any objections that we push this upstream through the drm subsystem?

Thanks,
Christian.

Quoted 17 lines
---
  include/linux/rwsem.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/rwsem.h +1 -1
index f9348769e558..efa5c324369a 100644
@@ -230,7 +230,7 @@ extern void _down_write_nest_lock(struct rw_semaphore *sem, struct lockdep_map *
  do {								\
  	typecheck(struct lockdep_map *, &(nest_lock)->dep_map);	\
  	_down_write_nest_lock(sem, &(nest_lock)->dep_map);	\
-} while (0);
+} while (0)
 
  /*
   * Take/release a lock when not the owner will release it.