Skip to contentSkip to conversation

soc: qcom: apr: Remove redundant 'flush_workqueue()' calls

PATCH Applied Xu Wang 2 participants 2 messages Jan 14, 2022 – Feb 4, 2022

Subsystems (3)
lore
Share & tools
lore

Xu Wang

author
#0 lore raw

PATCH 1/1 soc: qcom: apr: Remove redundant 'flush_workqueue()' calls

'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

---
 drivers/soc/qcom/apr.c | 1 -
 1 file changed, 1 deletion(-)
drivers/soc/qcom/apr.c +0 -1
index 82ca12c9328a..3caabd873322 100644
@@ -653,7 +653,6 @@ static void apr_remove(struct rpmsg_device *rpdev)
 
 	pdr_handle_release(apr->pdr);
 	device_for_each_child(&rpdev->dev, NULL, apr_remove_device);
-	flush_workqueue(apr->rxwq);
 	destroy_workqueue(apr->rxwq);
 }
 
Signature · 1 line
2.25.1
#1 lore raw

Re: (subset) [PATCH] soc: qcom: apr: Remove redundant 'flush_workqueue()' calls

Quoted 6 lines · Xu Wang

'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

Applied, thanks!

[1/1] soc: qcom: apr: Remove redundant 'flush_workqueue()' calls

      commit: 4e6ae78ee61957800657d56ba78a10f034de174e

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>