Skip to contentSkip to conversation

kernel-shark: Fix potential segfault in free_plugin()

PATCH New Yordan Karadzhov (VMware) 1 participant 1 message Jan 14, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel-shark: Fix potential segfault in free_plugin()

The 'handle' field is not guaranteed to be initialized, hence a check is required before closing it.

---
 src/libkshark-plugin.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
src/libkshark-plugin.c +3 -2
index 09886ce..2eb3b4a 100644
@@ -219,9 +219,10 @@ void kshark_free_draw_handler_list(struct kshark_draw_handler *handlers)
 /** Close and free this plugin. */
 static void free_plugin(struct kshark_plugin_list *plugin)
 {
-	dlclose(plugin->handle);
+	if (plugin->handle)
+		dlclose(plugin->handle);
 
-	if (plugin->process_interface){
+	if (plugin->process_interface) {
 		free(plugin->process_interface->name);
 		free(plugin->process_interface);
 	}
Signature · 1 line
2.32.0