Skip to contentSkip to conversation

mt76: mt7915: set bssinfo/starec command when adding interface

PATCH New Shayne Chen 1 participant 1 message Jan 14, 2022

Subsystems (2)
lore
Share & tools
lore

Shayne Chen

author reviewer
#0 lore raw

PATCH 1/1 mt76: mt7915: set bssinfo/starec command when adding interface

bssinfo/starec disabled commands are sent during removing interface. However, if we don't set corresponding enabled commands before removing interface, the fw may enter an exception state due to some NULL structs.
For example, the following commands can cause fw timeout in our newer chips:
ifconfig wlan0/mon0 up
ifconfig wlan0/mon0 down

Fix this by setting enabled commands once interface added.

---
 drivers/net/wireless/mediatek/mt76/mt7915/main.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/wireless/mediatek/mt76/mt7915/main.c +3 -0
index b45b75f..41b0a4d 100644
@@ -257,6 +257,9 @@ static int mt7915_add_interface(struct ieee80211_hw *hw,
 	mt7915_init_bitrate_mask(vif);
 	memset(&mvif->cap, -1, sizeof(mvif->cap));
 
+	mt7915_mcu_add_bss_info(phy, vif, true);
+	mt7915_mcu_add_sta(dev, vif, NULL, true);
+
 out:
 	mutex_unlock(&dev->mt76.mutex);
 
Signature · 1 line
2.25.1