Skip to contentSkip to conversation

GitHub Actions: ensure Ubuntu builds are made with the chosen SSL library

PATCH In review Antonio Quartulli 2 participants 2 messages Jan 14, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 GitHub Actions: ensure Ubuntu builds are made with the chosen SSL library

The configure parameter was appended to the stage name but not to the actual command. Fix this.

---

Changes from v2:
* fix typ0 in sslpkg name for mbedtls

 .github/workflows/build.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
.github/workflows/build.yaml +3 -3
index ea1233b1..354a3256 100644
@@ -131,7 +131,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-18.04, ubuntu-20.04]
-        sslpkg: [libssl-dev]
+        sslpkg: [libmbedtls-dev]
         ssllib: [mbedtls]
         libname: [mbed TLS]
 
@@ -161,8 +161,8 @@ jobs:
         uses: actions/[email protected]...
       - name: autoconf
         run: autoreconf -fvi
-      - name: configure --with-crypto-library=${{matrix.ssllib}}
-        run: ./configure
+      - name: configure
+        run: ./configure --with-crypto-library=${{matrix.ssllib}}
       - name: make all
         run: make -j3
       - name: make check
Signature · 1 line
2.34.1
Acked-by on v2 1/1
#1 lore raw

"D'oh"... no idea who merged that original patch... :-)

Your patch has been applied to the master branch.

commit 6445bf30c12a87c06ee0b24b19293efefc8cad27

Author: Antonio Quartulli
Date:   Fri Jan 14 13:25:38 2022 +0100
     GitHub Actions: ensure Ubuntu builds are made with the chosen SSL library

     Signed-off-by: Antonio Quartulli <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg23539.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering