Skip to contentSkip to conversation

package/boost: enable system on host

PATCH In review Fabrice Fontaine 2 participants 2 messages Jan 14, 2022 – Jan 15, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/boost: enable system on host

boost system (which provides boost asio) is needed by host-riscv-isa-sim since its addition in commit ea033cecf990ed3f86619647523a9ad2ccb09adb:

configure: error: Could not find a version of the Boost::Asio library!

Fixes:
- http://autobuild.buildroot.org/results/6c33a66386ab2171454d8ea8c1bd17a5582e21dd

---
 package/boost/boost.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/boost/boost.mk +1 -1
index 6d1046e9a2..2d2a8fb311 100644
@@ -17,7 +17,7 @@ HOST_BOOST_FLAGS = --without-icu --with-toolset=gcc \
 	--without-libraries=$(subst $(space),$(comma),atomic chrono context \
 	contract container coroutine date_time exception fiber filesystem graph \
 	graph_parallel iostreams json locale log math mpi nowide program_options \
-	python random serialization stacktrace system test thread timer \
+	python random serialization stacktrace test thread timer \
 	type_erasure wave)
 
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_ATOMIC),,atomic)
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Fabrice, All,

On 2022-01-14 18:18 +0100, Fabrice Fontaine spake thusly:

Quoted 18 lines

boost system (which provides boost asio) is needed by host-riscv-isa-sim since its addition in commit ea033cecf990ed3f86619647523a9ad2ccb09adb:

configure: error: Could not find a version of the Boost::Asio library!

Fixes:
- http://autobuild.buildroot.org/results/6c33a66386ab2171454d8ea8c1bd17a5582e21dd

---
 package/boost/boost.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/boost/boost.mk +0 -0
index 6d1046e9a2..2d2a8fb311 100644

package/boost/boost.mk HOST_BOOST_FLAGS = --without-icu --with-toolset=gcc \ · line 21

Quoted 6 lines
package/boost/boost.mk +1 -1
@@ -17,7 +17,7 @@ HOST_BOOST_FLAGS = --without-icu --with-toolset=gcc \
 	--without-libraries=$(subst $(space),$(comma),atomic chrono context \
 	contract container coroutine date_time exception fiber filesystem graph \
 	graph_parallel iostreams json locale log math mpi nowide program_options \
-	python random serialization stacktrace system test thread timer \
+	python random serialization stacktrace test thread timer \
 	type_erasure wave)

I was wondering why we need to disable those, and the original commit log is not very explicit about why this is so (429ffbd2253 boost: add host variant), and the comment is not very helpful either...

So I did a test: remove all those exclusion (just exclude python [0]), and build just host-boost (it has no dependency):

master : 54s
no-exclusion: 2min 38s

So yes, this is a big increase. But considering that we have no way for host packages to express dependencies on Boost features, I wonder if we should not just build the whole stuff. For example, packages in a br2-external have no way to say so...

Anyway, in the meantime: applied to master, thanks.

[0] building the Boost python module would require the python development files be installed on the host, or that we depend on host-python{,3}, neither of which are acceptable

Regards,
Yann E. MORIN.

Quoted 8 lines
package/boost/boost.mk +0 -0
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_ATOMIC),,atomic)
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot