ksmbd: uninitialized variable in create_socket()
Subsystems (3)
PATCH 1/1 ksmbd: uninitialized variable in create_socket()
The "ksmbd_socket" variable is not initialized on this error path.
Fixes 0626e6641f6b ("cifsd: add server handler for central processing and tranport layers")
Signed-off-by Dan Carpenter <[email protected]>
--- fs/ksmbd/transport_tcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/ksmbd/transport_tcp.c +2 -1
@@ -404,7 +404,7 @@ static int create_socket(struct interface *iface) &ksmbd_socket);if (ret) {pr_err ("Can't create socket for ipv4: %d\n" , ret); - goto out_error; + goto out_clear; } sin.sin_family =PF_INET ;
@@ -462,6 +462,7 @@ static int create_socket(struct interface *iface) out_error:tcp_destroy_socket (ksmbd_socket); +out_clear: iface->ksmbd_socket =NULL ;return ret; }
Signature · 1 line
2.20.1
2022-01-15 20:49 GMT+09:00, Dan Carpenter <[email protected]>:
Quoted 6 lines
The "
ksmbd_socket" variable is not initialized on this error path.Fixes 0626e6641f6b ("cifsd: add server handler for central processing andtranport layers")
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Namjae Jeon <[email protected]>
Thanks!