env: fat: Add new lines at the end of print statements
PATCH 1/1 env: fat: Add new lines at the end of print statements
Add some new line feeds at the end of print messages to make things easier to read on the console. The other env options do this so this is just an omission for FAT env.
Signed-off-by Peter Robinson <[email protected]>
--- env/fat.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
env/fat.c +4 -4
@@ -77,7 +77,7 @@ static int env_fat_save(void)* This printf is embedded in the messages from env_save that * will calling it. The missing \n is intentional. */ -printf ("Unable to use %s %d:%d... " , +printf ("Unable to use %s %d:%d... \n" ,CONFIG_ENV_FAT_INTERFACE , dev, part);return 1 ; }
@@ -93,7 +93,7 @@ static int env_fat_save(void)* This printf is embedded in the messages from env_save that * will calling it. The missing \n is intentional. */ -printf ("Unable to write \"%s\" from %s%d:%d... " , +printf ("Unable to write \"%s\" from %s%d:%d... \n" , file,CONFIG_ENV_FAT_INTERFACE , dev, part);return 1 ; }
@@ -135,7 +135,7 @@ static int env_fat_load(void)* This printf is embedded in the messages from env_save that * will calling it. The missing \n is intentional. */ -printf ("Unable to use %s %d:%d... " , +printf ("Unable to use %s %d:%d... \n" ,CONFIG_ENV_FAT_INTERFACE , dev, part); goto err_env_relocate; }
@@ -153,7 +153,7 @@ static int env_fat_load(void)* This printf is embedded in the messages from env_save that * will calling it. The missing \n is intentional. */ -printf ("Unable to read \"%s\" from %s%d:%d... " , +printf ("Unable to read \"%s\" from %s%d:%d... \n" ,CONFIG_ENV_FAT_FILE ,CONFIG_ENV_FAT_INTERFACE , dev, part); goto err_env_relocate; }
Signature · 1 line
2.33.1
Quoted 5 lines · Peter Robinson
Add some new line feeds at the end of print messages to make things easier to read on the console. The other env options do this so this is just an omission for FAT env.
Signed-off-by Peter Robinson <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom
Quoted 14 lines · Peter Robinson
Add some new line feeds at the end of print messages to make things easier to read on the console. The other env options do this so this is just an omission for FAT env.
Signed-off-by Peter Robinson <[email protected]>--- env/fat.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)env/fat.c +0
-0
env/fat.c static int env_fat_save(void) · line 79
Quoted 3 lines
env/fat.c +0
-0@@ -77,7 +77,7 @@ static int env_fat_save(void)* This printf is embedded in the messages from env_save that * will calling it. The missing \n is intentional. */
It would be better to remove the comment above as well.
-Takahiro Akashi
Quoted 35 lines
env/fat.c +4
-4-printf ("Unable to use %s %d:%d... " , +printf ("Unable to use %s %d:%d... \n" ,CONFIG_ENV_FAT_INTERFACE , dev, part);return 1 ; }@@ -93,7 +93,7 @@ static int env_fat_save(void)* This printf is embedded in the messages from env_save that * will calling it. The missing \n is intentional. */ -printf ("Unable to write \"%s\" from %s%d:%d... " , +printf ("Unable to write \"%s\" from %s%d:%d... \n" , file,CONFIG_ENV_FAT_INTERFACE , dev, part);return 1 ; }@@ -135,7 +135,7 @@ static int env_fat_load(void)* This printf is embedded in the messages from env_save that * will calling it. The missing \n is intentional. */ -printf ("Unable to use %s %d:%d... " , +printf ("Unable to use %s %d:%d... \n" ,CONFIG_ENV_FAT_INTERFACE , dev, part); goto err_env_relocate; }@@ -153,7 +153,7 @@ static int env_fat_load(void)* This printf is embedded in the messages from env_save that * will calling it. The missing \n is intentional. */ -printf ("Unable to read \"%s\" from %s%d:%d... " , +printf ("Unable to read \"%s\" from %s%d:%d... \n" ,CONFIG_ENV_FAT_FILE ,CONFIG_ENV_FAT_INTERFACE , dev, part); goto err_env_relocate; }Signature · 1 line
2.33.1