Skip to contentSkip to conversation

lib: Kconfig: fix PHANDLE_CHECK_SEQ position outside of menu

PATCH In review Eugen Hristev 4 participants 4 messages Jan 4, 2022 – Jan 15, 2022 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib: Kconfig: fix PHANDLE_CHECK_SEQ position outside of menu

CONFIG_PHANDLE_CHECK_SEQ is outside of the menu 'Library routines' thus it's invisible in menuconfig and cannot be selected. Fix this by moving the 'endmenu' after the PHANDLE_CHECK_SEQ definition

Fixes c589132a1d ("fdt: Use phandle to distinguish DT nodes with same name")
---
 lib/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
lib/Kconfig +2 -2
index 807a4c6ade..652a11a154 100644
@@ -827,11 +827,11 @@ config LMB_RESERVED_REGIONS
 	  Define the number of supported reserved regions in the library logical
 	  memory blocks.
 
-endmenu
-
 config PHANDLE_CHECK_SEQ
 	bool "Enable phandle check while getting sequence number"
 	help
 	  When there are multiple device tree nodes with same name,
           enable this config option to distinguish them using
 	  phandles in fdtdec_get_alias_seq() function.
+
+endmenu
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Eugen,

Quoted 6 lines · Eugen Hristev

CONFIG_PHANDLE_CHECK_SEQ is outside of the menu 'Library routines' thus it's invisible in menuconfig and cannot be selected. Fix this by moving the 'endmenu' after the PHANDLE_CHECK_SEQ definition

Fixes c589132a1d ("fdt: Use phandle to distinguish DT nodes with same name")

Thank you for fixing this :)

Thanks,
Aswath

Quoted 23 lines
---
 lib/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
lib/Kconfig +2 -2
index 807a4c6ade..652a11a154 100644
@@ -827,11 +827,11 @@ config LMB_RESERVED_REGIONS
 	  Define the number of supported reserved regions in the library logical
 	  memory blocks.
 
-endmenu
-
 config PHANDLE_CHECK_SEQ
 	bool "Enable phandle check while getting sequence number"
 	help
 	  When there are multiple device tree nodes with same name,
           enable this config option to distinguish them using
 	  phandles in fdtdec_get_alias_seq() function.
+
+endmenu
Reviewed-by on v1 1/1
#2 lore raw
In reply to Eugen Hristev
Quoted 10 lines · Eugen Hristev

CONFIG_PHANDLE_CHECK_SEQ is outside of the menu 'Library routines' thus it's invisible in menuconfig and cannot be selected. Fix this by moving the 'endmenu' after the PHANDLE_CHECK_SEQ definition

Fixes c589132a1d ("fdt: Use phandle to distinguish DT nodes with same name")
---
 lib/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
#3 lore raw
In reply to Eugen Hristev
Quoted 8 lines · Eugen Hristev

CONFIG_PHANDLE_CHECK_SEQ is outside of the menu 'Library routines' thus it's invisible in menuconfig and cannot be selected. Fix this by moving the 'endmenu' after the PHANDLE_CHECK_SEQ definition

Fixes c589132a1d ("fdt: Use phandle to distinguish DT nodes with same name")

Applied to u-boot/master, thanks!

Signature · 1 line
Tom