tune-cortexa72: Drop the crypto extension from the cortexa72 tune
v2 cover tune-cortexa72: Drop the crypto extension from the cortexa72 tune
Hi,
v2:
Include the patch 3 as suggest by Richard.
v1:
This patch series backport two patches from the master branch to fix the crash issue on some cortexa72 boards due to the crypto intructions are used.
Jagadeesh Krishnanjanappa (1):
tune-cortexa72: remove crypto for the default cortex-a72
Kevin Hao (2):
tune-cortexa72: Enable the crc extension by default for cortexa72
tune-cortexa72: Drop the redundant cortexa72-crc tune
meta/conf/machine/include/tune-cortexa72.inc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
Signature · 1 line
2.31.1
PATCH v2 1/3 tune-cortexa72: remove crypto for the default cortex-a72
From: Jagadeesh Krishnanjanappa <[email protected]>
The cryptographic unit is optional for the Cortex-A72, but it was included by default previously. This breaks building systems that lack this functionality when using tune-cortexa72.inc.
To correct this, add a crypto entry in the tune file. Since CRC is optional for ARMv8.0, do the same thing while we're at it.
For platforms that had been happily using tune-cortexa72.inc, a slight degradation of performance will occur using the default. To correct this, simply add:
DEFAULTTUNE = "cortexa72-crc-crypto"
(From OE-Core rev: 2568d537087adb0b592aa250bf628a7b48c3a9d3)
---
v2: No change.
meta/conf/machine/include/tune-cortexa72.inc | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
meta/conf/machine/include/tune-cortexa72.inc +12 -4
@@ -6,8 +6,16 @@ TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'cortexa72', ' -mcpu=corte require conf/machine/include/arm/arch-armv8a.inc # Little Endian base configs -AVAILTUNES += "cortexa72" +AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto" ARMPKGARCH_tune-cortexa72 = "cortexa72" -TUNE_FEATURES_tune-cortexa72 = "${TUNE_FEATURES_tune-armv8a-crc-crypto} cortexa72" -PACKAGE_EXTRA_ARCHS_tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa72" -BASE_LIB_tune-cortexa72 = "lib64" +ARMPKGARCH_tune-cortexa72-crc = "cortexa72" +ARMPKGARCH_tune-cortexa72-crc-crypto = "cortexa72" +TUNE_FEATURES_tune-cortexa72 = "${TUNE_FEATURES_tune-armv8a} cortexa72" +TUNE_FEATURES_tune-cortexa72-crc = "${TUNE_FEATURES_tune-cortexa72} crc" +TUNE_FEATURES_tune-cortexa72-crc-crypto = "${TUNE_FEATURES_tune-cortexa72} crc crypto" +PACKAGE_EXTRA_ARCHS_tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS_tune-armv8} cortexa72" +PACKAGE_EXTRA_ARCHS_tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa72 cortexa72-crc" +PACKAGE_EXTRA_ARCHS_tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa72 cortexa72-crc cortexa72-crc-crypto" +BASE_LIB_tune-cortexa72 = "lib64" +BASE_LIB_tune-cortexa72-crc = "lib64" +BASE_LIB_tune-cortexa72-crc-crypto = "lib64"
Signature · 1 line
2.31.1
PATCH v2 2/3 tune-cortexa72: Enable the crc extension by default for cortexa72
In reply to Kevin HaoThe crc extension is optional for the ARMv8.0 but is mandatory for the cortexa72, so there is no reason not to enable it for the cortexa72 tune. With this change, the cortexa72-crc seems redundant. But we had better to keep it to be compatible with the BSP which already used that tune.
(From OE-Core rev: ca50267ab568d2f688844cb7c6cd867ed34168db)
---
v2: No change.
meta/conf/machine/include/tune-cortexa72.inc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
meta/conf/machine/include/tune-cortexa72.inc +6 -6
@@ -10,12 +10,12 @@ AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto" ARMPKGARCH_tune-cortexa72 = "cortexa72" ARMPKGARCH_tune-cortexa72-crc = "cortexa72" ARMPKGARCH_tune-cortexa72-crc-crypto = "cortexa72" -TUNE_FEATURES_tune-cortexa72 = "${TUNE_FEATURES_tune-armv8a} cortexa72" -TUNE_FEATURES_tune-cortexa72-crc = "${TUNE_FEATURES_tune-cortexa72} crc" -TUNE_FEATURES_tune-cortexa72-crc-crypto = "${TUNE_FEATURES_tune-cortexa72} crc crypto" -PACKAGE_EXTRA_ARCHS_tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS_tune-armv8} cortexa72" -PACKAGE_EXTRA_ARCHS_tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa72 cortexa72-crc" -PACKAGE_EXTRA_ARCHS_tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa72 cortexa72-crc cortexa72-crc-crypto" +TUNE_FEATURES_tune-cortexa72 = "${TUNE_FEATURES_tune-armv8a-crc} cortexa72" +TUNE_FEATURES_tune-cortexa72-crc = "${TUNE_FEATURES_tune-cortexa72}" +TUNE_FEATURES_tune-cortexa72-crc-crypto = "${TUNE_FEATURES_tune-cortexa72} crypto" +PACKAGE_EXTRA_ARCHS_tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS_tune-armv8-crc} cortexa72" +PACKAGE_EXTRA_ARCHS_tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa72" +PACKAGE_EXTRA_ARCHS_tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa72 cortexa72-crc-crypto" BASE_LIB_tune-cortexa72 = "lib64" BASE_LIB_tune-cortexa72-crc = "lib64" BASE_LIB_tune-cortexa72-crc-crypto = "lib64"
Signature · 1 line
2.31.1
PATCH v2 3/3 tune-cortexa72: Drop the redundant cortexa72-crc tune
In reply to Kevin HaoWe have enabled the crc extension by default for cortexa72 in patch ("tune-cortexa72: Enable the crc extension by default for cortexa72"), then the cortexa72-crc seems redundant. So drop it. We also rename the cortexa72-crc-crypto to cortexa72-crypto. With these changes, it will break the BSPs which used these two tunes, but it should be easy to fix.
(From OE-Core rev: 03cebdd7ef923a8ac5c8b7c12c7cefe7ca0158db)
---
v2: A new patch in v2.
meta/conf/machine/include/tune-cortexa72.inc | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-)
meta/conf/machine/include/tune-cortexa72.inc +5 -9
@@ -6,16 +6,12 @@ TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'cortexa72', ' -mcpu=corte require conf/machine/include/arm/arch-armv8a.inc # Little Endian base configs -AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto" +AVAILTUNES += "cortexa72 cortexa72-crypto" ARMPKGARCH_tune-cortexa72 = "cortexa72" -ARMPKGARCH_tune-cortexa72-crc = "cortexa72" -ARMPKGARCH_tune-cortexa72-crc-crypto = "cortexa72" +ARMPKGARCH_tune-cortexa72-crypto = "cortexa72" TUNE_FEATURES_tune-cortexa72 = "${TUNE_FEATURES_tune-armv8a-crc} cortexa72" -TUNE_FEATURES_tune-cortexa72-crc = "${TUNE_FEATURES_tune-cortexa72}" -TUNE_FEATURES_tune-cortexa72-crc-crypto = "${TUNE_FEATURES_tune-cortexa72} crypto" +TUNE_FEATURES_tune-cortexa72-crypto = "${TUNE_FEATURES_tune-cortexa72} crypto" PACKAGE_EXTRA_ARCHS_tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS_tune-armv8-crc} cortexa72" -PACKAGE_EXTRA_ARCHS_tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa72" -PACKAGE_EXTRA_ARCHS_tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa72 cortexa72-crc-crypto" +PACKAGE_EXTRA_ARCHS_tune-cortexa72-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa72 cortexa72-crypto" BASE_LIB_tune-cortexa72 = "lib64" -BASE_LIB_tune-cortexa72-crc = "lib64" -BASE_LIB_tune-cortexa72-crc-crypto = "lib64" +BASE_LIB_tune-cortexa72-crypto = "lib64"
Signature · 1 line
2.31.1