Skip to contentSkip to conversation

crypto/ipsec_mb: fix premature dereference

PATCH Applied Piotr Bronowski 2 participants 2 messages Jan 16, 2022 – Feb 8, 2022 Crypto API

lore
Share & tools
lore

Piotr Bronowski

author
#0 lore raw

PATCH 1/1 crypto/ipsec_mb: fix premature dereference

This patch removes coverity defect CID 374380:
Null pointer dereferences (REVERSE_INULL)

Coverity issue: CID 374380

Fixes 918fd2f1466b ("crypto/ipsec_mb: move aesni_mb PMD")
Cc [email protected]
Signed-off-by Piotr Bronowski <[email protected]>
---
 drivers/crypto/ipsec_mb/ipsec_mb_private.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/ipsec_mb/ipsec_mb_private.h +2 -2
index 866722d6f4..e53101acf1 100644
@@ -191,13 +191,13 @@ ipsec_mb_parse_xform(const struct rte_crypto_sym_xform *xform,
 			const struct rte_crypto_sym_xform **cipher_xform,
 			const struct rte_crypto_sym_xform **aead_xform)
 {
-	const struct rte_crypto_sym_xform *next = xform->next;
-
 	if (xform == NULL) {
 		*mode = IPSEC_MB_OP_NOT_SUPPORTED;
 		return -ENOTSUP;
 	}
 
+	const struct rte_crypto_sym_xform *next = xform->next;
+
 	if (xform->type == RTE_CRYPTO_SYM_XFORM_CIPHER) {
 		if (next == NULL) {
 			if (xform->cipher.op == RTE_CRYPTO_CIPHER_OP_ENCRYPT) {
Signature · 13 lines
2.30.2

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.