Skip to contentSkip to conversation

package/qt5/qt5webkit: widgets are mandatory

PATCH In review Fabrice Fontaine 4 participants 8 messages Jan 16, 2022 – Jan 31, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 package/qt5/qt5webkit: widgets are mandatory

Fix the following build failure raised since bump to version 5.212.0-alpha4 in commit df0b0fe6919c0d0f3750f439a3cfa765232bd569:

CMake Error at /home/fabrice/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/cmake/Qt5/Qt5Config.cmake:28 (find_package):
Could not find a package configuration file provided by "Qt5Widgets" with
any of the following names:

Qt5WidgetsConfig.cmake
qt5widgets-config.cmake

Add the installation prefix of "Qt5Widgets" to CMAKE_PREFIX_PATH or set "Qt5Widgets_DIR" to a directory containing one of the above files. If "Qt5Widgets" provides a separate development package or SDK, be sure it has been installed.
Call Stack (most recent call first):
Source/cmake/OptionsQt.cmake:646 (find_package) Source/cmake/WebKitCommon.cmake:51 (include)
CMakeLists.txt:137 (include)

Fixes:
- No autobuilder failures (yet)

---
 package/qt5/qt5webkit/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/qt5/qt5webkit/Config.in +1 -0
index b7beb2b252..68b679dfcd 100644
@@ -17,6 +17,7 @@ config BR2_PACKAGE_QT5WEBKIT
 	select BR2_PACKAGE_LIBPNG
 	select BR2_PACKAGE_QT5BASE_ICU
 	select BR2_PACKAGE_QT5BASE_GUI
+	select BR2_PACKAGE_QT5BASE_WIDGETS
 	select BR2_PACKAGE_QT5LOCATION
 	select BR2_PACKAGE_QT5SENSORS
 	select BR2_PACKAGE_QT5WEBCHANNEL
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/3 package/qt5/qt5webkit: fix build without opengl

Fix the following build failure without opengl raised since bump to version 5.212.0-alpha4 in commit df0b0fe6919c0d0f3750f439a3cfa765232bd569:

CMake Error at Source/cmake/OptionsQt.cmake:592 (message):
Qt with OpenGL support is required for ENABLE_OPENGL

WebKit2 unconditionally depends on TextureMapperGL.h and tools builds QtTestBrowser which unconditionally depends on QtOpenGL

Fixes:
- http://autobuild.buildroot.org/results/5604555279f99ba0221dd8d0baf9ab4d7cca3aed

---
 package/qt5/qt5webkit/qt5webkit.mk | 11 +++++++++++
 1 file changed, 11 insertions(+)
package/qt5/qt5webkit/qt5webkit.mk +11 -0
index 3af1918a46..de3c428fbe 100644
@@ -20,6 +20,16 @@ QT5WEBKIT_LICENSE = LGPL-2.1+, BSD-3-Clause, BSD-2-Clause
 # in the archive.
 QT5WEBKIT_LICENSE_FILES += LICENSE.LGPLv21
 
+ifeq ($(BR2_PACKAGE_QT5BASE_OPENGL),y)
+QT5WEBKIT_CONF_OPTS += \
+	-DENABLE_OPENGL=ON \
+	-DENABLE_WEBKIT2=ON
+else
+QT5WEBKIT_CONF_OPTS += \
+	-DENABLE_OPENGL=OFF \
+	-DENABLE_WEBKIT2=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_QT5BASE_XCB),y)
 QT5WEBKIT_DEPENDENCIES += xlib_libXcomposite xlib_libXext xlib_libXrender
 endif
@@ -29,6 +39,7 @@ QT5WEBKIT_DEPENDENCIES += qt5declarative
 endif
 
 QT5WEBKIT_CONF_OPTS += \
+	-DENABLE_TOOLS=OFF \
 	-DPORT=Qt \
 	-DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3 \
 	-DUSE_LIBHYPHEN=OFF
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by on v1 2/3
#2 lore raw

Re: [Buildroot] [PATCH 2/3] package/qt5/qt5webkit: fix build without opengl

Quoted 8 lines · Fabrice Fontaine

Fix the following build failure without opengl raised since bump to version 5.212.0-alpha4 in commit df0b0fe6919c0d0f3750f439a3cfa765232bd569:

CMake Error at Source/cmake/OptionsQt.cmake:592 (message):
Qt with OpenGL support is required for ENABLE_OPENGL

Quoted 7 lines

WebKit2 unconditionally depends on TextureMapperGL.h and tools builds QtTestBrowser which unconditionally depends on QtOpenGL

Fixes:
- http://autobuild.buildroot.org/results/5604555279f99ba0221dd8d0baf9ab4d7cca3aed

Quoted 36 lines
---
 package/qt5/qt5webkit/qt5webkit.mk | 11 +++++++++++
 1 file changed, 11 insertions(+)
package/qt5/qt5webkit/qt5webkit.mk +11 -1
index 3af1918a46..de3c428fbe 100644
@@ -20,6 +20,16 @@ QT5WEBKIT_LICENSE = LGPL-2.1+, BSD-3-Clause, BSD-2-Clause
 # in the archive.
 QT5WEBKIT_LICENSE_FILES += LICENSE.LGPLv21
 
+ifeq ($(BR2_PACKAGE_QT5BASE_OPENGL),y)
+QT5WEBKIT_CONF_OPTS += \
+       -DENABLE_OPENGL=ON \
+       -DENABLE_WEBKIT2=ON
+else
+QT5WEBKIT_CONF_OPTS += \
+       -DENABLE_OPENGL=OFF \
+       -DENABLE_WEBKIT2=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_QT5BASE_XCB),y)
 QT5WEBKIT_DEPENDENCIES += xlib_libXcomposite xlib_libXext xlib_libXrender
 endif
@@ -29,6 +39,7 @@ QT5WEBKIT_DEPENDENCIES += qt5declarative
 endif
 
 QT5WEBKIT_CONF_OPTS += \
+       -DENABLE_TOOLS=OFF \
        -DPORT=Qt \
        -DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3 \
        -DUSE_LIBHYPHEN=OFF
--

2.34.1

Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Reviewed-by Tested-by
#3 lore raw

Re: [Buildroot] [PATCH 2/3] package/qt5/qt5webkit: fix build without opengl

Quoted 55 lines · James Hilliard
Quoted 8 lines · Fabrice Fontaine

Fix the following build failure without opengl raised since bump to version 5.212.0-alpha4 in commit df0b0fe6919c0d0f3750f439a3cfa765232bd569:

CMake Error at Source/cmake/OptionsQt.cmake:592 (message):
Qt with OpenGL support is required for ENABLE_OPENGL

Quoted 7 lines

WebKit2 unconditionally depends on TextureMapperGL.h and tools builds QtTestBrowser which unconditionally depends on QtOpenGL

Fixes:
- http://autobuild.buildroot.org/results/5604555279f99ba0221dd8d0baf9ab4d7cca3aed

Quoted 36 lines
---
 package/qt5/qt5webkit/qt5webkit.mk | 11 +++++++++++
 1 file changed, 11 insertions(+)
package/qt5/qt5webkit/qt5webkit.mk +11 -1
index 3af1918a46..de3c428fbe 100644
@@ -20,6 +20,16 @@ QT5WEBKIT_LICENSE = LGPL-2.1+, BSD-3-Clause, BSD-2-Clause
 # in the archive.
 QT5WEBKIT_LICENSE_FILES += LICENSE.LGPLv21
 
+ifeq ($(BR2_PACKAGE_QT5BASE_OPENGL),y)
+QT5WEBKIT_CONF_OPTS += \
+       -DENABLE_OPENGL=ON \
+       -DENABLE_WEBKIT2=ON
+else
+QT5WEBKIT_CONF_OPTS += \
+       -DENABLE_OPENGL=OFF \
+       -DENABLE_WEBKIT2=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_QT5BASE_XCB),y)
 QT5WEBKIT_DEPENDENCIES += xlib_libXcomposite xlib_libXext xlib_libXrender
 endif
@@ -29,6 +39,7 @@ QT5WEBKIT_DEPENDENCIES += qt5declarative
 endif
 
 QT5WEBKIT_CONF_OPTS += \
+       -DENABLE_TOOLS=OFF \
        -DPORT=Qt \
        -DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3 \
        -DUSE_LIBHYPHEN=OFF
--

2.34.1

Quoted 8 lines
Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw

PATCH 3/3 package/qt5/qt5webkit: build shared core

In reply to Fabrice Fontaine

Build JavaScriptCore and WebCore as shared libraries to avoid a build failure

Fixes:
- No autobuilder failures (yet)

---
 package/qt5/qt5webkit/qt5webkit.mk | 1 +
 1 file changed, 1 insertion(+)
package/qt5/qt5webkit/qt5webkit.mk +1 -0
index de3c428fbe..565c57e813 100644
@@ -42,6 +42,7 @@ QT5WEBKIT_CONF_OPTS += \
 	-DENABLE_TOOLS=OFF \
 	-DPORT=Qt \
 	-DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3 \
+	-DSHARED_CORE=ON \
 	-DUSE_LIBHYPHEN=OFF
 
 $(eval $(cmake-package))
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by Tested-by on v1 3/3
#5 lore raw

Re: [Buildroot] [PATCH 3/3] package/qt5/qt5webkit: build shared core

Quoted 27 lines · Fabrice Fontaine

Build JavaScriptCore and WebCore as shared libraries to avoid a build failure

Fixes:
- No autobuilder failures (yet)

---
 package/qt5/qt5webkit/qt5webkit.mk | 1 +
 1 file changed, 1 insertion(+)
package/qt5/qt5webkit/qt5webkit.mk +1 -1
index de3c428fbe..565c57e813 100644
@@ -42,6 +42,7 @@ QT5WEBKIT_CONF_OPTS += \
        -DENABLE_TOOLS=OFF \
        -DPORT=Qt \
        -DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3 \
+       -DSHARED_CORE=ON \
        -DUSE_LIBHYPHEN=OFF
 
 $(eval $(cmake-package))
--

2.34.1

Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Reviewed-by Tested-by on v1 1/3
#6 lore raw
In reply to Fabrice Fontaine
Quoted 43 lines · Fabrice Fontaine

Fix the following build failure raised since bump to version 5.212.0-alpha4 in commit df0b0fe6919c0d0f3750f439a3cfa765232bd569:

CMake Error at /home/fabrice/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/cmake/Qt5/Qt5Config.cmake:28 (find_package):
Could not find a package configuration file provided by "Qt5Widgets" with
any of the following names:

Qt5WidgetsConfig.cmake
qt5widgets-config.cmake

Add the installation prefix of "Qt5Widgets" to CMAKE_PREFIX_PATH or set "Qt5Widgets_DIR" to a directory containing one of the above files. If "Qt5Widgets" provides a separate development package or SDK, be sure it has been installed.
Call Stack (most recent call first):
Source/cmake/OptionsQt.cmake:646 (find_package) Source/cmake/WebKitCommon.cmake:51 (include)
CMakeLists.txt:137 (include)

Fixes:
- No autobuilder failures (yet)

---
 package/qt5/qt5webkit/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/qt5/qt5webkit/Config.in +1 -1
index b7beb2b252..68b679dfcd 100644
@@ -17,6 +17,7 @@ config BR2_PACKAGE_QT5WEBKIT
        select BR2_PACKAGE_LIBPNG
        select BR2_PACKAGE_QT5BASE_ICU
        select BR2_PACKAGE_QT5BASE_GUI
+       select BR2_PACKAGE_QT5BASE_WIDGETS
        select BR2_PACKAGE_QT5LOCATION
        select BR2_PACKAGE_QT5SENSORS
        select BR2_PACKAGE_QT5WEBCHANNEL
--

2.34.1

Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#7 lore raw
In reply to Fabrice Fontaine
Quoted 19 lines · Fabrice Fontaine

Fix the following build failure raised since bump to version 5.212.0-alpha4 in commit df0b0fe6919c0d0f3750f439a3cfa765232bd569:

CMake Error at /home/fabrice/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/cmake/Qt5/Qt5Config.cmake:28 (find_package):
Could not find a package configuration file provided by "Qt5Widgets" with
any of the following names:

Qt5WidgetsConfig.cmake
qt5widgets-config.cmake

Add the installation prefix of "Qt5Widgets" to CMAKE_PREFIX_PATH or set "Qt5Widgets_DIR" to a directory containing one of the above files. If "Qt5Widgets" provides a separate development package or SDK, be sure it has been installed.
Call Stack (most recent call first):
Source/cmake/OptionsQt.cmake:646 (find_package) Source/cmake/WebKitCommon.cmake:51 (include) CMakeLists.txt:137 (include)

Quoted 4 lines

Fixes:
- No autobuilder failures (yet)

Series applied to master, thanks.

Regards,
Arnout

Quoted 9 lines
---
  package/qt5/qt5webkit/Config.in | 1 +
  1 file changed, 1 insertion(+)
package/qt5/qt5webkit/Config.in +0 -0
index b7beb2b252..68b679dfcd 100644

package/qt5/qt5webkit/Config.in config BR2_PACKAGE_QT5WEBKIT · line 23

Quoted 7 lines
package/qt5/qt5webkit/Config.in +1 -0
@@ -17,6 +17,7 @@ config BR2_PACKAGE_QT5WEBKIT
  	select BR2_PACKAGE_LIBPNG
  	select BR2_PACKAGE_QT5BASE_ICU
  	select BR2_PACKAGE_QT5BASE_GUI
+	select BR2_PACKAGE_QT5BASE_WIDGETS
  	select BR2_PACKAGE_QT5LOCATION
  	select BR2_PACKAGE_QT5SENSORS
  	select BR2_PACKAGE_QT5WEBCHANNEL

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot