Skip to contentSkip to conversation

i2c: mvtwsi: Add compatible string for allwinner, sun4i-a10-i2c

PATCH Applied Chris Morgan 4 participants 4 messages Jan 7, 2022 – Jan 19, 2022 I2C

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: mvtwsi: Add compatible string for allwinner, sun4i-a10-i2c

From: Chris Morgan <[email protected]>

This adds a compatible string for the Allwinner Sun4i-A10 I2C controller. Without this, boards based on the R8 and A13 (at a minimum) fail to boot.

---
 drivers/i2c/mvtwsi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/mvtwsi.c +1 -0
index ff21e3c52b..979b825eec 100644
@@ -900,6 +900,7 @@ static const struct dm_i2c_ops mvtwsi_i2c_ops = {
 static const struct udevice_id mvtwsi_i2c_ids[] = {
 	{ .compatible = "marvell,mv64xxx-i2c", },
 	{ .compatible = "marvell,mv78230-i2c", },
+	{ .compatible = "allwinner,sun4i-a10-i2c", },
 	{ .compatible = "allwinner,sun6i-a31-i2c", },
 	{ /* sentinel */ }
 };
Signature · 1 line
2.30.2
Acked-by Akash Gajjar on v1 1/1
#1 lore raw
Quoted 27 lines · Chris Morgan

From: Chris Morgan <[email protected]>

This adds a compatible string for the Allwinner Sun4i-A10 I2C controller. Without this, boards based on the R8 and A13 (at a minimum) fail to boot.

---
 drivers/i2c/mvtwsi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/mvtwsi.c +1 -1
index ff21e3c52b..979b825eec 100644
@@ -900,6 +900,7 @@ static const struct dm_i2c_ops mvtwsi_i2c_ops = {
 static const struct udevice_id mvtwsi_i2c_ids[] = {
        { .compatible = "marvell,mv64xxx-i2c", },
        { .compatible = "marvell,mv78230-i2c", },
+       { .compatible = "allwinner,sun4i-a10-i2c", },
        { .compatible = "allwinner,sun6i-a31-i2c", },
        { /* sentinel */ }
 };
--

2.30.2

#2 lore raw
In reply to Chris Morgan

On Fri, 7 Jan 2022 11:52:54 -0600
Chris Morgan <[email protected]> wrote:

Hi Chris,

Quoted 7 lines

From: Chris Morgan <[email protected]>

This adds a compatible string for the Allwinner Sun4i-A10 I2C controller. Without this, boards based on the R8 and A13 (at a minimum) fail to boot.

Applied to sunxi/master, thanks!

Out of curiosity, can you say what "fail to boot" means, exactly? I see that indeed i2c in U-Boot proper got lost when I2C was moved to DM in the v2022.01 merge window, but that didn't have any visible effect apart from the "i2c" command not working on my BananaPi. Ethernet, USB and Linux boot worked fine, still.

Cheers,
Andre

Quoted 16 lines
---
 drivers/i2c/mvtwsi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/mvtwsi.c +1 -0
index ff21e3c52b..979b825eec 100644
@@ -900,6 +900,7 @@ static const struct dm_i2c_ops mvtwsi_i2c_ops = {
 static const struct udevice_id mvtwsi_i2c_ids[] = {
 	{ .compatible = "marvell,mv64xxx-i2c", },
 	{ .compatible = "marvell,mv78230-i2c", },
+	{ .compatible = "allwinner,sun4i-a10-i2c", },
 	{ .compatible = "allwinner,sun6i-a31-i2c", },
 	{ /* sentinel */ }
 };
#3 lore raw
Quoted 13 lines · Andre Przywara

On Fri, 7 Jan 2022 11:52:54 -0600
Chris Morgan <[email protected]> wrote:

Hi Chris,

Quoted 7 lines

From: Chris Morgan <[email protected]>

This adds a compatible string for the Allwinner Sun4i-A10 I2C controller. Without this, boards based on the R8 and A13 (at a minimum) fail to boot.

Quoted 7 lines

Applied to sunxi/master, thanks!

Out of curiosity, can you say what "fail to boot" means, exactly? I see that indeed i2c in U-Boot proper got lost when I2C was moved to DM in the v2022.01 merge window, but that didn't have any visible effect apart from the "i2c" command not working on my BananaPi. Ethernet, USB and Linux boot worked fine, still.

It must have been something in my defconfig. I can confirm using a pristine master branch (without this patch applied) that it does boot correctly, at least via FEL. Sorry for the confusion.

Thank you.

Quoted 22 lines

Cheers,
Andre

Quoted 16 lines
---
 drivers/i2c/mvtwsi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/mvtwsi.c +1 -0
index ff21e3c52b..979b825eec 100644
@@ -900,6 +900,7 @@ static const struct dm_i2c_ops mvtwsi_i2c_ops = {
 static const struct udevice_id mvtwsi_i2c_ids[] = {
 	{ .compatible = "marvell,mv64xxx-i2c", },
 	{ .compatible = "marvell,mv78230-i2c", },
+	{ .compatible = "allwinner,sun4i-a10-i2c", },
 	{ .compatible = "allwinner,sun6i-a31-i2c", },
 	{ /* sentinel */ }
 };