i2c: mvtwsi: Add compatible string for allwinner, sun4i-a10-i2c
PATCH 1/1 i2c: mvtwsi: Add compatible string for allwinner, sun4i-a10-i2c
From: Chris Morgan <[email protected]>
This adds a compatible string for the Allwinner Sun4i-A10 I2C controller. Without this, boards based on the R8 and A13 (at a minimum) fail to boot.
--- drivers/i2c/mvtwsi.c | 1 + 1 file changed, 1 insertion(+)
drivers/i2c/mvtwsi.c +1 -0
@@ -900,6 +900,7 @@ static const struct dm_i2c_ops mvtwsi_i2c_ops = {static const struct udevice_id mvtwsi_i2c_ids[] = { { .compatible ="marvell,mv64xxx-i2c" , }, { .compatible ="marvell,mv78230-i2c" , }, + { .compatible ="allwinner,sun4i-a10-i2c" , }, { .compatible ="allwinner,sun6i-a31-i2c" , }, {/* sentinel */ } };
Signature · 1 line
2.30.2
Quoted 27 lines · Chris Morgan
From: Chris Morgan <[email protected]>
This adds a compatible string for the Allwinner Sun4i-A10 I2C controller. Without this, boards based on the R8 and A13 (at a minimum) fail to boot.
Signed-off-by Chris Morgan <[email protected]>--- drivers/i2c/mvtwsi.c | 1 + 1 file changed, 1 insertion(+)drivers/i2c/mvtwsi.c +1
-1@@ -900,6 +900,7 @@ static const struct dm_i2c_ops mvtwsi_i2c_ops = {static const struct udevice_id mvtwsi_i2c_ids[] = { { .compatible ="marvell,mv64xxx-i2c" , }, { .compatible ="marvell,mv78230-i2c" , }, + { .compatible ="allwinner,sun4i-a10-i2c" , }, { .compatible ="allwinner,sun6i-a31-i2c" , }, {/* sentinel */ } }; --2.30.2
Andre Przywara
AppliedOn Fri, 7 Jan 2022 11:52:54 -0600
Chris Morgan <[email protected]> wrote:
Hi Chris,
Quoted 7 lines
From: Chris Morgan <[email protected]>
This adds a compatible string for the Allwinner Sun4i-A10 I2C controller. Without this, boards based on the R8 and A13 (at a minimum) fail to boot.
Signed-off-by Chris Morgan <[email protected]>
Applied to sunxi/master, thanks!
Out of curiosity, can you say what "fail to boot" means, exactly? I see that indeed i2c in U-Boot proper got lost when I2C was moved to DM in the v2022.01 merge window, but that didn't have any visible effect apart from the "i2c" command not working on my BananaPi. Ethernet, USB and Linux boot worked fine, still.
Cheers,
Andre
Quoted 16 lines
--- drivers/i2c/mvtwsi.c | 1 + 1 file changed, 1 insertion(+)drivers/i2c/mvtwsi.c +1
-0@@ -900,6 +900,7 @@ static const struct dm_i2c_ops mvtwsi_i2c_ops = {static const struct udevice_id mvtwsi_i2c_ids[] = { { .compatible ="marvell,mv64xxx-i2c" , }, { .compatible ="marvell,mv78230-i2c" , }, + { .compatible ="allwinner,sun4i-a10-i2c" , }, { .compatible ="allwinner,sun6i-a31-i2c" , }, {/* sentinel */ } };
Quoted 13 lines · Andre Przywara
On Fri, 7 Jan 2022 11:52:54 -0600
Chris Morgan <[email protected]> wrote:Hi Chris,
Quoted 7 lines
From: Chris Morgan <[email protected]>
This adds a compatible string for the Allwinner Sun4i-A10 I2C controller. Without this, boards based on the R8 and A13 (at a minimum) fail to boot.
Signed-off-by Chris Morgan <[email protected]>
Quoted 7 lines
Applied to sunxi/master, thanks!
Out of curiosity, can you say what "fail to boot" means, exactly? I see that indeed i2c in U-Boot proper got lost when I2C was moved to DM in the v2022.01 merge window, but that didn't have any visible effect apart from the "i2c" command not working on my BananaPi. Ethernet, USB and Linux boot worked fine, still.
It must have been something in my defconfig. I can confirm using a pristine master branch (without this patch applied) that it does boot correctly, at least via FEL. Sorry for the confusion.
Thank you.
Quoted 22 lines
Cheers,
AndreQuoted 16 lines
--- drivers/i2c/mvtwsi.c | 1 + 1 file changed, 1 insertion(+)drivers/i2c/mvtwsi.c +1
-0@@ -900,6 +900,7 @@ static const struct dm_i2c_ops mvtwsi_i2c_ops = {static const struct udevice_id mvtwsi_i2c_ids[] = { { .compatible ="marvell,mv64xxx-i2c" , }, { .compatible ="marvell,mv78230-i2c" , }, + { .compatible ="allwinner,sun4i-a10-i2c" , }, { .compatible ="allwinner,sun6i-a31-i2c" , }, {/* sentinel */ } };