serial: npcm: Add support for Nuvoton NPCM SoCs
PATCH 1/1 serial: npcm: Add support for Nuvoton NPCM SoCs
Add Nuvoton BMC NPCM7xx/NPCM8xx uart driver
--- drivers/serial/Kconfig | 7 ++ drivers/serial/Makefile | 1 + drivers/serial/serial_npcm.c | 151 +++++++++++++++++++++++++++++++++++ 3 files changed, 159 insertions(+) create mode 100644 drivers/serial/serial_npcm.c
drivers/serial/Kconfig +7 -0
@@ -920,6 +920,13 @@ config MPC8XX_CONS depends on MPC8xx default y +config NPCM_SERIAL + bool "UART driver for Nuvoton NPCM BMC" + depends on DM_SERIAL + help + Select this to enable UART support for Nuvoton BMCs + (NPCM7xx and NPCM8xx) + config XEN_SERIAL bool "XEN serial support" depends on XEN
drivers/serial/Makefile +1 -0
@@ -73,6 +73,7 @@ obj-$(CONFIG_OWL_SERIAL) += serial_owl.o obj-$(CONFIG_OMAP_SERIAL) += serial_omap.o obj-$(CONFIG_MTK_SERIAL) += serial_mtk.o obj-$(CONFIG_MT7620_SERIAL) += serial_mt7620.o +obj-$(CONFIG_NPCM_SERIAL) += serial_npcm.o obj-$(CONFIG_SIFIVE_SERIAL) += serial_sifive.o obj-$(CONFIG_XEN_SERIAL) += serial_xen.o
drivers/serial/serial_npcm.c new file +151 -0
151 lines not on this page · raw message
Signature · 1 line
2.17.1
Hi Stanley,
Quoted 16 lines · Stanley Chu
Add Nuvoton BMC NPCM7xx/NPCM8xx uart driver
Signed-off-by Stanley Chu <[email protected]>--- drivers/serial/Kconfig | 7 ++ drivers/serial/Makefile | 1 + drivers/serial/serial_npcm.c | 151 +++++++++++++++++++++++++++++++++++ 3 files changed, 159 insertions(+) create mode 100644 drivers/serial/serial_npcm.cdrivers/serial/Kconfig +0
-0
drivers/serial/Kconfig config MPC8XX_CONS · line 928
Quoted 9 lines
drivers/serial/Kconfig +6
-0@@ -920,6 +920,13 @@ config MPC8XX_CONS depends on MPC8xx default y +config NPCM_SERIAL + bool "UART driver for Nuvoton NPCM BMC" + depends on DM_SERIAL + help + Select this to enable UART support for Nuvoton BMCs + (NPCM7xx and NPCM8xx)
What features does it support? Please expand this a bit.
Quoted 54 lines
drivers/serial/Kconfig +1
-0+ config XEN_SERIAL bool "XEN serial support" depends on XENdrivers/serial/Makefile +1
-0@@ -73,6 +73,7 @@ obj-$(CONFIG_OWL_SERIAL) += serial_owl.o obj-$(CONFIG_OMAP_SERIAL) += serial_omap.o obj-$(CONFIG_MTK_SERIAL) += serial_mtk.o obj-$(CONFIG_MT7620_SERIAL) += serial_mt7620.o +obj-$(CONFIG_NPCM_SERIAL) += serial_npcm.o obj-$(CONFIG_SIFIVE_SERIAL) += serial_sifive.o obj-$(CONFIG_XEN_SERIAL) += serial_xen.odrivers/serial/serial_npcm.c new file +32
-0@@ -0,0 +1,151 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright (c) 2021 Nuvoton Technology Corp. +*/ + +#include <common.h> +#include <clk.h> +#include <dm.h> +#include <serial.h> + +struct npcm_uart { +union { +u32 rbr; +u32 thr; +u32 dll; + }; +union { +u32 ier; +u32 dlm; + }; +union { +u32 iir; +u32 fcr; + }; +u32 lcr; +u32 mcr; +u32 lsr; +u32 msr; +u32 tor; +}; + +#define LCR_WLS_8BITS 3
drivers/serial/serial_npcm.c line 42
Quoted 10 lines
drivers/serial/serial_npcm.c new file +10
-0+#define FCR_TFR BIT(2) +#define FCR_RFR BIT(1) +#define FCR_FME BIT(0) +#define LSR_THRE BIT(5) +#define LSR_RFDR BIT(0) +#define LCR_DLAB BIT(7) + +struct npcm_serial_plat { +struct npcm_uart *reg; +u32 uart_clk;
comment that
drivers/serial/serial_npcm.c line 51
Quoted 9 lines
drivers/serial/serial_npcm.c new file +9
-0+}; + +static int npcm_serial_pending (struct udevice *dev,bool input) +{ +struct npcm_serial_plat *plat =dev_get_plat (dev); +struct npcm_uart *uart = plat->reg; + +if (input) +return (readb (&uart->lsr) &LSR_RFDR );
drop outer brackets
drivers/serial/serial_npcm.c line 53
Quoted 2 lines
drivers/serial/serial_npcm.c new file +2
-0+else +return !(readb (&uart->lsr) &LSR_THRE );
and here
drivers/serial/serial_npcm.c line 62
Quoted 9 lines
drivers/serial/serial_npcm.c new file +9
-0+} + +static int npcm_serial_putc (struct udevice *dev,const char ch) +{ +struct npcm_serial_plat *plat =dev_get_plat (dev); +struct npcm_uart *uart = plat->reg; + +while (!(readb (&uart->lsr) &LSR_THRE )) + ;
You cannot loop here. Return -EAGAIN instead if you cannot print.
drivers/serial/serial_npcm.c line 75
Quoted 13 lines
drivers/serial/serial_npcm.c new file +13
-0+ +writeb (ch, &uart->thr); + +return 0 ; +} + +static int npcm_serial_getc (struct udevice *dev) +{ +struct npcm_serial_plat *plat =dev_get_plat (dev); +struct npcm_uart *uart = plat->reg; + +while (!(readb (&uart->lsr) &LSR_RFDR )) + ;
You cannot loop here. Return -EAGAIN instead. See __serial_getc()
Quoted 25 lines
drivers/serial/serial_npcm.c new file +25
-0+ +return readb (&uart->rbr); +} + +static int npcm_serial_setbrg (struct udevice *dev,int baudrate) +{ +struct npcm_serial_plat *plat =dev_get_plat (dev); +struct npcm_uart *uart = plat->reg; +u16 divisor; + +/* BaudOut = UART Clock / (16 * [Divisor + 2]) */ + divisor =DIV_ROUND_CLOSEST (plat->uart_clk,16 * baudrate +2 ) -2 ; + +setbits_8 (&uart->lcr,LCR_DLAB ); +writeb (divisor &0xff , &uart->dll); +writeb (divisor >>8 , &uart->dlm); +clrbits_8 (&uart->lcr,LCR_DLAB ); + +return 0 ; +} + +static int npcm_serial_probe (struct udevice *dev) +{ +struct npcm_serial_plat *plat =dev_get_plat (dev); +struct npcm_uart *uart = plat->reg;
drivers/serial/serial_npcm.c line 110
Quoted 10 lines
drivers/serial/serial_npcm.c new file +10
-0+struct clk clk; +u32 freq; +int ret; + + plat->reg =dev_read_addr_ptr (dev); + freq =dev_read_u32_default (dev,"clock-frequency" ,0 ); + + ret =clk_get_by_index (dev,0 , &clk); +if (ret <0 ) { +printf ("Cannot get clk for uart\n" );
log_debug() would be better to avoid increasing code size
Quoted 42 lines
drivers/serial/serial_npcm.c new file +41
-1+return ret; + } + ret =clk_set_rate (&clk, freq); +if (ret <0 ) +return ret; + plat->uart_clk = ret; + +/* Disable all interrupt */ +writeb (0 , &uart->ier); + +/* Set 8 bit, 1 stop, no parity */ +writeb (LCR_WLS_8BITS , &uart->lcr); + +/* Reset RX/TX FIFO */ +writeb (FCR_FME |FCR_RFR |FCR_TFR , &uart->fcr); + +return 0 ; +} + +static const struct dm_serial_ops npcm_serial_ops = { + .getc = npcm_serial_getc, + .setbrg = npcm_serial_setbrg, + .putc = npcm_serial_putc, + .pending = npcm_serial_pending, +}; + +static const struct udevice_id npcm_serial_ids[] = { + { .compatible ="nuvoton,npcm750-uart" }, + { .compatible ="nuvoton,npcm845-uart" }, + { } +}; + +U_BOOT_DRIVER (serial_npcm) = { + .name ="serial_npcm" , + .id =UCLASS_SERIAL , + .of_match = npcm_serial_ids, + .plat_auto =sizeof (struct npcm_serial_plat ), + .probe = npcm_serial_probe, + .ops = &npcm_serial_ops, + .flags =DM_FLAG_PRE_RELOC , +}; --
Quoted 2 lines
2.17.1
Regards,
Simon