Skip to contentSkip to conversation

input: fix Kconfig dependency on IIO_BUFFER

PATCH New Julian Braha 1 participant 1 message Jan 17, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 input: fix Kconfig dependency on IIO_BUFFER

When JOYSTICK_ADC is enabled, and IIO_BUFFER is disabled, Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for IIO_BUFFER_CB
Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
Selected by [y]:
- JOYSTICK_ADC [=y] && !UML && INPUT [=y] && INPUT_JOYSTICK [=y] && IIO [=y]

This is because JOYSTICK_ADC selects IIO_BUFFER_CB without selecting or depending on IIO_BUFFER, despite IIO_BUFFER_CB depending on IIO_BUFFER.

This unmet dependency bug was detected by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution.

---
 drivers/input/joystick/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/input/joystick/Kconfig +1 -0
index 3b23078bc7b5..db4135bbd279 100644
@@ -46,6 +46,7 @@ config JOYSTICK_A3D
 config JOYSTICK_ADC
 	tristate "Simple joystick connected over ADC"
 	depends on IIO
+	select IIO_BUFFER
 	select IIO_BUFFER_CB
 	help
 	  Say Y here if you have a simple joystick connected over ADC.
Signature · 1 line
2.32.0