Skip to contentSkip to conversation

btrfs-progs: allow user to insert property compression=none to file.

PATCH In review Li Zhang 3 participants 4 messages Jan 16, 2022 – Feb 16, 2022 Btrfs file system

lore
Share & tools
lore

Li Zhang

author
#0 lore raw

PATCH 1/1 btrfs-progs: allow user to insert property compression=none to file.

1. If the user adds the property "compression=none" to the file, remove the code that converts the None string to an empty string.

---
 cmds/property.c | 2 --
 1 file changed, 2 deletions(-)
cmds/property.c +0 -2
index b3ccc0f..ec1b408 100644
@@ -190,8 +190,6 @@ static int prop_compression(enum prop_object_type type,
 	xattr_name[XATTR_BTRFS_PREFIX_LEN + strlen(name)] = '\0';
 
 	if (value) {
-		if (strcmp(value, "no") == 0 || strcmp(value, "none") == 0)
-			value = "";
 		sret = fsetxattr(fd, xattr_name, value, strlen(value), 0);
 	} else {
 		sret = fgetxattr(fd, xattr_name, NULL, 0);
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 2 lines · Li Zhang

1. If the user adds the property "compression=none" to the file, remove the code that converts the None string to an empty string.

This is related to 5548c8c6f55b ("btrfs: props: change how empty value is interpreted") and needs some explanation that what it does on old and new kernel. Maybe some backward compatibility code in progs is needed to take the version into account.

Quoted 21 lines
---
 cmds/property.c | 2 --
 1 file changed, 2 deletions(-)
cmds/property.c +0 -2
index b3ccc0f..ec1b408 100644
@@ -190,8 +190,6 @@ static int prop_compression(enum prop_object_type type,
 	xattr_name[XATTR_BTRFS_PREFIX_LEN + strlen(name)] = '\0';
 
 	if (value) {
-		if (strcmp(value, "no") == 0 || strcmp(value, "none") == 0)
-			value = "";
 		sret = fsetxattr(fd, xattr_name, value, strlen(value), 0);
 	} else {
 		sret = fgetxattr(fd, xattr_name, NULL, 0);
Signature · 1 line
1.8.3.1
author
#2 lore raw

Old behavior:
# Insert compressed none in the file

$ btrfs property set file compression none
$ btrfs property gets file
# no output, (none value converted to empty string)

New behavior:
# Insert compressed none in the file

$ btrfs property set file compression none
$ btrfs property gets file
compression=none
(with compression=none inserted in the file's xattr)

Convert the attribute compression=none to an empty string "", which was introduced in commit df11e2787b5b57ecdb313f2725dc5c9a5e549576(btrfs-progs), according to the comments, in the past it seemed that the empty string "" represented
no compression, but after commit 5548c8c6f55b(btrfs-devel), the character The string
"none" means no compression. so the command
"btrfs property set <file> compression none" is not working.

Quoted 31 lines · David Sterba <[email protected]> 于2022年1月17日周一 21:45写道:
Quoted 2 lines · Li Zhang

1. If the user adds the property "compression=none" to the file, remove the code that converts the None string to an empty string.

This is related to 5548c8c6f55b ("btrfs: props: change how empty value is interpreted") and needs some explanation that what it does on old and new kernel. Maybe some backward compatibility code in progs is needed to take the version into account.

Quoted 21 lines
---
 cmds/property.c | 2 --
 1 file changed, 2 deletions(-)
cmds/property.c +0 -3
index b3ccc0f..ec1b408 100644
@@ -190,8 +190,6 @@ static int prop_compression(enum prop_object_type type,
      xattr_name[XATTR_BTRFS_PREFIX_LEN + strlen(name)] = '\0';
 
      if (value) {
-             if (strcmp(value, "no") == 0 || strcmp(value, "none") == 0)
-                     value = "";
              sret = fsetxattr(fd, xattr_name, value, strlen(value), 0);
      } else {
              sret = fgetxattr(fd, xattr_name, NULL, 0);
--

1.8.3.1

#3 lore raw

Furthermore, that kernel commit has a big problem for a lot of compression users:

No way to disable compression on a per-file basis, if using
compression= mount option.

As progs always convert "none"/"no" to "", this leads means older progs on newer kernel will use default value, and no way to really set "none"/"no".

This is already a big behavior breakage.

Thanks,
Qu

Quoted 55 lines · li zhang

Old behavior:
# Insert compressed none in the file

$ btrfs property set file compression none
$ btrfs property gets file
# no output, (none value converted to empty string)

New behavior:
# Insert compressed none in the file

$ btrfs property set file compression none
$ btrfs property gets file
compression=none
(with compression=none inserted in the file's xattr)

Convert the attribute compression=none to an empty string "", which was introduced in commit df11e2787b5b57ecdb313f2725dc5c9a5e549576(btrfs-progs), according to the comments, in the past it seemed that the empty string "" represented
no compression, but after commit 5548c8c6f55b(btrfs-devel), the character The string
"none" means no compression. so the command
"btrfs property set <file> compression none" is not working.

Quoted 31 lines · David Sterba <[email protected]> 于2022年1月17日周一 21:45写道:
Quoted 2 lines · Li Zhang

1. If the user adds the property "compression=none" to the file, remove the code that converts the None string to an empty string.

This is related to 5548c8c6f55b ("btrfs: props: change how empty value is interpreted") and needs some explanation that what it does on old and new kernel. Maybe some backward compatibility code in progs is needed to take the version into account.

Quoted 21 lines
---
  cmds/property.c | 2 --
  1 file changed, 2 deletions(-)
cmds/property.c +0 -3
index b3ccc0f..ec1b408 100644
@@ -190,8 +190,6 @@ static int prop_compression(enum prop_object_type type,
       xattr_name[XATTR_BTRFS_PREFIX_LEN + strlen(name)] = '\0';
 
       if (value) {
-             if (strcmp(value, "no") == 0 || strcmp(value, "none") == 0)
-                     value = "";
               sret = fsetxattr(fd, xattr_name, value, strlen(value), 0);
       } else {
               sret = fgetxattr(fd, xattr_name, NULL, 0);
--

1.8.3.1