Skip to contentSkip to conversation

tools/virtio: fix virtio_test execution

PATCH In review Stefano Garzarella 2 participants 2 messages Jan 18, 2022 – Jan 19, 2022 virtio core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/virtio: fix virtio_test execution

virtio_test hangs on __vring_new_virtqueue() because vqs_list_lock is not initialized.

Let's initialize it in vdev_info_init().

---
 tools/virtio/virtio_test.c | 1 +
 1 file changed, 1 insertion(+)
tools/virtio/virtio_test.c +1 -0
index cb3f29c09aff..23f142af544a 100644
@@ -130,6 +130,7 @@ static void vdev_info_init(struct vdev_info* dev, unsigned long long features)
 	memset(dev, 0, sizeof *dev);
 	dev->vdev.features = features;
 	INIT_LIST_HEAD(&dev->vdev.vqs);
+	spin_lock_init(&dev->vdev.vqs_list_lock);
 	dev->buf_size = 1024;
 	dev->buf = malloc(dev->buf_size);
 	assert(dev->buf);
Signature · 6 lines
2.31.1

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Stefano Garzarella

virtio_test hangs on __vring_new_virtqueue() because vqs_list_lock is not initialized.

Let's initialize it in vdev_info_init().

Quoted 19 lines
---
 tools/virtio/virtio_test.c | 1 +
 1 file changed, 1 insertion(+)
tools/virtio/virtio_test.c +1 -1
index cb3f29c09aff..23f142af544a 100644
@@ -130,6 +130,7 @@ static void vdev_info_init(struct vdev_info* dev, unsigned long long features)
        memset(dev, 0, sizeof *dev);
        dev->vdev.features = features;
        INIT_LIST_HEAD(&dev->vdev.vqs);
+       spin_lock_init(&dev->vdev.vqs_list_lock);
        dev->buf_size = 1024;
        dev->buf = malloc(dev->buf_size);
        assert(dev->buf);
--

2.31.1