gpio: idt3243x: Fix an ignored error return from platform_get_irq()
PATCH 1/2 gpio: idt3243x: Fix an ignored error return from platform_get_irq()
The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'parent_irq', so making 'parent_irq' an int.
Eliminate the following coccicheck warning:
./drivers/gpio/gpio-idt3243x.c:167:6-16: WARNING: Unsigned expression compared with zero: parent_irq < 0
--- drivers/gpio/gpio-idt3243x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-idt3243x.c +1 -1
@@ -132,7 +132,7 @@ static int idt_gpio_probe(struct platform_device *pdev)struct device *dev = &pdev->dev;struct gpio_irq_chip *girq;struct idt_gpio_ctrl *ctrl; -unsigned int parent_irq; +int parent_irq;int ngpios;int ret;
Signature · 1 line
2.20.1.7.g153144c
PATCH 2/2 gpio: mpc8xxx: Fix an ignored error return from platform_get_irq()
The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'irqn', so making 'irqn' an int.
Eliminate the following coccicheck warning:
./drivers/gpio/gpio-mpc8xxx.c:391:5-21: WARNING: Unsigned expression compared with zero: mpc8xxx_gc -> irqn < 0
--- drivers/gpio/gpio-mpc8xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-mpc8xxx.c +1 -1
@@ -47,7 +47,7 @@ struct mpc8xxx_gpio_chip { unsigned offset, int value);struct irq_domain *irq; -unsigned int irqn; +int irqn; };/*
Signature · 1 line
2.20.1.7.g153144c
Bartosz Golaszewski
AppliedRe: [PATCH -next 2/2] gpio: mpc8xxx: Fix an ignored error return from platform_get_irq()
Quoted 30 lines · Yang Li
The return from the call to
platform_get_irq()is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'irqn', so making 'irqn' an int.Eliminate the following coccicheck warning:
./drivers/gpio/gpio-mpc8xxx.c:391:5-21: WARNING: Unsigned expression compared with zero:mpc8xxx_gc-> irqn < 0Reported-by Abaci Robot <[email protected]>Fixes 0b39536cc699 ("gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe")Signed-off-by Yang Li <[email protected]>--- drivers/gpio/gpio-mpc8xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpio/gpio-mpc8xxx.c +1
-2@@ -47,7 +47,7 @@ struct mpc8xxx_gpio_chip { unsigned offset, int value);struct irq_domain *irq; -unsigned int irqn; +int irqn; };/* --
Quoted 2 lines
2.20.1.7.g153144c
Queued for fixes, thanks!
Bart
Bartosz Golaszewski
AppliedQuoted 30 lines · Yang Li
The return from the call to
platform_get_irq()is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'parent_irq', so making 'parent_irq' an int.Eliminate the following coccicheck warning:
./drivers/gpio/gpio-idt3243x.c:167:6-16: WARNING: Unsigned expression compared with zero:parent_irq< 0Reported-by Abaci Robot <[email protected]>Fixes 30fee1d7462a ("gpio: idt3243x: Fix IRQ check in idt_gpio_probe")Signed-off-by Yang Li <[email protected]>--- drivers/gpio/gpio-idt3243x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpio/gpio-idt3243x.c +1
-2@@ -132,7 +132,7 @@ static int idt_gpio_probe(struct platform_device *pdev)struct device *dev = &pdev->dev;struct gpio_irq_chip *girq;struct idt_gpio_ctrl *ctrl; -unsigned int parent_irq; +int parent_irq;int ngpios;int ret; --
Quoted 2 lines
2.20.1.7.g153144c
Queued for fixes, thanks!
Bart