Skip to contentSkip to conversation

gpio: idt3243x: Fix an ignored error return from platform_get_irq()

PATCH Applied Yang Li 2 participants 4 messages Jan 19, 2022 – Jan 20, 2022 GPIO

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/2 gpio: idt3243x: Fix an ignored error return from platform_get_irq()

The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'parent_irq', so making 'parent_irq' an int.

Eliminate the following coccicheck warning:
./drivers/gpio/gpio-idt3243x.c:167:6-16: WARNING: Unsigned expression compared with zero: parent_irq < 0

Fixes 30fee1d7462a ("gpio: idt3243x: Fix IRQ check in idt_gpio_probe")
---
 drivers/gpio/gpio-idt3243x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-idt3243x.c +1 -1
index 08493b05be2d..52b8b72ded77 100644
@@ -132,7 +132,7 @@ static int idt_gpio_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct gpio_irq_chip *girq;
 	struct idt_gpio_ctrl *ctrl;
-	unsigned int parent_irq;
+	int parent_irq;
 	int ngpios;
 	int ret;
 
Signature · 1 line
2.20.1.7.g153144c
author
#1 lore raw

PATCH 2/2 gpio: mpc8xxx: Fix an ignored error return from platform_get_irq()

The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'irqn', so making 'irqn' an int.

Eliminate the following coccicheck warning:
./drivers/gpio/gpio-mpc8xxx.c:391:5-21: WARNING: Unsigned expression compared with zero: mpc8xxx_gc -> irqn < 0

Fixes 0b39536cc699 ("gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe")
---
 drivers/gpio/gpio-mpc8xxx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-mpc8xxx.c +1 -1
index 01634c8d27b3..a964e25ea620 100644
@@ -47,7 +47,7 @@ struct mpc8xxx_gpio_chip {
 				unsigned offset, int value);
 
 	struct irq_domain *irq;
-	unsigned int irqn;
+	int irqn;
 };
 
 /*
Signature · 1 line
2.20.1.7.g153144c
#2 lore raw

Re: [PATCH -next 2/2] gpio: mpc8xxx: Fix an ignored error return from platform_get_irq()

Quoted 30 lines · Yang Li

The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'irqn', so making 'irqn' an int.

Eliminate the following coccicheck warning:
./drivers/gpio/gpio-mpc8xxx.c:391:5-21: WARNING: Unsigned expression compared with zero: mpc8xxx_gc -> irqn < 0

Fixes 0b39536cc699 ("gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe")
---
 drivers/gpio/gpio-mpc8xxx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-mpc8xxx.c +1 -2
index 01634c8d27b3..a964e25ea620 100644
@@ -47,7 +47,7 @@ struct mpc8xxx_gpio_chip {
                                unsigned offset, int value);
 
        struct irq_domain *irq;
-       unsigned int irqn;
+       int irqn;
 };
 
 /*
--
Quoted 2 lines

2.20.1.7.g153144c

Queued for fixes, thanks!

Bart

#3 lore raw
In reply to Yang Li
Quoted 30 lines · Yang Li

The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'parent_irq', so making 'parent_irq' an int.

Eliminate the following coccicheck warning:
./drivers/gpio/gpio-idt3243x.c:167:6-16: WARNING: Unsigned expression compared with zero: parent_irq < 0

Fixes 30fee1d7462a ("gpio: idt3243x: Fix IRQ check in idt_gpio_probe")
---
 drivers/gpio/gpio-idt3243x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-idt3243x.c +1 -2
index 08493b05be2d..52b8b72ded77 100644
@@ -132,7 +132,7 @@ static int idt_gpio_probe(struct platform_device *pdev)
        struct device *dev = &pdev->dev;
        struct gpio_irq_chip *girq;
        struct idt_gpio_ctrl *ctrl;
-       unsigned int parent_irq;
+       int parent_irq;
        int ngpios;
        int ret;
 
--
Quoted 2 lines

2.20.1.7.g153144c

Queued for fixes, thanks!

Bart