drivers/virtio: Enable virtio mem for ARM64
PATCH v3 1/1 drivers/virtio: Enable virtio mem for ARM64
This enables virtio-mem device support by allowing to enable the corresponding kernel config option (CONFIG_VIRTIO_MEM) on the architecture.
---
v3: Pick ack-by tags from Jonathan and Michael
--- drivers/virtio/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/virtio/Kconfig +4 -3
@@ -106,7 +106,7 @@ config VIRTIO_BALLOON config VIRTIO_MEM tristate "Virtio mem driver" default m - depends on X86_64 + depends on X86_64 || ARM64 depends on VIRTIO depends on MEMORY_HOTPLUG depends on MEMORY_HOTREMOVE
@@ -116,8 +116,9 @@ config VIRTIO_MEM This driver provides access to virtio-mem paravirtualized memory devices, allowing to hotplug and hotunplug memory. - This driver was only tested under x86-64, but should theoretically - work on all architectures that support memory hotplug and hotremove. + This driver was only tested under x86-64 and arm64, but should + theoretically work on all architectures that support memory hotplug + and hotremove. If unsure, say M.
Signature · 6 lines
2.23.0 _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Michael S. Tsirkin
maintainerQuoted 28 lines · Gavin Shan
This enables virtio-mem device support by allowing to enable the corresponding kernel config option (
CONFIG_VIRTIO_MEM) on the architecture.Signed-off-by Gavin Shan <[email protected]>Acked-by Jonathan Cameron <[email protected]>---
v3: Pick ack-by tags from Jonathan and Michael--- drivers/virtio/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/virtio/Kconfig +1
-1@@ -106,7 +106,7 @@ config VIRTIO_BALLOON config VIRTIO_MEM tristate "Virtio mem driver" default m - depends on X86_64 + depends on X86_64 || ARM64 depends on VIRTIO depends on MEMORY_HOTPLUG depends on MEMORY_HOTREMOVE
drivers/virtio/Kconfig config VIRTIO_MEM · line 122
Quoted 9 lines
drivers/virtio/Kconfig +3
-2@@ -116,8 +116,9 @@ config VIRTIO_MEM This driver provides access to virtio-mem paravirtualized memory devices, allowing to hotplug and hotunplug memory. - This driver was only tested under x86-64, but should theoretically - work on all architectures that support memory hotplug and hotremove. + This driver was only tested under x86-64 and arm64, but should + theoretically work on all architectures that support memory hotplug + and hotremove.
BTW isn't there a symbol saying "memory hotplug" that we can depend on?
Quoted 4 lines
drivers/virtio/Kconfig +0
-0If unsure, say M.Signature · 1 line
2.23.0
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Hi Michael,
Quoted 32 lines · Michael S. Tsirkin
Quoted 31 lines · Gavin Shan
This enables virtio-mem device support by allowing to enable the corresponding kernel config option (
CONFIG_VIRTIO_MEM) on the architecture.Signed-off-by Gavin Shan <[email protected]>Acked-by Jonathan Cameron <[email protected]>---
v3: Pick ack-by tags from Jonathan and Michael--- drivers/virtio/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/virtio/Kconfig +1
-1@@ -106,7 +106,7 @@ config VIRTIO_BALLOON config VIRTIO_MEM tristate "Virtio mem driver" default m - depends on X86_64 + depends on X86_64 || ARM64 depends on VIRTIO depends on MEMORY_HOTPLUG depends on MEMORY_HOTREMOVE@@ -116,8 +116,9 @@ config VIRTIO_MEM This driver provides access to virtio-mem paravirtualized memory devices, allowing to hotplug and hotunplug memory.
Quoted 9 lines
drivers/virtio/Kconfig config VIRTIO_MEM · line 122
Quoted 6 lines
drivers/virtio/Kconfig +3
-2- This driver was only tested under x86-64, but should theoretically - work on all architectures that support memory hotplug and hotremove. + This driver was only tested under x86-64 and arm64, but should + theoretically work on all architectures that support memory hotplug + and hotremove.BTW isn't there a symbol saying "memory hotplug" that we can depend on?
You mean to change it like below? Actually, both looks good to me :)
+ This driver was only tested under x86-64 and arm64, but should
+ theoretically work on all architectures.
Quoted 2 lines
drivers/virtio/Kconfig config VIRTIO_MEM · line 124
Quoted 2 lines
drivers/virtio/Kconfig +0
-0If unsure, say M.
Thanks,
Gavin
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 44 lines · Gavin Shan
Hi Michael,
Quoted 41 lines · Michael S. Tsirkin
Quoted 28 lines · Gavin Shan
This enables virtio-mem device support by allowing to enable the corresponding kernel config option (
CONFIG_VIRTIO_MEM) on the architecture.Signed-off-by Gavin Shan <[email protected]>Acked-by Jonathan Cameron <[email protected]>---
v3: Pick ack-by tags from Jonathan and Michael--- drivers/virtio/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/virtio/Kconfig +1
-1@@ -106,7 +106,7 @@ config VIRTIO_BALLOON config VIRTIO_MEM tristate "Virtio mem driver" default m - depends on X86_64 + depends on X86_64 || ARM64 depends on VIRTIO depends on MEMORY_HOTPLUG depends on MEMORY_HOTREMOVEdrivers/virtio/Kconfig config VIRTIO_MEM · line 122
Quoted 9 lines
drivers/virtio/Kconfig +3
-2@@ -116,8 +116,9 @@ config VIRTIO_MEM This driver provides access to virtio-mem paravirtualized memory devices, allowing to hotplug and hotunplug memory. - This driver was only tested under x86-64, but should theoretically - work on all architectures that support memory hotplug and hotremove. + This driver was only tested under x86-64 and arm64, but should + theoretically work on all architectures that support memory hotplug + and hotremove.BTW isn't there a symbol saying "memory hotplug" that we can depend on?
You mean
depends on MEMORY_HOTPLUG
depends on MEMORY_HOTREMOVE
We still need a manual opt-in from architectures, because devil's in the detail. (e.g., memblock stuff we had to adjust)
Signature · 8 lines
Thanks, David / dhildenb _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Michael S. Tsirkin
maintainerQuoted 51 lines · David Hildenbrand
Quoted 44 lines · Gavin Shan
Hi Michael,
Quoted 41 lines · Michael S. Tsirkin
Quoted 28 lines · Gavin Shan
This enables virtio-mem device support by allowing to enable the corresponding kernel config option (
CONFIG_VIRTIO_MEM) on the architecture.Signed-off-by Gavin Shan <[email protected]>Acked-by Jonathan Cameron <[email protected]>---
v3: Pick ack-by tags from Jonathan and Michael--- drivers/virtio/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/virtio/Kconfig +1
-1@@ -106,7 +106,7 @@ config VIRTIO_BALLOON config VIRTIO_MEM tristate "Virtio mem driver" default m - depends on X86_64 + depends on X86_64 || ARM64 depends on VIRTIO depends on MEMORY_HOTPLUG depends on MEMORY_HOTREMOVEdrivers/virtio/Kconfig config VIRTIO_MEM · line 122
Quoted 9 lines
drivers/virtio/Kconfig +3
-2@@ -116,8 +116,9 @@ config VIRTIO_MEM This driver provides access to virtio-mem paravirtualized memory devices, allowing to hotplug and hotunplug memory. - This driver was only tested under x86-64, but should theoretically - work on all architectures that support memory hotplug and hotremove. + This driver was only tested under x86-64 and arm64, but should + theoretically work on all architectures that support memory hotplug + and hotremove.BTW isn't there a symbol saying "memory hotplug" that we can depend on?
You mean
drivers/virtio/Kconfig +0
-0depends on MEMORY_HOTPLUG depends on MEMORY_HOTREMOVE
Quoted 2 lines
We still need a manual opt-in from architectures, because devil's in the detail. (e.g., memblock stuff we had to adjust)
Is there any chance of documenting some of this here? The current comment makes it look like it's just a question of whitelisting an architecture.
Quoted 4 lines
Signature · 3 lines
Thanks, David / dhildenb
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 49 lines · Michael S. Tsirkin
Quoted 48 lines · David Hildenbrand
Quoted 44 lines · Gavin Shan
Hi Michael,
Quoted 41 lines · Michael S. Tsirkin
Quoted 28 lines · Gavin Shan
This enables virtio-mem device support by allowing to enable the corresponding kernel config option (
CONFIG_VIRTIO_MEM) on the architecture.Signed-off-by Gavin Shan <[email protected]>Acked-by Jonathan Cameron <[email protected]>---
v3: Pick ack-by tags from Jonathan and Michael--- drivers/virtio/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/virtio/Kconfig +1
-1@@ -106,7 +106,7 @@ config VIRTIO_BALLOON config VIRTIO_MEM tristate "Virtio mem driver" default m - depends on X86_64 + depends on X86_64 || ARM64 depends on VIRTIO depends on MEMORY_HOTPLUG depends on MEMORY_HOTREMOVEdrivers/virtio/Kconfig config VIRTIO_MEM · line 122
Quoted 9 lines
drivers/virtio/Kconfig +3
-2@@ -116,8 +116,9 @@ config VIRTIO_MEM This driver provides access to virtio-mem paravirtualized memory devices, allowing to hotplug and hotunplug memory. - This driver was only tested under x86-64, but should theoretically - work on all architectures that support memory hotplug and hotremove. + This driver was only tested under x86-64 and arm64, but should + theoretically work on all architectures that support memory hotplug + and hotremove.BTW isn't there a symbol saying "memory hotplug" that we can depend on?
You mean
Quoted 8 lines
Quoted 5 lines
drivers/virtio/Kconfig +0
-0depends on MEMORY_HOTPLUG depends on MEMORY_HOTREMOVEWe still need a manual opt-in from architectures, because devil's in the detail. (e.g., memblock stuff we had to adjust)
Is there any chance of documenting some of this here? The current comment makes it look like it's just a question of whitelisting an architecture.
I can send a patch to add more details.
Signature · 8 lines
Thanks, David / dhildenb _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Michael S. Tsirkin
maintainerQuoted 53 lines · David Hildenbrand
Quoted 52 lines · Michael S. Tsirkin
Quoted 51 lines · David Hildenbrand
Quoted 44 lines · Gavin Shan
Hi Michael,
Quoted 41 lines · Michael S. Tsirkin
Quoted 28 lines · Gavin Shan
This enables virtio-mem device support by allowing to enable the corresponding kernel config option (
CONFIG_VIRTIO_MEM) on the architecture.Signed-off-by Gavin Shan <[email protected]>Acked-by Jonathan Cameron <[email protected]>---
v3: Pick ack-by tags from Jonathan and Michael--- drivers/virtio/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/virtio/Kconfig +1
-1@@ -106,7 +106,7 @@ config VIRTIO_BALLOON config VIRTIO_MEM tristate "Virtio mem driver" default m - depends on X86_64 + depends on X86_64 || ARM64 depends on VIRTIO depends on MEMORY_HOTPLUG depends on MEMORY_HOTREMOVEdrivers/virtio/Kconfig config VIRTIO_MEM · line 122
Quoted 9 lines
drivers/virtio/Kconfig +3
-2@@ -116,8 +116,9 @@ config VIRTIO_MEM This driver provides access to virtio-mem paravirtualized memory devices, allowing to hotplug and hotunplug memory. - This driver was only tested under x86-64, but should theoretically - work on all architectures that support memory hotplug and hotremove. + This driver was only tested under x86-64 and arm64, but should + theoretically work on all architectures that support memory hotplug + and hotremove.BTW isn't there a symbol saying "memory hotplug" that we can depend on?
You mean
drivers/virtio/Kconfig +0
-0depends on MEMORY_HOTPLUG depends on MEMORY_HOTREMOVE
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
We still need a manual opt-in from architectures, because devil's in the detail. (e.g., memblock stuff we had to adjust)
Is there any chance of documenting some of this here? The current comment makes it look like it's just a question of whitelisting an architecture.
I can send a patch to add more details.
oks so that will be a patch on top?
Quoted 4 lines
Signature · 3 lines
Thanks, David / dhildenb
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 57 lines · Michael S. Tsirkin
Quoted 56 lines · David Hildenbrand
Quoted 55 lines · Michael S. Tsirkin
Quoted 53 lines · David Hildenbrand
Quoted 44 lines · Gavin Shan
Hi Michael,
Quoted 41 lines · Michael S. Tsirkin
Quoted 28 lines · Gavin Shan
This enables virtio-mem device support by allowing to enable the corresponding kernel config option (
CONFIG_VIRTIO_MEM) on the architecture.Signed-off-by Gavin Shan <[email protected]>Acked-by Jonathan Cameron <[email protected]>---
v3: Pick ack-by tags from Jonathan and Michael--- drivers/virtio/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/virtio/Kconfig +1
-1@@ -106,7 +106,7 @@ config VIRTIO_BALLOON config VIRTIO_MEM tristate "Virtio mem driver" default m - depends on X86_64 + depends on X86_64 || ARM64 depends on VIRTIO depends on MEMORY_HOTPLUG depends on MEMORY_HOTREMOVEdrivers/virtio/Kconfig config VIRTIO_MEM · line 122
Quoted 9 lines
drivers/virtio/Kconfig +3
-2@@ -116,8 +116,9 @@ config VIRTIO_MEM This driver provides access to virtio-mem paravirtualized memory devices, allowing to hotplug and hotunplug memory. - This driver was only tested under x86-64, but should theoretically - work on all architectures that support memory hotplug and hotremove. + This driver was only tested under x86-64 and arm64, but should + theoretically work on all architectures that support memory hotplug + and hotremove.BTW isn't there a symbol saying "memory hotplug" that we can depend on?
You mean
(quoted diff) +0
-0depends on MEMORY_HOTPLUG depends on MEMORY_HOTREMOVEWe still need a manual opt-in from architectures, because devil's in the detail. (e.g., memblock stuff we had to adjust)
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Is there any chance of documenting some of this here? The current comment makes it look like it's just a question of whitelisting an architecture.
I can send a patch to add more details.
oks so that will be a patch on top?
Yes, it's independent of arm64 support.
Signature · 8 lines
Thanks, David / dhildenb _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization