Skip to contentSkip to conversation

dt-bindings: i2c: imx: Make each example a separate entry

PATCH Applied Rob Herring 2 participants 3 messages Jan 19, 2022 – Jan 23, 2022

Subsystems (4)
Device tree bindings Arm i.MX and Layerscape I2C subsystem host drivers Freescale i.MX I2C driver
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: i2c: imx: Make each example a separate entry

Each independent example should be a separate entry. This allows for 'interrupts' to have different cell sizes.

Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/i2c/i2c-imx.yaml +4 -3
index c167958ae2a9..01720e338b4c 100644
@@ -88,9 +88,7 @@ unevaluatedProperties: false
 examples:
   - |
     #include <dt-bindings/clock/imx5-clock.h>
-    #include <dt-bindings/clock/vf610-clock.h>
-    #include <dt-bindings/gpio/gpio.h>
-    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
 
     i2c@83fc4000 {
         compatible = "fsl,imx51-i2c", "fsl,imx21-i2c";

@@ -99,6 +97,9 @@ examples:
         clocks = <&clks IMX5_CLK_I2C2_GATE>;
     };
 
+  - |
+    #include <dt-bindings/clock/vf610-clock.h>
+
     i2c@40066000 {
         compatible = "fsl,vf610-i2c";
         reg = <0x40066000 0x1000>;
Signature · 1 line
2.32.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Rob Herring

Each independent example should be a separate entry. This allows for 'interrupts' to have different cell sizes.

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Oleksij Rempel <[email protected]>

Thank you!

Quoted 34 lines
---
 Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/i2c/i2c-imx.yaml +4 -3
index c167958ae2a9..01720e338b4c 100644
@@ -88,9 +88,7 @@ unevaluatedProperties: false
 examples:
   - |
     #include <dt-bindings/clock/imx5-clock.h>
-    #include <dt-bindings/clock/vf610-clock.h>
-    #include <dt-bindings/gpio/gpio.h>
-    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
 
     i2c@83fc4000 {
         compatible = "fsl,imx51-i2c", "fsl,imx21-i2c";

@@ -99,6 +97,9 @@ examples:
         clocks = <&clks IMX5_CLK_I2C2_GATE>;
     };
 
+  - |
+    #include <dt-bindings/clock/vf610-clock.h>
+
     i2c@40066000 {
         compatible = "fsl,vf610-i2c";
         reg = <0x40066000 0x1000>;
Signature · 1 line
2.32.0
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
author maintainer Applied
#2 lore raw
In reply to Rob Herring
Quoted 8 lines · Rob Herring

Each independent example should be a separate entry. This allows for 'interrupts' to have different cell sizes.

Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Applied, thanks!