Skip to contentSkip to conversation

usb: gadget: at91_udc: fix incorrect print type

PATCH In review Miles Chen 2 participants 2 messages Jan 19, 2022

Subsystems (3)
lore
Share & tools
lore

Miles Chen

author
#0 lore raw

PATCH 1/1 usb: gadget: at91_udc: fix incorrect print type

Fix a build error observed with ARCH=arm DEFCONFIG=allmodconfig build.

drivers/usb/gadget/udc/at91_udc.h:174:42: error: format '%d' expects argument of type 'int', but argument 3 has type 'struct gpio_desc *' [-Werror=format=]

Fixes 4a555f2b8d31 ("usb: gadget: at91_udc: Convert to GPIO descriptors")
---
 drivers/usb/gadget/udc/at91_udc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/udc/at91_udc.c +1 -1
index dd0819df096e..9040a0561466 100644
@@ -1895,7 +1895,7 @@ static int at91udc_probe(struct platform_device *pdev)
 					at91_vbus_irq, 0, driver_name, udc);
 			if (retval) {
 				DBG("request vbus irq %d failed\n",
-				    udc->board.vbus_pin);
+				    desc_to_gpio(udc->board.vbus_pin));
 				goto err_unprepare_iclk;
 			}
 		}
Signature · 1 line
2.18.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Miles Chen

Fix a build error observed with ARCH=arm DEFCONFIG=allmodconfig build.

drivers/usb/gadget/udc/at91_udc.h:174:42: error: format '%d' expects argument of type 'int', but argument 3 has type 'struct gpio_desc *' [-Werror=format=]

Fixes 4a555f2b8d31 ("usb: gadget: at91_udc: Convert to GPIO descriptors")
---
  drivers/usb/gadget/udc/at91_udc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/udc/at91_udc.c +0 -0
index dd0819df096e..9040a0561466 100644

drivers/usb/gadget/udc/at91_udc.c static int at91udc_probe(struct platform_device *pdev) · line 1901

Quoted 8 lines
drivers/usb/gadget/udc/at91_udc.c +1 -1
@@ -1895,7 +1895,7 @@ static int at91udc_probe(struct platform_device *pdev)
  					at91_vbus_irq, 0, driver_name, udc);
  			if (retval) {
  				DBG("request vbus irq %d failed\n",
-				    udc->board.vbus_pin);
+				    desc_to_gpio(udc->board.vbus_pin));
  				goto err_unprepare_iclk;
  			}
  		}

Thanks!
Macpaul Lin