Skip to contentSkip to conversation

mmc: sdhci-pci-gli: Reduce the SSC value at 205MHz for GL9750 and GL9755

PATCH In review Ben Chuang 2 participants 2 messages Jan 19, 2022 – Jan 24, 2022

Subsystems (2)
lore
Share & tools
lore

Ben Chuang

author
#0 lore raw

PATCH 1/3 mmc: sdhci-pci-gli: Reduce the SSC value at 205MHz for GL9750 and GL9755

From: Ben Chuang <[email protected]>

The SSC value is 0xFFE7 at 205MHz and may be saturated. Reduce the SSC value to 0x5A1D at 205MHz to reduce this situation for GL9750 and GL9755.

---
 drivers/mmc/host/sdhci-pci-gli.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/sdhci-pci-gli.c +2 -2
index 4fd99c1e82ba..9ead32d73447 100644
@@ -390,7 +390,7 @@ static void gl9750_set_ssc(struct sdhci_host *host, u8 enable, u8 step, u16 ppm)
 static void gl9750_set_ssc_pll_205mhz(struct sdhci_host *host)
 {
 	/* set pll to 205MHz and enable ssc */
-	gl9750_set_ssc(host, 0x1, 0x1F, 0xFFE7);
+	gl9750_set_ssc(host, 0x1, 0xF, 0x5A1D);
 	gl9750_set_pll(host, 0x1, 0x246, 0x0);
 }
 
@@ -533,7 +533,7 @@ static void gl9755_set_ssc(struct pci_dev *pdev, u8 enable, u8 step, u16 ppm)
 static void gl9755_set_ssc_pll_205mhz(struct pci_dev *pdev)
 {
 	/* set pll to 205MHz and enable ssc */
-	gl9755_set_ssc(pdev, 0x1, 0x1F, 0xFFE7);
+	gl9755_set_ssc(pdev, 0x1, 0xF, 0x5A1D);
 	gl9755_set_pll(pdev, 0x1, 0x246, 0x0);
 }
 
Signature · 1 line
2.34.1
#1 lore raw
Quoted 7 lines · Ben Chuang

From: Ben Chuang <[email protected]>

The SSC value is 0xFFE7 at 205MHz and may be saturated. Reduce the SSC value to 0x5A1D at 205MHz to reduce this situation for GL9750 and GL9755.

Applied for next, thanks!

Kind regards
Uffe

Quoted 29 lines
---
 drivers/mmc/host/sdhci-pci-gli.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/sdhci-pci-gli.c +2 -3
index 4fd99c1e82ba..9ead32d73447 100644
@@ -390,7 +390,7 @@ static void gl9750_set_ssc(struct sdhci_host *host, u8 enable, u8 step, u16 ppm)
 static void gl9750_set_ssc_pll_205mhz(struct sdhci_host *host)
 {
        /* set pll to 205MHz and enable ssc */
-       gl9750_set_ssc(host, 0x1, 0x1F, 0xFFE7);
+       gl9750_set_ssc(host, 0x1, 0xF, 0x5A1D);
        gl9750_set_pll(host, 0x1, 0x246, 0x0);
 }
 
@@ -533,7 +533,7 @@ static void gl9755_set_ssc(struct pci_dev *pdev, u8 enable, u8 step, u16 ppm)
 static void gl9755_set_ssc_pll_205mhz(struct pci_dev *pdev)
 {
        /* set pll to 205MHz and enable ssc */
-       gl9755_set_ssc(pdev, 0x1, 0x1F, 0xFFE7);
+       gl9755_set_ssc(pdev, 0x1, 0xF, 0x5A1D);
        gl9755_set_pll(pdev, 0x1, 0x246, 0x0);
 }
 
--

2.34.1