Skip to contentSkip to conversation

station: send debug "roam-scan-triggered" event

PATCH In review James Prestwood 2 participants 4 messages Jan 19, 2022

lore
Share & tools
lore

James Prestwood

author
#0 lore raw

PATCH v3 1/3 station: send debug "roam-scan-triggered" event

---
 src/station.c | 2 ++
 1 file changed, 2 insertions(+)
src/station.c +2 -0
index 38d0757c..d9eb8d09 100644
@@ -2246,6 +2246,8 @@ static void station_roam_scan_triggered(int err, void *user_data)
 		return;
 	}
 
+	station_debug_event(station, "roam-scan-triggered");
+
 	/*
 	 * Do not update the Scanning property as we won't be updating the
 	 * list of networks.
Signature · 1 line
2.31.1
author
#1 lore raw

PATCH v3 2/3 auto-t: hostapd.py: add remove_neighbor()

---
 autotests/util/hostapd.py | 4 ++++
 1 file changed, 4 insertions(+)
autotests/util/hostapd.py +4 -0
index 97422efc..4ae7c42d 100644
@@ -168,6 +168,10 @@ class HostapdCLI(object):
         cmd = self.cmdline + ['set_neighbor', addr, 'ssid="%s"' % ssid, 'nr=%s' % nr]
         ctx.start_process(cmd).wait()
 
+    def remove_neighbor(self, addr):
+        cmd = self.cmdline + ['remove_neighbor', addr]
+        ctx.start_process(cmd).wait()
+
     def send_bss_transition(self, device, nr_list):
         # Send a BSS transition to a station (device). nr_list should be an
         # array of tuples containing the BSS address and neighbor report.
Signature · 1 line
2.31.1
author
#2 lore raw

PATCH v3 3/3 auto-t: roam test to simulate reported crash

In reply to James Prestwood

During investigation another separate crash was found. The original is caused by a disconnect event coming in after a neighbor report scan was completed (roam failed) during the full roam scan.

The second crash is caused by a disconnect coming in during a full roam scan when no neighbor report scan was ever issued.

---
 autotests/testPSK-roam/connection_test.py     |   2 +
 autotests/testPSK-roam/main.conf              |   3 +
 .../testPSK-roam/roam_ap_disconnect_test.py   | 101 ++++++++++++++++++
 3 files changed, 106 insertions(+)
 create mode 100644 autotests/testPSK-roam/roam_ap_disconnect_test.py
autotests/testPSK-roam/connection_test.py +2 -0
index 8d9b22ad..92fdeb04 100644
@@ -203,6 +203,8 @@ class Test(unittest.TestCase):
     def tearDownClass(cls):
         IWD.clear_storage()
         cls.bss_hostapd = None
+        cls.rule0.enabled = False
+        cls.rule0.remove()
 
 if __name__ == '__main__':
     unittest.main(exit=True)
autotests/testPSK-roam/main.conf +3 -0
index 9452fb6b..3d93ff57 100644
@@ -1,2 +1,5 @@
 [Scan]
 DisableMacAddressRandomization=true
+
+[General]
+RoamRetryInterval=1
autotests/testPSK-roam/roam_ap_disconnect_test.py new file +101 -0

101 lines not on this page · raw message

Signature · 1 line
2.31.1
#3 lore raw
In reply to James Prestwood

Hi James,

Quoted 3 lines · James Prestwood
---
  src/station.c | 2 ++
  1 file changed, 2 insertions(+)

All applied, thanks.

Regards,
-Denis