Skip to contentSkip to conversation

drm/radeon: remove redundant assignment to reg

PATCH Applied Colin Ian King 3 participants 3 messages Jan 19, 2022 – Jan 24, 2022

Subsystems (3)
DRM drivers Kernel janitors Radeon and amdgpu DRM drivers
lore
Share & tools
lore

Colin Ian King

author
#0 lore raw

PATCH 1/1 drm/radeon: remove redundant assignment to reg

The pointer reg is being assigned a value that is not read, the exit path via label 'out' never accesses it. The assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/gpu/drm/radeon/radeon_object.c:570:3: warning: Value stored to 'reg' is never read [deadcode.DeadStores]

Signed-off-by Colin Ian King <[email protected]>
---
 drivers/gpu/drm/radeon/radeon_object.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/radeon/radeon_object.c +0 -1
index 56ede9d63b12..87536d205593 100644
@@ -567,7 +567,6 @@ int radeon_bo_get_surface_reg(struct radeon_bo *bo)
 		return 0;
 
 	if (bo->surface_reg >= 0) {
-		reg = &rdev->surface_regs[bo->surface_reg];
 		i = bo->surface_reg;
 		goto out;
 	}
Signature · 1 line
2.33.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Colin Ian King

The pointer reg is being assigned a value that is not read, the exit path via label 'out' never accesses it. The assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/gpu/drm/radeon/radeon_object.c:570:3: warning: Value stored to 'reg' is never read [deadcode.DeadStores]

Signed-off-by Colin Ian King <[email protected]>

Thanks for the patch!

Reviewed-by Nick Desaulniers <[email protected]>
Quoted 20 lines
---
 drivers/gpu/drm/radeon/radeon_object.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/radeon/radeon_object.c +0 -2
index 56ede9d63b12..87536d205593 100644
@@ -567,7 +567,6 @@ int radeon_bo_get_surface_reg(struct radeon_bo *bo)
                return 0;
 
        if (bo->surface_reg >= 0) {
-               reg = &rdev->surface_regs[bo->surface_reg];
                i = bo->surface_reg;
                goto out;
        }
--

2.33.1

Signature · 2 lines
Thanks,
~Nick Desaulniers
Applied
#2 lore raw

Applied. Thanks!

Alex

Quoted 41 lines · Nick Desaulniers
Quoted 10 lines · Colin Ian King

The pointer reg is being assigned a value that is not read, the exit path via label 'out' never accesses it. The assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/gpu/drm/radeon/radeon_object.c:570:3: warning: Value stored to 'reg' is never read [deadcode.DeadStores]

Signed-off-by Colin Ian King <[email protected]>

Thanks for the patch!

Reviewed-by Nick Desaulniers <[email protected]>
Quoted 17 lines
---
 drivers/gpu/drm/radeon/radeon_object.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/radeon/radeon_object.c +0 -2
index 56ede9d63b12..87536d205593 100644
@@ -567,7 +567,6 @@ int radeon_bo_get_surface_reg(struct radeon_bo *bo)
                return 0;
 
        if (bo->surface_reg >= 0) {
-               reg = &rdev->surface_regs[bo->surface_reg];
                i = bo->surface_reg;
                goto out;
        }
--
Quoted 3 lines

2.33.1

--
Thanks,
~Nick Desaulniers