Skip to contentSkip to conversation

pipe: remove redundant assignment to pointer buf

PATCH In review Colin Ian King 2 participants 2 messages Jan 19, 2022 – Jan 20, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pipe: remove redundant assignment to pointer buf

The pointer buf is being assigned a value that is never read, it is being re-assigned later on closer to where is it required to be set. The assignment is redundant and can be removed. Cleans up clang scan build warning:

fs/pipe.c:490:24: warning: Value stored to 'buf' during its initialization is never read [deadcode.DeadStores]

---
 fs/pipe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/pipe.c +1 -1
index cc28623a67b6..d19229df66ee 100644
@@ -487,7 +487,7 @@ pipe_write(struct kiocb *iocb, struct iov_iter *from)
 		head = pipe->head;
 		if (!pipe_full(head, pipe->tail, pipe->max_usage)) {
 			unsigned int mask = pipe->ring_size - 1;
-			struct pipe_buffer *buf = &pipe->bufs[head & mask];
+			struct pipe_buffer *buf;
 			struct page *page = pipe->tmp_page;
 			int copied;
 
Signature · 1 line
2.33.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Colin Ian King

The pointer buf is being assigned a value that is never read, it is being re-assigned later on closer to where is it required to be set. The assignment is redundant and can be removed. Cleans up clang scan build warning:

fs/pipe.c:490:24: warning: Value stored to 'buf' during its initialization is never read [deadcode.DeadStores]

---