Skip to contentSkip to conversation

ntfs: add sanity check on allocation size

PATCH Applied Dongliang Mu 1 participant 1 message Jan 20, 2022 NTFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ntfs: add sanity check on allocation size

From: Dongliang Mu <[email protected]>

ntfs_read_inode_mount invokes ntfs_malloc_nofs with zero allocation size. It triggers one BUG in the __ntfs_malloc function.

Fix this by adding sanity check on ni->attr_list_size.

---
 fs/ntfs/inode.c | 4 ++++
 1 file changed, 4 insertions(+)
fs/ntfs/inode.c +4 -0
index 4474adb393ca..517b71c73aa9 100644
@@ -1881,6 +1881,10 @@ int ntfs_read_inode_mount(struct inode *vi)
 		}
 		/* Now allocate memory for the attribute list. */
 		ni->attr_list_size = (u32)ntfs_attr_size(a);
+		if (!ni->attr_list_size) {
+			ntfs_error(sb, "Attr_list_size is zero");
+			goto put_err_out;
+		}
 		ni->attr_list = ntfs_malloc_nofs(ni->attr_list_size);
 		if (!ni->attr_list) {
 			ntfs_error(sb, "Not enough memory to allocate buffer "
Signature · 1 line
2.25.1