Skip to contentSkip to conversation

net/ice: fix ieee1588fwd not show PTP timestamp

PATCH Applied Simei Su 2 participants 2 messages Jan 20, 2022 – Jan 25, 2022 Network drivers

lore
Share & tools
lore

Simei Su

author
#0 lore raw

PATCH 1/1 net/ice: fix ieee1588fwd not show PTP timestamp

For received PTP packets, the flag "RTE_MBUF_F_RX_IEEE1588_TMST" has not been set which leads to received PTP packet not timestamped by hardware shown in testpmd/ieee1588 fwd.

Fixes 646dcbe6c701 ("net/ice: support IEEE 1588 PTP")
---
 drivers/net/ice/ice_rxtx.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/net/ice/ice_rxtx.c +7 -0
index d50acf5..d7276d7 100644
@@ -1554,6 +1554,9 @@ ice_rxd_to_vlan_tci(struct rte_mbuf *mb, volatile union ice_rx_flex_desc *rxdp)
 #if (ICE_LOOK_AHEAD != 8)
 #error "PMD ICE: ICE_LOOK_AHEAD must be 8\n"
 #endif
+
+#define ICE_PTP_TS_VALID 0x1
+
 static inline int
 ice_rx_scan_hw_ring(struct ice_rx_queue *rxq)
 {
@@ -1634,6 +1637,10 @@ ice_rx_scan_hw_ring(struct ice_rx_queue *rxq)
 				   rte_le_to_cpu_32(rxdp[j].wb.flex_ts.ts_high);
 				mb->timesync = rxq->queue_id;
 				pkt_flags |= RTE_MBUF_F_RX_IEEE1588_PTP;
+				if (rxdp[j].wb.time_stamp_low &
+				    ICE_PTP_TS_VALID)
+					pkt_flags |=
+						RTE_MBUF_F_RX_IEEE1588_TMST;
 			}
 #endif
 			mb->ol_flags |= pkt_flags;
Signature · 1 line
2.9.5
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Su, Simei <[email protected]>
Sent: Thursday, January 20, 2022 6:22 PM
To: Zhang, Qi Z <[email protected]>; Yang, Qiming <[email protected]>
Cc: [email protected]; Wu, Wenjun1 <[email protected]>; Su, Simei <[email protected]>; [email protected]
Subject: [PATCH] net/ice: fix ieee1588fwd not show PTP timestamp

Renamed to
fix missing mbuf offload flag for Rx timestamp

Quoted 9 lines

For received PTP packets, the flag "RTE_MBUF_F_RX_IEEE1588_TMST" has not been set which leads to received PTP packet not timestamped by hardware shown in testpmd/ieee1588 fwd.

Fixes 646dcbe6c701 ("net/ice: support IEEE 1588 PTP")

Applied to dpdk-next-net-intel.

Thanks
Qi

Quoted 32 lines
---
 drivers/net/ice/ice_rxtx.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/net/ice/ice_rxtx.c index renamed from drivers/net/ice/ice_rxtx.c +0 -0

d50acf5..d7276d7 100644

drivers/net/ice/ice_rxtx.c +0 -0
@@ -1554,6 +1554,9 @@ ice_rxd_to_vlan_tci(struct rte_mbuf *mb, volatile

union ice_rx_flex_desc *rxdp) #if (ICE_LOOK_AHEAD != 8) #error "PMD ICE:
ICE_LOOK_AHEAD must be 8\n"
#endif

drivers/net/ice/ice_rxtx.c +3 -0
+
+#define ICE_PTP_TS_VALID 0x1
+
 static inline int
 ice_rx_scan_hw_ring(struct ice_rx_queue *rxq)  { @@ -1634,6 +1637,10 @@

ice_rx_scan_hw_ring(struct ice_rx_queue *rxq)

rte_le_to_cpu_32(rxdp[j].wb.flex_ts.ts_high);

drivers/net/ice/ice_rxtx.c +4 -0
 				mb->timesync = rxq->queue_id;
 				pkt_flags |= RTE_MBUF_F_RX_IEEE1588_PTP;
+				if (rxdp[j].wb.time_stamp_low &
+				    ICE_PTP_TS_VALID)
+					pkt_flags |=
+
	RTE_MBUF_F_RX_IEEE1588_TMST;
drivers/net/ice/ice_rxtx.c +0 -1
 			}
 #endif
 			mb->ol_flags |= pkt_flags;
--

2.9.5