Skip to contentSkip to conversation

power: gemini-poweroff: Fix IRQ check in gemini_poweroff_probe

PATCH In review Miaoqian Lin 2 participants 2 messages Jan 20, 2022 – Jan 23, 2022 System reset/shutdown drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 power: gemini-poweroff: Fix IRQ check in gemini_poweroff_probe

platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes f7a388d6cd1c ("power: reset: Add a driver for the Gemini poweroff")
---
 drivers/power/reset/gemini-poweroff.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/power/reset/gemini-poweroff.c +2 -2
index 90e35c07240a..b7f7a8225f22 100644
@@ -107,8 +107,8 @@ static int gemini_poweroff_probe(struct platform_device *pdev)
 		return PTR_ERR(gpw->base);
 
 	irq = platform_get_irq(pdev, 0);
-	if (!irq)
-		return -EINVAL;
+	if (irq < 0)
+		return irq;
 
 	gpw->dev = dev;
 
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Miaoqian Lin

platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes f7a388d6cd1c ("power: reset: Add a driver for the Gemini poweroff")

Yours,
Linus Walleij