build: remove custom dependency checks in drivers
Subsystems (3)
PATCH 1/1 build: remove custom dependency checks in drivers
Some drivers currently have their own checks and give some non consistent reasons when an internal dependency is unavailable.
drivers/meson.build also checks for internal dependencies via 'deps'. Let's rely on it for consistency, and smaller code.
--- drivers/net/kni/meson.build | 5 +---- drivers/net/netvsc/meson.build | 4 +--- drivers/net/vhost/meson.build | 4 +--- drivers/raw/dpaa2_cmdif/meson.build | 2 -- drivers/raw/dpaa2_qdma/meson.build | 2 -- drivers/vdpa/ifc/meson.build | 4 +--- 6 files changed, 4 insertions(+), 17 deletions(-)
drivers/net/kni/meson.build +1 -4
@@ -7,8 +7,5 @@ if is_windows subdir_done() endif -# this driver can be built if-and-only-if KNI library is buildable -build = dpdk_conf.has('RTE_LIB_KNI') -reason = 'missing dependency, DPDK KNI library' -sources = files('rte_eth_kni.c') deps += 'kni' +sources = files('rte_eth_kni.c')
drivers/net/netvsc/meson.build +1 -3
@@ -7,8 +7,7 @@ if is_windows subdir_done() endif -build = dpdk_conf.has('RTE_BUS_VMBUS') -reason = 'missing dependency, DPDK VMBus driver' +deps += 'bus_vmbus' sources = files( 'hn_ethdev.c', 'hn_nvs.c',
@@ -17,4 +16,3 @@ sources = files( 'hn_vf.c', ) -deps += ['bus_vmbus' ]
drivers/net/vhost/meson.build +1 -3
@@ -7,8 +7,6 @@ if is_windows subdir_done() endif -build = dpdk_conf.has('RTE_LIB_VHOST') -reason = 'missing dependency, DPDK vhost library' +deps += 'vhost' sources = files('rte_eth_vhost.c') headers = files('rte_eth_vhost.h') -deps += 'vhost'
drivers/raw/dpaa2_cmdif/meson.build +0 -2
@@ -1,8 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright 2018 NXP -build = dpdk_conf.has('RTE_MEMPOOL_DPAA2') -reason = 'missing dependency, DPDK DPAA2 mempool driver' deps += ['rawdev', 'mempool_dpaa2', 'bus_vdev'] sources = files('dpaa2_cmdif.c')
drivers/raw/dpaa2_qdma/meson.build +0 -2
@@ -1,8 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright 2018 NXP -build = dpdk_conf.has('RTE_MEMPOOL_DPAA2') -reason = 'missing dependency, DPDK DPAA2 mempool driver' deps += ['rawdev', 'mempool_dpaa2', 'ring', 'kvargs'] sources = files('dpaa2_qdma.c')
drivers/vdpa/ifc/meson.build +1 -3
@@ -1,8 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel Corporation -build = dpdk_conf.has('RTE_LIB_VHOST') -reason = 'missing dependency, DPDK vhost library' +deps += 'vhost' sources = files('ifcvf_vdpa.c', 'base/ifcvf.c') includes += include_directories('base') -deps += 'vhost'
Signature · 1 line
2.23.0
Quoted 8 lines · David Marchand
Some drivers currently have their own checks and give some non consistent reasons when an internal dependency is unavailable.
drivers/meson.buildalso checks for internal dependencies via 'deps'. Let's rely on it for consistency, and smaller code.Signed-off-by David Marchand <[email protected]>---
Thanks for the cleanup.
Long Li
Acked-byQuoted 6 lines
Subject: Re: [PATCH] build: remove custom dependency checks in drivers
Quoted 3 lines · David Marchand
Some drivers currently have their own checks and give some non consistent reasons when an internal dependency is unavailable.
Quoted 8 lines
Quoted 5 lines
drivers/meson.buildalso checks for internal dependencies via 'deps'. Let's rely on it for consistency, and smaller code.Signed-off-by David Marchand <[email protected]>---
Thanks for the cleanup.
Acked-by Bruce Richardson <[email protected]>
Thank you.
Thomas Monjalon
AppliedQuoted 8 lines
Quoted 8 lines
Quoted 8 lines
Some drivers currently have their own checks and give some non consistent reasons when an internal dependency is unavailable.
drivers/meson.buildalso checks for internal dependencies via 'deps'. Let's rely on it for consistency, and smaller code.Signed-off-by David Marchand <[email protected]>---
Quoted 7 lines
Quoted 3 lines
Thanks for the cleanup.
Acked-by Bruce Richardson <[email protected]>Thank you.
Acked-by Long Li <[email protected]>
Applied, thanks