firmware: dmi-sysfs: Fix memory leak in dmi_system_event_log
PATCH 1/1 firmware: dmi-sysfs: Fix memory leak in dmi_system_event_log
According to the doc of kobject_init_and_add():
If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object.
Fix memory leak by calling kobject_put().
The callback function dmi_entry_free() in kobject_put() will call kfree to handle the pointer.
Fixes 925a1da7477f ("firmware: Break out system_event_log in dmi-sysfs")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/firmware/dmi-sysfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/firmware/dmi-sysfs.c +3 -3
@@ -458,7 +458,7 @@ static int dmi_system_event_log(struct dmi_sysfs_entry *entry) &entry->kobj, "system_event_log");if (ret) - goto out_free; + goto out_put; ret =sysfs_create_bin_file (entry->child, &dmi_sel_raw_attr);if (ret)
@@ -468,8 +468,8 @@ static int dmi_system_event_log(struct dmi_sysfs_entry *entry) out_del:kobject_del (entry->child); -out_free: -kfree (entry->child); +out_put: +kobject_put (entry->child);return ret; }
Signature · 1 line
2.17.1